diff options
8 files changed, 92 insertions, 3 deletions
diff --git a/its/plugin/projects/issues-project/src/file1.css b/its/plugin/projects/issues-project/src/file1.css index 65a0392..ad26232 100644 --- a/its/plugin/projects/issues-project/src/file1.css +++ b/its/plugin/projects/issues-project/src/file1.css @@ -1,7 +1,7 @@ @import "a.css"; @import "a.css"; /* S1128 | no-duplicate-at-import-rules */ -.class1 { +a:unknown { /* S4659 | selector-pseudo-class-no-unknown */ background-color: #ffw; /* S4647 | color-no-invalid-hex */ width: 100pixels; /* S4653 | unit-no-unknown */ /* */ /* S4663 | comment-no-empty */ @@ -16,6 +16,10 @@ padding: 20px; /* S4657 | declaration-block-no-shorthand-property-overrides */ } +.class1 { + width: 100px; +} + .class1 { /* S4666 | no-duplicate-selectors */ width: 100px; } @@ -24,6 +28,10 @@ a { color: pink;; /* S1116 | no-extra-semicolons */ } +a::pseudo { /* S4660 | selector-pseudo-element-no-unknown */ + color: red; +} + unknown { /* S4670 | selector-type-no-unknown */ color: black; } diff --git a/its/plugin/projects/issues-project/src/file2.less b/its/plugin/projects/issues-project/src/file2.less index 4b76034..7054386 100644 --- a/its/plugin/projects/issues-project/src/file2.less +++ b/its/plugin/projects/issues-project/src/file2.less @@ -1,7 +1,7 @@ @import "a.css"; @import "a.css"; /* S1128 | no-duplicate-at-import-rules | Doesn't raise for LESS */ -.class1 { +a:unknown { /* S4659 | selector-pseudo-class-no-unknown */ background-color: #ffw; /* S4647 | color-no-invalid-hex */ width: 100pixels; /* S4653 | unit-no-unknown */ /* */ /* S4663 | comment-no-empty */ @@ -16,6 +16,10 @@ padding: 20px; /* S4657 | declaration-block-no-shorthand-property-overrides */ } +.class1 { + width: 100px; +} + .class1 { /* S4666 | no-duplicate-selectors */ width: 100px; } @@ -24,6 +28,10 @@ a { color: pink;; /* S1116 | no-extra-semicolons */ } +a::pseudo { /* S4660 | selector-pseudo-element-no-unknown */ + color: red; +} + unknown { /* S4670 | selector-type-no-unknown */ color: black; } diff --git a/its/plugin/projects/issues-project/src/file3.scss b/its/plugin/projects/issues-project/src/file3.scss index 65a0392..ad26232 100644 --- a/its/plugin/projects/issues-project/src/file3.scss +++ b/its/plugin/projects/issues-project/src/file3.scss @@ -1,7 +1,7 @@ @import "a.css"; @import "a.css"; /* S1128 | no-duplicate-at-import-rules */ -.class1 { +a:unknown { /* S4659 | selector-pseudo-class-no-unknown */ background-color: #ffw; /* S4647 | color-no-invalid-hex */ width: 100pixels; /* S4653 | unit-no-unknown */ /* */ /* S4663 | comment-no-empty */ @@ -16,6 +16,10 @@ padding: 20px; /* S4657 | declaration-block-no-shorthand-property-overrides */ } +.class1 { + width: 100px; +} + .class1 { /* S4666 | no-duplicate-selectors */ width: 100px; } @@ -24,6 +28,10 @@ a { color: pink;; /* S1116 | no-extra-semicolons */ } +a::pseudo { /* S4660 | selector-pseudo-element-no-unknown */ + color: red; +} + unknown { /* S4670 | selector-type-no-unknown */ color: black; } diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java index 8eea45f..a66ce70 100644 --- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java +++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java @@ -43,6 +43,7 @@ import org.sonar.css.plugin.rules.NoDuplicateSelectors; import org.sonar.css.plugin.rules.NoEmptySource; import org.sonar.css.plugin.rules.NoExtraSemicolons; import org.sonar.css.plugin.rules.PropertyNoUnknown; +import org.sonar.css.plugin.rules.SelectorPseudoClassNoUnknown; import org.sonar.css.plugin.rules.SelectorTypeNoUnknown; import org.sonar.css.plugin.rules.StringNoNewline; import org.sonar.css.plugin.rules.UnitNoUnknown; @@ -78,6 +79,7 @@ public class CssRules { NoEmptySource.class, NoExtraSemicolons.class, PropertyNoUnknown.class, + SelectorPseudoClassNoUnknown.class, SelectorTypeNoUnknown.class, StringNoNewline.class, UnitNoUnknown.class diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/SelectorPseudoClassNoUnknown.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/SelectorPseudoClassNoUnknown.java new file mode 100644 index 0000000..d647499 --- /dev/null +++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/SelectorPseudoClassNoUnknown.java @@ -0,0 +1,31 @@ +/* + * SonarCSS + * Copyright (C) 2018-2018 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +package org.sonar.css.plugin.rules; + +import org.sonar.check.Rule; + +@Rule(key = "S4659") +public class SelectorPseudoClassNoUnknown implements CssRule { + + @Override + public String stylelintKey() { + return "selector-pseudo-class-no-unknown"; + } +} diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4659.html b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4659.html new file mode 100644 index 0000000..56ee433 --- /dev/null +++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4659.html @@ -0,0 +1,15 @@ +<p>The W3C specifications define the valid pseudo-class selectors. Only the official and browser-specific pseudo-class selectors should be used to get +the expected impact in the final rendering.</p> +<h2>Noncompliant Code Example</h2> +<pre> +a:hoverr { +... +} +</pre> +<h2>Compliant Solution</h2> +<pre> +a:hover { +... +} +</pre> + diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4659.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4659.json new file mode 100644 index 0000000..3d10933 --- /dev/null +++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4659.json @@ -0,0 +1,16 @@ +{ + "title": "Pseudo-class selectors should be valid", + "type": "BUG", + "status": "ready", + "remediation": { + "func": "Constant\/Issue", + "constantCost": "1min" + }, + "tags": [ + + ], + "defaultSeverity": "Major", + "ruleSpecification": "RSPEC-4659", + "sqKey": "S4659", + "scope": "Main" +} diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json index 23dc9cf..04a30dc 100644 --- a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json +++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json @@ -13,6 +13,7 @@ "S4656", "S4657", "S4658", + "S4659", "S4663", "S4666", "S4667", |