Add warning when old NodeJS property is used (#175)

2 files changed, 14 insertions, 13 deletions

diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java
index 82e6306..a21f2a0 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java
@@ -88,7 +88,13 @@ public class CssRuleSensor implements Sensor {
 
   @Override
   public void execute(SensorContext context) {
-    // fixme add log and UI warn when old property is provided
+    if (context.config().hasKey(CssPlugin.FORMER_NODE_EXECUTABLE)) {
+      String msg = "Property '" + CssPlugin.FORMER_NODE_EXECUTABLE + "' is ignored, 'sonar.nodejs.executable' should be used instead";
+      LOG.warn(msg);
+      if (analysisWarnings != null) {
+        analysisWarnings.addUnique(msg);
+      }
+    }
 
     if (cssRules.isEmpty()) {
       LOG.warn("No rules are activated in CSS Quality Profile");
diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
index 90d3ae8..26541bd 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
@@ -25,7 +25,6 @@ import java.util.function.Consumer;
 import org.sonar.api.batch.ScannerSide;
 import org.sonar.api.batch.sensor.SensorContext;
 import org.sonarsource.nodejs.NodeCommand;
-import org.sonarsource.nodejs.NodeCommandException;
 
 @ScannerSide
 public class StylelintCommandProvider implements LinterCommandProvider {
@@ -47,17 +46,13 @@ public class StylelintCommandProvider implements LinterCommandProvider {
       "-f", "json"
     };
 
-    try {
-      return NodeCommand.builder()
-        .outputConsumer(output)
-        .errorConsumer(error)
-        .minNodeVersion(6)
-        .configuration(context.config())
-        .nodeJsArgs(args)
-        .build();
-    } catch (IllegalArgumentException e) {
-      throw new NodeCommandException(e.getMessage(), e);
-    }
+    return NodeCommand.builder()
+      .outputConsumer(output)
+      .errorConsumer(error)
+      .minNodeVersion(6)
+      .configuration(context.config())
+      .nodeJsArgs(args)
+      .build();
   }
 
   @Override