Not fail analysis if Node is not available (#73)

3 files changed, 54 insertions, 1 deletions

diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java
index c669b30..d13038e 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java
@@ -30,6 +30,7 @@ import java.nio.file.Paths;
 import java.util.Collections;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
+import org.apache.commons.io.IOUtils;
 import org.sonar.api.batch.fs.FileSystem;
 import org.sonar.api.batch.fs.InputFile;
 import org.sonar.api.batch.rule.CheckFactory;
@@ -39,6 +40,8 @@ import org.sonar.api.batch.sensor.SensorDescriptor;
 import org.sonar.api.batch.sensor.issue.NewIssue;
 import org.sonar.api.batch.sensor.issue.NewIssueLocation;
 import org.sonar.api.rule.RuleKey;
+import org.sonar.api.utils.log.Logger;
+import org.sonar.api.utils.log.Loggers;
 import org.sonar.css.plugin.CssRules.StylelintConfig;
 import org.sonar.css.plugin.StylelintReport.Issue;
 import org.sonar.css.plugin.StylelintReport.IssuesPerFile;
@@ -46,6 +49,9 @@ import org.sonar.css.plugin.bundle.BundleHandler;
 
 public class CssRuleSensor implements Sensor {
 
+  private static final Logger LOG = Loggers.get(CssRuleSensor.class);
+  private static final int MIN_NODE_VERSION = 6;
+
   private final BundleHandler bundleHandler;
   private final CssRules cssRules;
   private final LinterCommandProvider linterCommandProvider;
@@ -65,6 +71,10 @@ public class CssRuleSensor implements Sensor {
 
   @Override
   public void execute(SensorContext context) {
+    if (!checkCompatibleNodeVersion(context)) {
+      return;
+    }
+
     File deployDestination = context.fileSystem().workDir();
     bundleHandler.deployBundle(deployDestination);
 
@@ -89,6 +99,39 @@ public class CssRuleSensor implements Sensor {
     }
   }
 
+  private boolean checkCompatibleNodeVersion(SensorContext context) {
+    String nodeExecutable = linterCommandProvider.nodeExecutable(context.config());
+    LOG.debug("Checking node version");
+    String messageSuffix = "No CSS files will be analyzed.";
+
+    String version;
+    try {
+      Process process = Runtime.getRuntime().exec(nodeExecutable + " -v");
+      version = IOUtils.toString(process.getInputStream(), StandardCharsets.UTF_8).trim();
+    } catch (Exception e) {
+      LOG.error("Failed to get Node.js version. " + messageSuffix, e);
+      return false;
+    }
+
+    Pattern versionPattern = Pattern.compile("v?(\\d+)\\.\\d+\\.\\d+");
+    Matcher versionMatcher = versionPattern.matcher(version);
+    if (versionMatcher.matches()) {
+      int major = Integer.parseInt(versionMatcher.group(1));
+      if (major < MIN_NODE_VERSION) {
+        String message = String.format("Only Node.js v%s or later is supported, got %s. %s", MIN_NODE_VERSION, version, messageSuffix);
+        LOG.error(message);
+        return false;
+      }
+    } else {
+      String message = String.format("Failed to parse Node.js version, got '%s'. %s", version, messageSuffix);
+      LOG.error(message);
+      return false;
+    }
+
+    LOG.debug(String.format("Using Node.js %s", version));
+    return true;
+  }
+
   private void createConfig(File deployDestination) throws IOException {
     String configPath = linterCommandProvider.configPath(deployDestination);
     StylelintConfig config = cssRules.getConfig();
diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/LinterCommandProvider.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/LinterCommandProvider.java
index 3ca334a..761b88d 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/LinterCommandProvider.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/LinterCommandProvider.java
@@ -21,10 +21,13 @@ package org.sonar.css.plugin;
 
 import java.io.File;
 import org.sonar.api.batch.sensor.SensorContext;
+import org.sonar.api.config.Configuration;
 
 public interface LinterCommandProvider {
 
   String[] commandParts(File deployDestination, SensorContext context);
 
   String configPath(File deployDestination);
+
+  String nodeExecutable(Configuration configuration);
 }
diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
index d97293d..b2f50b5 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
@@ -23,11 +23,13 @@ import java.io.File;
 import java.nio.file.Paths;
 import org.sonar.api.batch.ScannerSide;
 import org.sonar.api.batch.sensor.SensorContext;
+import org.sonar.api.config.Configuration;
 
 @ScannerSide
 public class StylelintCommandProvider implements LinterCommandProvider {
 
   private static final String CONFIG_PATH = "css-bundle/stylelintconfig.json";
+  private static final String NODE_EXECUTABLE = "node";
 
   @Override
   public String[] commandParts(File deployDestination, SensorContext context) {
@@ -38,7 +40,7 @@ public class StylelintCommandProvider implements LinterCommandProvider {
     filesToAnalyze = filesToAnalyze.replace("TOREPLACE", filesGlob);
 
     return new String[]{
-      "node",
+      nodeExecutable(context.config()),
       new File(deployDestination, "css-bundle/node_modules/stylelint/bin/stylelint").getAbsolutePath(),
       filesToAnalyze,
       "--config", new File(deployDestination, CONFIG_PATH).getAbsolutePath(),
@@ -50,4 +52,9 @@ public class StylelintCommandProvider implements LinterCommandProvider {
   public String configPath(File deployDestination) {
     return new File(deployDestination, CONFIG_PATH).getAbsolutePath();
   }
+
+  @Override
+  public String nodeExecutable(Configuration configuration) {
+    return NODE_EXECUTABLE;
+  }
 }