aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorvilchik-elena2019-06-28 15:14:06 +0200
committerElena Vilchik2019-06-28 15:30:46 +0200
commit2340fd85f9d60cf3b49b14394d077da4d9be326b (patch)
treeec40af446e369997066e9d52ebf3b1debd3bdd01
parentebac7cd722f1f455344f46bd3581a3ba4cfd9003 (diff)
downloadsonar-css-2340fd85f9d60cf3b49b14394d077da4d9be326b.tar.bz2
Exclude JS/TS from analysis
-rw-r--r--its/plugin/projects/issues-project/src/file7.jsx1
-rw-r--r--its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java2
-rw-r--r--sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java2
-rw-r--r--sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java3
4 files changed, 5 insertions, 3 deletions
diff --git a/its/plugin/projects/issues-project/src/file7.jsx b/its/plugin/projects/issues-project/src/file7.jsx
new file mode 100644
index 0000000..887ce8f
--- /dev/null
+++ b/its/plugin/projects/issues-project/src/file7.jsx
@@ -0,0 +1 @@
+// file is not analyzed
diff --git a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
index 09f0f32..8da93a3 100644
--- a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
+++ b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
@@ -67,7 +67,7 @@ public class IssuesTest {
assertThat(issuesList).extracting("rule").hasSize(
CssRules.getRuleClasses().size() * 3 /* issues are raised against .css, .less and .scss */
- + 2 /* for html and vue files */
+ + 1 /* for html file */
+ 1 /* issue S4654 is raised for comment */
+ 1 /* issue S4662 is raised for cssModules.css */
- 2 /* issue S4668 not raised on .less nor .scss */);
diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
index 1f6d6b2..c43af5c 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/StylelintCommandProvider.java
@@ -33,7 +33,7 @@ import org.sonarsource.nodejs.NodeCommand;
public class StylelintCommandProvider implements LinterCommandProvider {
private static final String CONFIG_PATH = "css-bundle/stylelintconfig.json";
- private static final List<String> LANGUAGES_TO_ANALYZE = Arrays.asList("css", "html", "php", "javascript", "typescript");
+ private static final List<String> LANGUAGES_TO_ANALYZE = Arrays.asList("css", "html", "php");
@Override
public NodeCommand nodeCommand(File deployDestination, SensorContext context, Consumer<String> output, Consumer<String> error) {
diff --git a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java
index da0eb93..f2d2fed 100644
--- a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java
+++ b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java
@@ -46,13 +46,14 @@ public class StylelintCommandProviderTest {
SensorContextTester context = SensorContextTester.create(baseDir);
context.settings().setProperty(CssPlugin.FILE_SUFFIXES_KEY, ".foo,.bar")
.setProperty("sonar.javascript.file.suffixes", ".js")
+ .setProperty("sonar.php.file.suffixes", ".php")
.setProperty("sonar.java.file.suffixes", ".java");
Consumer<String> noop = a -> {};
NodeCommand nodeCommand = stylelintCommandProvider.nodeCommand(deployDestination, context, noop, noop);
assertThat(nodeCommand.toString()).endsWith(
String.join(" ",
new File(deployDestination, "css-bundle/node_modules/stylelint/bin/stylelint").getAbsolutePath(),
- baseDir.getAbsolutePath() + File.separator + "**" + File.separator + "*{.foo,.bar,.js}",
+ baseDir.getAbsolutePath() + File.separator + "**" + File.separator + "*{.foo,.bar,.php}",
"--config",
new File(deployDestination, "css-bundle/stylelintconfig.json").getAbsolutePath(),
"-f",