Rule S1128: Useless imports should be removed (#64)

9 files changed, 77 insertions, 4 deletions

diff --git a/its/plugin/projects/issues-project/src/file1.css b/its/plugin/projects/issues-project/src/file1.css
index afd6213..34aa80c 100644
--- a/its/plugin/projects/issues-project/src/file1.css
+++ b/its/plugin/projects/issues-project/src/file1.css
@@ -1,3 +1,6 @@
+@import "a.css";
+@import "a.css";          /* S1128 | no-duplicate-at-import-rules */
+
 .class1 {
   background-color: #ffw; /* S4647 | color-no-invalid-hex */
   width: 100pixels;       /* S4653 | unit-no-unknown */
@@ -15,4 +18,4 @@
   to {
     margin-top: 100px !important; /* S4655 | keyframe-declaration-no-important */
   }
-}
+}
\ No newline at end of file
diff --git a/its/plugin/projects/issues-project/src/file2.less b/its/plugin/projects/issues-project/src/file2.less
index afd6213..35a63f4 100644
--- a/its/plugin/projects/issues-project/src/file2.less
+++ b/its/plugin/projects/issues-project/src/file2.less
@@ -1,3 +1,6 @@
+@import 'a.css';
+@import 'a.css';          /* S1128 | no-duplicate-at-import-rules | Doesn't raise for LESS */
+
 .class1 {
   background-color: #ffw; /* S4647 | color-no-invalid-hex */
   width: 100pixels;       /* S4653 | unit-no-unknown */
@@ -15,4 +18,4 @@
   to {
     margin-top: 100px !important; /* S4655 | keyframe-declaration-no-important */
   }
-}
+}
\ No newline at end of file
diff --git a/its/plugin/projects/issues-project/src/file3.scss b/its/plugin/projects/issues-project/src/file3.scss
index afd6213..22438ed 100644
--- a/its/plugin/projects/issues-project/src/file3.scss
+++ b/its/plugin/projects/issues-project/src/file3.scss
@@ -1,3 +1,6 @@
+@import 'a.css';
+@import 'a.css';          /* S1128 | no-duplicate-at-import-rules */
+
 .class1 {
   background-color: #ffw; /* S4647 | color-no-invalid-hex */
   width: 100pixels;       /* S4653 | unit-no-unknown */
@@ -15,4 +18,4 @@
   to {
     margin-top: 100px !important; /* S4655 | keyframe-declaration-no-important */
   }
-}
+}
\ No newline at end of file
diff --git a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
index d70597d..adfbe11 100644
--- a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
+++ b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
@@ -50,7 +50,9 @@ public class IssuesTest {
     request.setComponentKeys(Collections.singletonList(PROJECT_KEY));
     List<Issue> issuesList = newWsClient().issues().search(request).getIssuesList();
 
-    assertThat(issuesList).extracting("rule").hasSize(CssRules.getRuleClasses().size() * 3);
+    assertThat(issuesList).extracting("rule").hasSize(
+      CssRules.getRuleClasses().size() * 3
+      - 1 /* issue S1128 not raised on .less */);
   }
 
 }
diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java
index 0db8f90..91f1898 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java
@@ -34,6 +34,7 @@ import org.sonar.css.plugin.rules.CommentNoEmpty;
 import org.sonar.css.plugin.rules.CssRule;
 import org.sonar.css.plugin.rules.DeclarationBlockNoDuplicateProperties;
 import org.sonar.css.plugin.rules.KeyframeDeclarationNoImportant;
+import org.sonar.css.plugin.rules.NoDuplicateAtImportRules;
 import org.sonar.css.plugin.rules.NoEmptySource;
 import org.sonar.css.plugin.rules.StringNoNewline;
 import org.sonar.css.plugin.rules.UnitNoUnknown;
@@ -60,6 +61,7 @@ public class CssRules {
       CommentNoEmpty.class,
       DeclarationBlockNoDuplicateProperties.class,
       KeyframeDeclarationNoImportant.class,
+      NoDuplicateAtImportRules.class,
       NoEmptySource.class,
       StringNoNewline.class,
       UnitNoUnknown.class
diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/NoDuplicateAtImportRules.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/NoDuplicateAtImportRules.java
new file mode 100644
index 0000000..dffa28f
--- /dev/null
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/NoDuplicateAtImportRules.java
@@ -0,0 +1,31 @@
+/*
+ * SonarCSS
+ * Copyright (C) 2018-2018 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.css.plugin.rules;
+
+import org.sonar.check.Rule;
+
+@Rule(key = "S1128")
+public class NoDuplicateAtImportRules implements CssRule {
+
+  @Override
+  public String stylelintKey() {
+    return "no-duplicate-at-import-rules";
+  }
+}
diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S1128.html b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S1128.html
new file mode 100644
index 0000000..8dde5aa
--- /dev/null
+++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S1128.html
@@ -0,0 +1,12 @@
+<p>The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.</p>
+<p>Unused and useless imports should not occur if that is the case.</p>
+<p>Leaving them in reduces the code's readability, since their presence can be confusing.</p>
+<h2>Noncompliant Code Example</h2>
+<pre>
+@import 'a.css';
+@import 'a.css'; // Noncompliant
+
+@import url("a.css");
+@import url("a.css"); // Noncompliant
+</pre>
+
diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S1128.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S1128.json
new file mode 100644
index 0000000..1f7d8bc
--- /dev/null
+++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S1128.json
@@ -0,0 +1,16 @@
+{
+  "title": "Useless imports should be removed",
+  "type": "CODE_SMELL",
+  "status": "ready",
+  "remediation": {
+    "func": "Constant\/Issue",
+    "constantCost": "2min"
+  },
+  "tags": [
+    "unused"
+  ],
+  "defaultSeverity": "Minor",
+  "ruleSpecification": "RSPEC-1128",
+  "sqKey": "S1128",
+  "scope": "All"
+}
diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json
index 14b9668..4455af6 100644
--- a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json
+++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json
@@ -1,6 +1,7 @@
 {
   "name": "Sonar way",
   "ruleKeys": [
+    "S1128",
     "S4647",
     "S4652",
     "S4653",