diff options
| author | Elena Vilchik | 2018-06-28 14:00:29 +0200 |
|---|---|---|
| committer | Amaury Levé | 2018-06-28 14:00:29 +0200 |
| commit | 10718b0bdffc14769e37ee5b0faf804d8858bff9 (patch) | |
| tree | 2418d96fc27357c851e849878ec178f74982f1b8 | |
| parent | 1e0fc32ad10d840b4d38b2eb61926a6dc7fbfcaf (diff) | |
| download | sonar-css-10718b0bdffc14769e37ee5b0faf804d8858bff9.tar.bz2 | |
Add 'at-root', 'error' and 'warn' to default of S4662 (#99)
3 files changed, 7 insertions, 6 deletions
diff --git a/its/plugin/projects/issues-project/src/file3.scss b/its/plugin/projects/issues-project/src/file3.scss index 5ceb19c..6f19ae1 100644 --- a/its/plugin/projects/issues-project/src/file3.scss +++ b/its/plugin/projects/issues-project/src/file3.scss @@ -66,9 +66,10 @@ unknown { /* S4670 | selecto @mixin adjust-location($x, $y) { @if unitless($x) { color: blue; - @debug "" - @warn "" - @error "" + @debug ""; + @warn ""; + @error ""; + @at-root [dir="ltr"] { color: blue; } } @else { color: black; } @@ -89,4 +90,4 @@ $i: 6; @while $i > 0 { .item-#{$i} { width: 2em * $i; } $i: $i - 2; -}
\ No newline at end of file +} diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/AtRuleNoUnknown.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/AtRuleNoUnknown.java index 36fb364..603361d 100644 --- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/AtRuleNoUnknown.java +++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/AtRuleNoUnknown.java @@ -27,7 +27,7 @@ import org.sonar.check.RuleProperty; @Rule(key = "S4662") public class AtRuleNoUnknown implements CssRule { - private static final String DEFAULT_IGNORED_AT_RULES = "content,debug,each,else,for,function,if,include,mixin,return,while"; + private static final String DEFAULT_IGNORED_AT_RULES = "at-root,content,debug,each,else,error,for,function,if,include,mixin,return,warn,while"; @RuleProperty( key = "ignoreAtRules", diff --git a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/rules/CssRuleTest.java b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/rules/CssRuleTest.java index 670ffbf..ab1ec98 100644 --- a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/rules/CssRuleTest.java +++ b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/rules/CssRuleTest.java @@ -52,7 +52,7 @@ public class CssRuleTest { @Test public void at_rule_unknown_default() { String optionsAsJson = new Gson().toJson(new AtRuleNoUnknown().stylelintOptions()); - assertThat(optionsAsJson).isEqualTo("[true,{\"ignoreAtRules\":[\"content\",\"debug\",\"each\",\"else\",\"for\",\"function\",\"if\",\"include\",\"mixin\",\"return\",\"while\"]}]"); + assertThat(optionsAsJson).isEqualTo("[true,{\"ignoreAtRules\":[\"at-root\",\"content\",\"debug\",\"each\",\"else\",\"error\",\"for\",\"function\",\"if\",\"include\",\"mixin\",\"return\",\"warn\",\"while\"]}]"); } @Test |