From fa69f8e3b60abb2204654a85f65b96d328190875 Mon Sep 17 00:00:00 2001
From: Jack Nagel
Date: Thu, 27 Jun 2013 21:11:16 -0500
Subject: Add an exception for imagemagick in build-time dep audit

---
 Library/Homebrew/cmd/audit.rb | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

(limited to 'Library')

diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 79df38599..f19a461a7 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -145,10 +145,14 @@ class FormulaAuditor
 
       case dep.name
       when *BUILD_TIME_DEPS
-        # Build deps should be tagged
-        problem <<-EOS.undent unless dep.tags.any? || f.name =~ /automake/ && dep.name == 'autoconf'
-        #{dep} dependency should be "depends_on '#{dep}' => :build"
-        EOS
+        # TODO: this should really be only dep.build? but maybe some formula
+        # depends on the current behavior to be audit-clean?
+        next if dep.tags.any?
+        next if f.name =~ /automake/ && dep.name == 'autoconf'
+        # This is actually a libltdl dep that gets converted to a non-build time
+        # libtool dep, but I don't of a good way to encode this in the dep object
+        next if f.name == 'imagemagick' && dep.name == 'libtool'
+        problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"}
       when "git", "ruby", "emacs", "mercurial"
         problem <<-EOS.undent
           Don't use #{dep} as a dependency. We allow non-Homebrew
-- 
cgit v1.2.3