From cf44bb010b24b5f85a9554d2215505d6775a5520 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Sat, 15 Feb 2014 17:47:24 -0500 Subject: Formula#system: simplify xcodebuild special case --- Library/Homebrew/formula.rb | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'Library') diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index b1fe8e9ec..3792e0a7b 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -552,6 +552,8 @@ class Formula # Pretty titles the command and buffers stdout/stderr # Throws if there's an error def system cmd, *args + removed_ENV_variables = {} + # remove "boring" arguments so that the important ones are more likely to # be shown considering that we trim long ohai lines to the terminal width pretty_args = args.dup @@ -561,9 +563,8 @@ class Formula end ohai "#{cmd} #{pretty_args*' '}".strip - removed_ENV_variables = case if args.empty? then cmd.split(' ').first else cmd end - when "xcodebuild" - ENV.remove_cc_etc + if cmd.to_s.start_with? "xcodebuild" + removed_ENV_variables.update(ENV.remove_cc_etc) end @exec_count ||= 0 @@ -606,7 +607,7 @@ class Formula end ensure rd.close if rd and not rd.closed? - ENV.update(removed_ENV_variables) if removed_ENV_variables + ENV.update(removed_ENV_variables) end private -- cgit v1.2.3