| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2014-07-06 | Let File.expand_path also do the join | Jack Nagel | |
| 2014-07-06 | Check File.file? first to avoid second stat() | Jack Nagel | |
| 2014-07-06 | Use Formula tap methods | Jack Nagel | |
| 2014-07-06 | Make tap_ref match similar code in update | Jack Nagel | |
| 2014-07-06 | Escape paths in regexps | Jack Nagel | |
| 2014-07-06 | Just use each since we're returning from inside the block | Jack Nagel | |
| 2014-07-06 | Expand ~ in PATH entries | Jack Nagel | |
| 2014-07-05 | Remove a RUBY_VERSION check, add a FIXME comment | Jack Nagel | |
| 2014-07-05 | Use popen wrapper | Jack Nagel | |
| Closes #30678. | |||
| 2014-07-05 | Add popen wrapper that does not invoke the shell | Jack Nagel | |
| 2014-07-04 | Use a regular conditional instead of `next unless ...` | Jack Nagel | |
| 2014-07-04 | Simpler "use the correct symlink" checks | Jack Nagel | |
| When determining whether to remove a symlink during unlinking, we check three things: (a) Is the destination a symlink? (b) Does the destination exist? (c) Does the destination resolve to the source path? However, since we know that the source path exists, (b) is guaranteed if (a) and (c) are true. Thus checking (b) is unnecessary. Similarly, when creating a new symlink during linking, we first check to see if the link already exists by checking the same three criteria. Again, checking (b) is unnecessary here. See also the expanded test coverage in b52b579b. Addendum: although we know that the source path exists during unlinking, it doesn't matter. If the source path does not exist, then we still know we have a broken symlink pointing into the keg we are unlinking, and removing that symlink is still safe. | |||
| 2014-07-03 | Add more tests documenting linking behavior | Jack Nagel | |
| 2014-07-03 | Avoid chdir just to make a symlink | Jack Nagel | |
| 2014-07-03 | Move repeated pathname into setup | Jack Nagel | |
| 2014-07-03 | Don't assign @keg twice in setup | Jack Nagel | |
| 2014-07-03 | No need to silence output from Keg#link anymore | Jack Nagel | |
| 2014-07-03 | Option does not need to be Comparable | Jack Nagel | |
| 2014-07-03 | Add assert_eql to provide better failure messages for eql? tests | Jack Nagel | |
| 2014-07-03 | Fix PkgVersion#<=> | Jack Nagel | |
| 2014-07-03 | libspotify: migrate to homebrew/binary. | Mike McQuaid | |
| Closes #30632. | |||
| 2014-07-03 | hllib: migrate to homebrew/boneyard. | Mike McQuaid | |
| Closes #30631. | |||
| 2014-07-03 | bottle: use revision to find bottle block too. | Mike McQuaid | |
| 2014-07-03 | stop Xcode tools from overriding deps when CLT is not installed | Camillo Lugaresi | |
| Closes #30641. Signed-off-by: Jack Nagel <jacknagel@gmail.com> | |||
| 2014-07-03 | Fix Formula#<=> on trunk Ruby | Jack Nagel | |
| Arguably this method shouldn't exist and sort_by(&:name) used instead. | |||
| 2014-07-03 | Replace ComparableSet with a Requirements collection | Jack Nagel | |
| 2014-07-03 | Don't invoke mdfind in the tests | Jack Nagel | |
| 2014-07-03 | Add inspect to mock updater so test failures are readable | Jack Nagel | |
| 2014-07-02 | Accept -s as shorthand for --build-from-source | Jack Nagel | |
| This is experimental and will be reverted if it causes problems. Closes #30392. | |||
| 2014-07-02 | Move constants so we don't have to load all of ENV to get them | Jack Nagel | |
| 2014-07-02 | Move require into method to avoid circular require | Jack Nagel | |
| There is a nasty circular dependency here: formula.rb requirement.rb extend/ENV.rb extend/ENV/shared.rb formula.rb Probably the information that the build environment needs from formula should be passed in at runtime, but that seems hard and I really just want to be able to run the tests with warnings turned on. :/ | |||
| 2014-07-02 | Add min_version to X11Dependency inspect string | Jack Nagel | |
| 2014-07-02 | Add regression test for decf7acced44bb156ba18677f55609b19ff6ca5a | Jack Nagel | |
| 2014-07-02 | Don't expose the dependency cache data structure | Jack Nagel | |
| 2014-07-02 | Pass relative paths into link exceptions | Jack Nagel | |
| 2014-07-02 | Add a test that exercises the code in X11Dependency#satisfied? | Jack Nagel | |
| 2014-07-01 | Fix typo | Jack Nagel | |
| 2014-07-01 | Use predicate methods instead of inspecting the tags array | Jack Nagel | |
| 2014-07-01 | Replace find_all + each with grep | Jack Nagel | |
| 2014-07-01 | X11Dependency objects: fix hash equality | Jack Nagel | |
| 2014-07-01 | X11Dependency: use Version objects | Jack Nagel | |
| 2014-07-01 | Use to_a definition from Enumerable | Jack Nagel | |
| 2014-07-01 | Use sort_by in missing deps doctor check | Jack Nagel | |
| 2014-07-01 | Better Formula#inspect string | Jack Nagel | |
| 2014-07-01 | Always use class.name to build inspect strings | Jack Nagel | |
| 2014-07-01 | Use sort_by in PrettyListing | Jack Nagel | |
| 2014-07-01 | Flesh out linking tests | Jack Nagel | |
| 2014-06-30 | Remove default argument from make_relative_symlink | Jack Nagel | |
| All callers of this method now pass a mode object. | |||
| 2014-06-30 | Pass the mode through the optlink method | Jack Nagel | |
| 2014-06-30 | Simplify optlink method | Jack Nagel | |
| delete/unlink on a directory is the same operation as rmdir. | |||
