From 7bb5fd270da98d8957efb4bf0e4bd4679ddbcf5f Mon Sep 17 00:00:00 2001
From: Greg Kempe
Date: Wed, 4 Feb 2015 16:03:03 +0200
Subject: FIX: Don't default to list in method args

Fixes @list_route and @detail_route so that they don't initialize their `methods` parameter as a list. In some cases the list gets cleared, and the result is that default parameter is now empty, and may get reused unexpectedly.---
 rest_framework/decorators.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

(limited to 'rest_framework')

diff --git a/rest_framework/decorators.py b/rest_framework/decorators.py
index 325435b3..a68227c1 100644
--- a/rest_framework/decorators.py
+++ b/rest_framework/decorators.py
@@ -109,10 +109,12 @@ def permission_classes(permission_classes):
     return decorator
 
 
-def detail_route(methods=['get'], **kwargs):
+def detail_route(methods=None, **kwargs):
     """
     Used to mark a method on a ViewSet that should be routed for detail requests.
     """
+    if methods is None:
+        methods = ['get']
     def decorator(func):
         func.bind_to_methods = methods
         func.detail = True
@@ -121,10 +123,12 @@ def detail_route(methods=['get'], **kwargs):
     return decorator
 
 
-def list_route(methods=['get'], **kwargs):
+def list_route(methods=None, **kwargs):
     """
     Used to mark a method on a ViewSet that should be routed for list requests.
     """
+    if methods is None:
+        methods = ['get']
     def decorator(func):
         func.bind_to_methods = methods
         func.detail = False
-- 
cgit v1.2.3