From 138f0cacdb0f093a4dc65ef98bf48ddbc27e18b2 Mon Sep 17 00:00:00 2001
From: Tom Christie
Date: Tue, 28 May 2013 11:57:11 +0100
Subject: Raise 404 on incorrect lookup type in URL, not 500. Closes #890.

---
 rest_framework/tests/generics.py | 10 ++++++++++
 1 file changed, 10 insertions(+)

(limited to 'rest_framework/tests')

diff --git a/rest_framework/tests/generics.py b/rest_framework/tests/generics.py
index f091d0db..37734195 100644
--- a/rest_framework/tests/generics.py
+++ b/rest_framework/tests/generics.py
@@ -279,6 +279,16 @@ class TestInstanceView(TestCase):
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         self.assertEqual(response.data, expected)
 
+    def test_get_instance_view_incorrect_arg(self):
+        """
+        GET requests with an incorrect pk type, should raise 404, not 500.
+        Regression test for #890.
+        """
+        request = factory.get('/a')
+        with self.assertNumQueries(0):
+            response = self.view(request, pk='a').render()
+        self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
+
     def test_put_cannot_set_id(self):
         """
         PUT requests to create a new object should not be able to set the id.
-- 
cgit v1.2.3