From dc52ceaaa273f3d3b5248c2ebf655a747fa516db Mon Sep 17 00:00:00 2001 From: Tom Christie Date: Tue, 9 Oct 2012 10:25:01 +0100 Subject: Remove Field handling relations/relationship managers - use RelatedField/ManyRelatedField instead --- rest_framework/fields.py | 4 ---- rest_framework/tests/genericrelations.py | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/rest_framework/fields.py b/rest_framework/fields.py index 33f25a00..bb9a523d 100644 --- a/rest_framework/fields.py +++ b/rest_framework/fields.py @@ -83,10 +83,6 @@ class Field(object): if is_protected_type(value): return value - - all_callable = getattr(value, 'all', None) - if is_simple_callable(all_callable): - return [self.to_native(item) for item in value.all()] elif hasattr(value, '__iter__') and not isinstance(value, (dict, basestring)): return [self.to_native(item) for item in value] return smart_unicode(value) diff --git a/rest_framework/tests/genericrelations.py b/rest_framework/tests/genericrelations.py index d88a6c06..1d7e33bc 100644 --- a/rest_framework/tests/genericrelations.py +++ b/rest_framework/tests/genericrelations.py @@ -19,7 +19,7 @@ class TestGenericRelations(TestCase): def test_reverse_generic_relation(self): class BookmarkSerializer(serializers.ModelSerializer): - tags = serializers.Field(source='tags') + tags = serializers.ManyRelatedField(source='tags') class Meta: model = Bookmark -- cgit v1.2.3