diff options
| author | Tom Christie | 2013-10-10 17:34:15 +0100 | 
|---|---|---|
| committer | Tom Christie | 2013-10-10 17:34:15 +0100 | 
| commit | f18158358d99f94e2475821b1f3477dde0731bd7 (patch) | |
| tree | 84ed0ffb3cbed0b08d7281e11ec99336df2b7b75 /rest_framework | |
| parent | c3e370b168de03b963b6afcffce6bd52e1d4ab7c (diff) | |
| parent | 0bbc775b950d4ff7d3caef4fda719642ad792075 (diff) | |
| download | django-rest-framework-f18158358d99f94e2475821b1f3477dde0731bd7.tar.bz2 | |
Merge branch 'master' of https://github.com/tomchristie/django-rest-framework
Diffstat (limited to 'rest_framework')
| -rw-r--r-- | rest_framework/generics.py | 4 | ||||
| -rw-r--r-- | rest_framework/serializers.py | 3 | ||||
| -rw-r--r-- | rest_framework/tests/test_serializer.py | 35 | 
3 files changed, 40 insertions, 2 deletions
diff --git a/rest_framework/generics.py b/rest_framework/generics.py index 7d1bf794..4f134bce 100644 --- a/rest_framework/generics.py +++ b/rest_framework/generics.py @@ -25,13 +25,13 @@ def strict_positive_int(integer_string, cutoff=None):          ret = min(ret, cutoff)      return ret -def get_object_or_404(queryset, **filter_kwargs): +def get_object_or_404(queryset, *filter_args, **filter_kwargs):      """      Same as Django's standard shortcut, but make sure to raise 404      if the filter_kwargs don't match the required types.      """      try: -        return _get_object_or_404(queryset, **filter_kwargs) +        return _get_object_or_404(queryset, *filter_args, **filter_kwargs)      except (TypeError, ValueError):          raise Http404 diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index 8e945688..33db82ee 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -315,6 +315,9 @@ class BaseSerializer(WritableField):              field.initialize(parent=self, field_name=field_name)              key = self.get_field_key(field_name)              value = field.field_to_native(obj, field_name) +            method = getattr(self, 'transform_%s' % field_name, None) +            if callable(method): +                value = method(obj, value)              ret[key] = value              ret.fields[key] = self.augment_field(field, field_name, key, value) diff --git a/rest_framework/tests/test_serializer.py b/rest_framework/tests/test_serializer.py index d4e5a93f..29c08fbc 100644 --- a/rest_framework/tests/test_serializer.py +++ b/rest_framework/tests/test_serializer.py @@ -1658,3 +1658,38 @@ class SerializerSupportsManyRelationships(TestCase):          serializer = SimpleSlugSourceModelSerializer(data={'text': 'foo', 'targets': [1, 2]})          self.assertTrue(serializer.is_valid())          self.assertEqual(serializer.data, {'text': 'foo', 'targets': [1, 2]}) + + +class TransformMethodsSerializer(serializers.Serializer): +    a = serializers.CharField() +    b_renamed = serializers.CharField(source='b') + +    def transform_a(self, obj, value): +        return value.lower() + +    def transform_b_renamed(self, obj, value): +        if value is not None: +            return 'and ' + value + + +class TestSerializerTransformMethods(TestCase): +    def setUp(self): +        self.s = TransformMethodsSerializer() + +    def test_transform_methods(self): +        self.assertEqual( +            self.s.to_native({'a': 'GREEN EGGS', 'b': 'HAM'}), +            { +                'a': 'green eggs', +                'b_renamed': 'and HAM', +            } +        ) + +    def test_missing_fields(self): +        self.assertEqual( +            self.s.to_native({'a': 'GREEN EGGS'}), +            { +                'a': 'green eggs', +                'b_renamed': None, +            } +        )  | 
