aboutsummaryrefslogtreecommitdiffstats
path: root/rest_framework
diff options
context:
space:
mode:
authorYin Jifeng2013-12-23 11:02:07 +0800
committerYin Jifeng2013-12-23 14:33:53 +0800
commit80e9f0d64b0ace50d413eaccbf28a3b4ded75ed3 (patch)
tree42c8872ae8a116b5720115aea3920b4923bb0992 /rest_framework
parent9b7341e4840635d9c3bd419678164cdc3cbb7d20 (diff)
downloaddjango-rest-framework-80e9f0d64b0ace50d413eaccbf28a3b4ded75ed3.tar.bz2
fix url double quoted in Django 1.6
get_full_path returns unicode, so we use build_absolute_uri which returns iri_to_uri'ed one
Diffstat (limited to 'rest_framework')
-rw-r--r--rest_framework/templatetags/rest_framework.py2
-rw-r--r--rest_framework/tests/test_templatetags.py18
2 files changed, 19 insertions, 1 deletions
diff --git a/rest_framework/templatetags/rest_framework.py b/rest_framework/templatetags/rest_framework.py
index e9c1cdd5..5c267ab3 100644
--- a/rest_framework/templatetags/rest_framework.py
+++ b/rest_framework/templatetags/rest_framework.py
@@ -144,7 +144,7 @@ def add_query_param(request, key, val):
"""
Add a query parameter to the current request url, and return the new url.
"""
- return replace_query_param(request.get_full_path(), key, val)
+ return replace_query_param(request.build_absolute_uri(), key, val)
@register.filter
diff --git a/rest_framework/tests/test_templatetags.py b/rest_framework/tests/test_templatetags.py
new file mode 100644
index 00000000..cbac768a
--- /dev/null
+++ b/rest_framework/tests/test_templatetags.py
@@ -0,0 +1,18 @@
+# encoding: utf-8
+from __future__ import unicode_literals
+from django.test import TestCase
+from rest_framework.test import APIRequestFactory
+from rest_framework.templatetags.rest_framework import add_query_param
+
+factory = APIRequestFactory()
+
+
+class TemplateTagTests(TestCase):
+
+ def test_add_query_param_with_non_latin_charactor(self):
+ request = factory.get("/?q=查询")
+ json_url = add_query_param(request, "format", "json")
+ self.assertIn(json_url, [
+ "http://testserver/?format=json&q=%E6%9F%A5%E8%AF%A2",
+ "http://testserver/?q=%E6%9F%A5%E8%AF%A2&format=json",
+ ])