diff options
| author | Tom Christie | 2014-12-15 09:13:27 +0000 | 
|---|---|---|
| committer | Tom Christie | 2014-12-15 09:13:27 +0000 | 
| commit | d22c0007b3ec9e4d7105afc4f7a2cb9a89c0f97b (patch) | |
| tree | 92d03caaba239a638395a5a76a8317193688382f /rest_framework | |
| parent | 5e7c9687c7e11b6adfe2fc534eb0504e67ca9fc9 (diff) | |
| parent | 4ebd8770b94ecb8fe8fb41fe8daa4309b33b9952 (diff) | |
| download | django-rest-framework-d22c0007b3ec9e4d7105afc4f7a2cb9a89c0f97b.tar.bz2 | |
Merge branch 'exception-handler-context' of git://github.com/jpadilla/django-rest-framework into jpadilla-exception-handler-context
Diffstat (limited to 'rest_framework')
| -rw-r--r-- | rest_framework/views.py | 29 | 
1 files changed, 27 insertions, 2 deletions
| diff --git a/rest_framework/views.py b/rest_framework/views.py index bc870417..b39724c2 100644 --- a/rest_framework/views.py +++ b/rest_framework/views.py @@ -2,6 +2,8 @@  Provides an APIView class that is the base of all views in REST framework.  """  from __future__ import unicode_literals +import inspect +import warnings  from django.core.exceptions import PermissionDenied  from django.http import Http404 @@ -46,7 +48,7 @@ def get_view_description(view_cls, html=False):      return description -def exception_handler(exc): +def exception_handler(exc, context):      """      Returns the response that should be used for any given exception. @@ -184,6 +186,18 @@ class APIView(View):              'request': getattr(self, 'request', None)          } +    def get_exception_handler_context(self): +        """ +        Returns a dict that is passed through to EXCEPTION_HANDLER, +        as the `context` argument. +        """ +        return { +            'view': self, +            'args': getattr(self, 'args', ()), +            'kwargs': getattr(self, 'kwargs', {}), +            'request': getattr(self, 'request', None) +        } +      def get_view_name(self):          """          Return the view name, as used in OPTIONS responses and in the @@ -369,7 +383,18 @@ class APIView(View):              else:                  exc.status_code = status.HTTP_403_FORBIDDEN -        response = self.settings.EXCEPTION_HANDLER(exc) +        exception_handler = self.settings.EXCEPTION_HANDLER + +        if len(inspect.getargspec(exception_handler).args) == 1: +            warnings.warn( +                'The `exception_handler(exc)` call signature is deprecated. ' +                'Use `exception_handler(exc, context) instead.', +                PendingDeprecationWarning +            ) +            response = exception_handler(exc) +        else: +            context = self.get_exception_handler_context() +            response = exception_handler(exc, context)          if response is None:              raise | 
