aboutsummaryrefslogtreecommitdiffstats
path: root/rest_framework
diff options
context:
space:
mode:
authorTom Christie2012-10-28 20:21:45 +0000
committerTom Christie2012-10-28 20:21:45 +0000
commit6e4ab09aae8295e4ef722d59894bc2934435ae46 (patch)
treeb4005e865aa2d2d125c2d9be2ea07bffd1e9df87 /rest_framework
parent795f6116639ad5a9290db46b7f7fcbe4b0f86af2 (diff)
downloaddjango-rest-framework-6e4ab09aae8295e4ef722d59894bc2934435ae46.tar.bz2
readonly -> read_only
Diffstat (limited to 'rest_framework')
-rw-r--r--rest_framework/fields.py14
-rw-r--r--rest_framework/renderers.py2
-rw-r--r--rest_framework/tests/serializer.py6
-rw-r--r--rest_framework/tests/validators.py10
4 files changed, 16 insertions, 16 deletions
diff --git a/rest_framework/fields.py b/rest_framework/fields.py
index 85e6ee31..c0e527e5 100644
--- a/rest_framework/fields.py
+++ b/rest_framework/fields.py
@@ -111,17 +111,17 @@ class WritableField(Field):
widget = widgets.TextInput
default = None
- def __init__(self, source=None, readonly=False, required=None,
+ def __init__(self, source=None, read_only=False, required=None,
validators=[], error_messages=None, widget=None,
default=None):
super(WritableField, self).__init__(source=source)
- self.readonly = readonly
+ self.read_only = read_only
if required is None:
- self.required = not(readonly)
+ self.required = not(read_only)
else:
- assert not readonly, "Cannot set required=True and readonly=True"
+ assert not read_only, "Cannot set required=True and read_only=True"
self.required = required
messages = {}
@@ -166,7 +166,7 @@ class WritableField(Field):
Given a dictionary and a field name, updates the dictionary `into`,
with the field and it's deserialized value.
"""
- if self.readonly:
+ if self.read_only:
return
try:
@@ -240,7 +240,7 @@ class RelatedField(WritableField):
return self.to_native(value)
def field_from_native(self, data, field_name, into):
- if self.readonly:
+ if self.read_only:
return
value = data.get(field_name)
@@ -256,7 +256,7 @@ class ManyRelatedMixin(object):
return [self.to_native(item) for item in value.all()]
def field_from_native(self, data, field_name, into):
- if self.readonly:
+ if self.read_only:
return
try:
diff --git a/rest_framework/renderers.py b/rest_framework/renderers.py
index cfe4df6d..938e8664 100644
--- a/rest_framework/renderers.py
+++ b/rest_framework/renderers.py
@@ -288,7 +288,7 @@ class BrowsableAPIRenderer(BaseRenderer):
fields = {}
for k, v in serializer.get_fields(True).items():
- if getattr(v, 'readonly', True):
+ if getattr(v, 'read_only', True):
continue
kwargs = {}
diff --git a/rest_framework/tests/serializer.py b/rest_framework/tests/serializer.py
index 67c97f0f..5df3bd7e 100644
--- a/rest_framework/tests/serializer.py
+++ b/rest_framework/tests/serializer.py
@@ -301,7 +301,7 @@ class ManyToManyTests(TestCase):
class ReadOnlyManyToManyTests(TestCase):
def setUp(self):
class ReadOnlyManyToManySerializer(serializers.ModelSerializer):
- rel = serializers.ManyRelatedField(readonly=True)
+ rel = serializers.ManyRelatedField(read_only=True)
class Meta:
model = ReadOnlyManyToManyModel
@@ -323,7 +323,7 @@ class ReadOnlyManyToManyTests(TestCase):
def test_update(self):
"""
Attempt to update an instance of a model with a ManyToMany
- relationship. Not updated due to readonly=True
+ relationship. Not updated due to read_only=True
"""
new_anchor = Anchor()
new_anchor.save()
@@ -339,7 +339,7 @@ class ReadOnlyManyToManyTests(TestCase):
def test_update_without_relationship(self):
"""
Attempt to update an instance of a model where many to ManyToMany
- relationship is not supplied. Not updated due to readonly=True
+ relationship is not supplied. Not updated due to read_only=True
"""
new_anchor = Anchor()
new_anchor.save()
diff --git a/rest_framework/tests/validators.py b/rest_framework/tests/validators.py
index b390c42f..c032985e 100644
--- a/rest_framework/tests/validators.py
+++ b/rest_framework/tests/validators.py
@@ -285,7 +285,7 @@
# uiop = models.CharField(max_length=256, blank=True)
# @property
-# def readonly(self):
+# def read_only(self):
# return 'read only'
# class MockResource(ModelResource):
@@ -298,7 +298,7 @@
# def test_property_fields_are_allowed_on_model_forms(self):
# """Validation on ModelForms may include property fields that exist on the Model to be included in the input."""
-# content = {'qwerty': 'example', 'uiop': 'example', 'readonly': 'read only'}
+# content = {'qwerty': 'example', 'uiop': 'example', 'read_only': 'read only'}
# self.assertEqual(self.validator.validate_request(content, None), content)
# def test_property_fields_are_not_required_on_model_forms(self):
@@ -310,19 +310,19 @@
# """If some (otherwise valid) content includes fields that are not in the form then validation should fail.
# It might be okay on normal form submission, but for Web APIs we oughta get strict, as it'll help show up
# broken clients more easily (eg submitting content with a misnamed field)"""
-# content = {'qwerty': 'example', 'uiop': 'example', 'readonly': 'read only', 'extra': 'extra'}
+# content = {'qwerty': 'example', 'uiop': 'example', 'read_only': 'read only', 'extra': 'extra'}
# self.assertRaises(ImmediateResponse, self.validator.validate_request, content, None)
# def test_validate_requires_fields_on_model_forms(self):
# """If some (otherwise valid) content includes fields that are not in the form then validation should fail.
# It might be okay on normal form submission, but for Web APIs we oughta get strict, as it'll help show up
# broken clients more easily (eg submitting content with a misnamed field)"""
-# content = {'readonly': 'read only'}
+# content = {'read_only': 'read only'}
# self.assertRaises(ImmediateResponse, self.validator.validate_request, content, None)
# def test_validate_does_not_require_blankable_fields_on_model_forms(self):
# """Test standard ModelForm validation behaviour - fields with blank=True are not required."""
-# content = {'qwerty': 'example', 'readonly': 'read only'}
+# content = {'qwerty': 'example', 'read_only': 'read only'}
# self.validator.validate_request(content, None)
# def test_model_form_validator_uses_model_forms(self):