aboutsummaryrefslogtreecommitdiffstats
path: root/rest_framework/mixins.py
diff options
context:
space:
mode:
authorLudwig Kraatz2012-11-13 19:15:42 +0100
committerLudwig Kraatz2012-11-13 19:15:42 +0100
commitb341dc70af828d066eb3891e8eafb6337cdd2d04 (patch)
tree353031cd15c006a8b1f94a0e1cee96b0443d6fd3 /rest_framework/mixins.py
parent851dff1644f6dafd29838a997a788df51c0570a3 (diff)
downloaddjango-rest-framework-b341dc70af828d066eb3891e8eafb6337cdd2d04.tar.bz2
fixed ugly code
Location header is set just, if there is a Location field on the serializer.
Diffstat (limited to 'rest_framework/mixins.py')
-rw-r--r--rest_framework/mixins.py14
1 files changed, 6 insertions, 8 deletions
diff --git a/rest_framework/mixins.py b/rest_framework/mixins.py
index eddd8f49..832365e5 100644
--- a/rest_framework/mixins.py
+++ b/rest_framework/mixins.py
@@ -20,17 +20,15 @@ class CreateModelMixin(object):
if serializer.is_valid():
self.pre_save(serializer.object)
self.object = serializer.save()
- headers = self.get_success_headers(serializer)
+ headers = self.get_success_headers(serializer.data)
return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
- def get_success_headers(self,serializer):
- headers = {}
- for name,field in serializer.fields.iteritems():
- if isinstance(field,HyperlinkedIdentityField):
- headers["Location"] = field.field_to_native(self.object,name)
- break
- return headers
+ def get_success_headers(self,data):
+ if "url" in data:
+ return {'Location':data.get("url")}
+ else:
+ return {}
def pre_save(self, obj):
pass