aboutsummaryrefslogtreecommitdiffstats
path: root/rest_framework/mixins.py
diff options
context:
space:
mode:
authorTom Christie2013-04-09 19:37:19 +0100
committerTom Christie2013-04-09 19:37:19 +0100
commit9bb1277e512a88e6c11c52457d0c24e73f30bb98 (patch)
treebc3be92629dd69fbcde4527b80bb2e827def687f /rest_framework/mixins.py
parent1de6cff11b71e4aaa7b76219d4d2118021e23a00 (diff)
downloaddjango-rest-framework-9bb1277e512a88e6c11c52457d0c24e73f30bb98.tar.bz2
Cleaning up around bits of API that will be pending deprecation
Diffstat (limited to 'rest_framework/mixins.py')
-rw-r--r--rest_framework/mixins.py9
1 files changed, 3 insertions, 6 deletions
diff --git a/rest_framework/mixins.py b/rest_framework/mixins.py
index b15cb11f..6e40b5c4 100644
--- a/rest_framework/mixins.py
+++ b/rest_framework/mixins.py
@@ -67,8 +67,7 @@ class ListModelMixin(object):
empty_error = "Empty list and '%(class_name)s.allow_empty' is False."
def list(self, request, *args, **kwargs):
- queryset = self.get_queryset()
- self.object_list = self.filter_queryset(queryset)
+ self.object_list = self.filter_queryset(self.get_queryset())
# Default is to allow empty querysets. This can be altered by setting
# `.allow_empty = False`, to raise 404 errors on empty querysets.
@@ -79,7 +78,7 @@ class ListModelMixin(object):
# Pagination size is set by the `.paginate_by` attribute,
# which may be `None` to disable pagination.
- page_size = self.get_paginate_by(self.object_list)
+ page_size = self.get_paginate_by()
if page_size:
packed = self.paginate_queryset(self.object_list, page_size)
paginator, page, queryset, is_paginated = packed
@@ -96,9 +95,7 @@ class RetrieveModelMixin(object):
Should be mixed in with `SingleObjectAPIView`.
"""
def retrieve(self, request, *args, **kwargs):
- queryset = self.get_queryset()
- filtered_queryset = self.filter_queryset(queryset)
- self.object = self.get_object(filtered_queryset)
+ self.object = self.get_object()
serializer = self.get_serializer(self.object)
return Response(serializer.data)