diff options
| author | Sébastien Piquemal | 2012-01-10 20:38:01 +0200 |
|---|---|---|
| committer | Sébastien Piquemal | 2012-01-10 20:38:01 +0200 |
| commit | 792bc4d60814af026f926a4c92a9d4a8e3124341 (patch) | |
| tree | 432554dbd7bc4d924aa0240e02286afbaeae768b /djangorestframework/serializer.py | |
| parent | 0d64b4a704eed2fb483de66a7e7271ac83144530 (diff) | |
| download | django-rest-framework-792bc4d60814af026f926a4c92a9d4a8e3124341.tar.bz2 | |
fixed issue#73 and added a test
Diffstat (limited to 'djangorestframework/serializer.py')
| -rw-r--r-- | djangorestframework/serializer.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/djangorestframework/serializer.py b/djangorestframework/serializer.py index 4e1c6b80..43d32b29 100644 --- a/djangorestframework/serializer.py +++ b/djangorestframework/serializer.py @@ -230,12 +230,14 @@ class Serializer(object): # serialize each required field for fname in fields: try: - if inspect.ismethod(getattr(self, fname, None)) and \ - len(inspect.getargspec(getattr(self, fname))[0]) == 2: - # check first for a method 'fname' on self first + # we first check for a method 'fname' on self, + # 'fname's signature must be 'def fname(self, instance)' + meth = getattr(self, fname, None) + if (inspect.ismethod(meth) and + len(inspect.getargspec(meth)[0]) == 2): obj = meth(instance) elif hasattr(instance, '__contains__') and fname in instance: - # check for a key 'fname' on the instance + # then check for a key 'fname' on the instance obj = instance[fname] elif hasattr(instance, smart_str(fname)): # finally check for an attribute 'fname' on the instance |
