Merge pull request #2196 from tomchristie/tomchristie-improve-update-nested-validation

Improve checks for nested creates and updates.

1 files changed, 4 insertions, 4 deletions

diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py
index d417ca80..c7f04b40 100644
--- a/rest_framework/serializers.py
+++ b/rest_framework/serializers.py
@@ -633,8 +633,8 @@ class ModelSerializer(Serializer):
         # If we don't do this explicitly they'd likely get a confusing
         # error at the point of calling `Model.objects.create()`.
         assert not any(
-            isinstance(field, BaseSerializer) and not field.read_only
-            for field in self.fields.values()
+            isinstance(field, BaseSerializer) and (key in validated_attrs)
+            for key, field in self.fields.items()
         ), (
             'The `.create()` method does not suport nested writable fields '
             'by default. Write an explicit `.create()` method for serializer '
@@ -681,8 +681,8 @@ class ModelSerializer(Serializer):
 
     def update(self, instance, validated_attrs):
         assert not any(
-            isinstance(field, BaseSerializer) and not field.read_only
-            for field in self.fields.values()
+            isinstance(field, BaseSerializer) and (key in validated_attrs)
+            for key, field in self.fields.items()
         ), (
             'The `.update()` method does not suport nested writable fields '
             'by default. Write an explicit `.update()` method for serializer '