diff options
| author | Michael Elovskikh | 2013-02-15 14:41:12 +0600 | 
|---|---|---|
| committer | Michael Elovskikh | 2013-02-15 14:41:12 +0600 | 
| commit | 8fdf9250157cde2341ec9c86ead44b2ed1354aa2 (patch) | |
| tree | e4c6504712720b8168ac462d1ebb4feffdbd3304 | |
| parent | de029561d0cbb090c0d704811551b2d611472288 (diff) | |
| download | django-rest-framework-8fdf9250157cde2341ec9c86ead44b2ed1354aa2.tar.bz2 | |
Added tabs between object form and generic content form on PUT/PATCH form
Some extra behaviour to `BrowsableAPIRenderer` to handle PATCH form.
Added PATCH button on generic content PUT form.
Tabs between object form and generic content form on PUT/PATCH form wich are
both allways visible now.
Fix #570
Refs #591
| -rw-r--r-- | rest_framework/renderers.py | 10 | ||||
| -rw-r--r-- | rest_framework/static/rest_framework/js/default.js | 2 | ||||
| -rw-r--r-- | rest_framework/templates/rest_framework/base.html | 63 | ||||
| -rw-r--r-- | rest_framework/templates/rest_framework/form.html | 13 | 
4 files changed, 62 insertions, 26 deletions
diff --git a/rest_framework/renderers.py b/rest_framework/renderers.py index a6525404..736384d6 100644 --- a/rest_framework/renderers.py +++ b/rest_framework/renderers.py @@ -345,12 +345,11 @@ class BrowsableAPIRenderer(BaseRenderer):          if not self.show_form_for_method(view, method, request, obj):              return -        if method == 'DELETE' or method == 'OPTIONS': +        if method in ('DELETE', 'OPTIONS'):              return True  # Don't actually need to return a form          if not getattr(view, 'get_serializer', None) or not parsers.FormParser in view.parser_classes: -            media_types = [parser.media_type for parser in view.parser_classes] -            return self.get_generic_content_form(media_types) +            return          serializer = view.get_serializer(instance=obj)          fields = self.serializer_to_form_fields(serializer) @@ -422,14 +421,17 @@ class BrowsableAPIRenderer(BaseRenderer):          view = renderer_context['view']          request = renderer_context['request']          response = renderer_context['response'] +        media_types = [parser.media_type for parser in view.parser_classes]          renderer = self.get_default_renderer(view)          content = self.get_content(renderer, data, accepted_media_type, renderer_context)          put_form = self.get_form(view, 'PUT', request)          post_form = self.get_form(view, 'POST', request) +        patch_form = self.get_form(view, 'PATCH', request)          delete_form = self.get_form(view, 'DELETE', request)          options_form = self.get_form(view, 'OPTIONS', request) +        generic_content_form = self.get_generic_content_form(media_types)          name = self.get_name(view)          description = self.get_description(view) @@ -449,8 +451,10 @@ class BrowsableAPIRenderer(BaseRenderer):              'available_formats': [renderer.format for renderer in view.renderer_classes],              'put_form': put_form,              'post_form': post_form, +            'patch_form': patch_form,              'delete_form': delete_form,              'options_form': options_form, +            'generic_content_form': generic_content_form,              'api_settings': api_settings          }) diff --git a/rest_framework/static/rest_framework/js/default.js b/rest_framework/static/rest_framework/js/default.js index ecaccc0f..bc5b0292 100644 --- a/rest_framework/static/rest_framework/js/default.js +++ b/rest_framework/static/rest_framework/js/default.js @@ -3,3 +3,5 @@ prettyPrint();  $('.js-tooltip').tooltip({      delay: 1000  }); + +$('#form-switcher a:first').tab('show');
\ No newline at end of file diff --git a/rest_framework/templates/rest_framework/base.html b/rest_framework/templates/rest_framework/base.html index 8d807574..87e5dc04 100644 --- a/rest_framework/templates/rest_framework/base.html +++ b/rest_framework/templates/rest_framework/base.html @@ -147,32 +147,49 @@                  </div>                  {% endif %} -                {% if put_form %} +                {% if 'PUT' in allowed_methods or 'PATCH' in allowed_methods %}                  <div class="well"> -                    <form action="{{ request.get_full_path }}" method="POST" {% if put_form.is_multipart %}enctype="multipart/form-data"{% endif %} class="form-horizontal"> -                        <fieldset> -                            <input type="hidden" name="{{ api_settings.FORM_METHOD_OVERRIDE }}" value="PUT" /> -                            {% csrf_token %} -                            {{ put_form.non_field_errors }} -                            {% for field in put_form %} -                                <div class="control-group"> <!--{% if field.errors %}error{% endif %}--> -                                    {{ field.label_tag|add_class:"control-label" }} -                                    <div class="controls"> -                                        {{ field }} -                                        <span class='help-inline'>{{ field.help_text }}</span> -                                        <!--{{ field.errors|add_class:"help-block" }}--> -                                    </div> -                                </div> -                            {% endfor %} -                            <div class="form-actions"> -                                <button class="btn btn-primary js-tooltip" title="Make a PUT request on the {{ name }} resource">PUT</button> -                            </div> - -                        </fieldset> -                    </form> +                    <ul class="nav nav-pills" id="form-switcher"> +                        {% if put_form %} +                        <li><a href="#object-form" data-toggle="pill">Object form</a></li> +                        {% endif %} +                        <li><a href="#generic-content-form" data-toggle="pill">Generic content form</a></li> +                    </ul> +                    <div class="tab-content"> +                        {% if put_form %} +                        <div class="tab-pane" id="object-form"> +                            {% with form=put_form %} +                                <form action="{{ request.get_full_path }}" method="POST" {% if form.is_multipart %}enctype="multipart/form-data"{% endif %} class="form-horizontal"> +                                    <fieldset> +                                        {% include "rest_framework/form.html" %} +                                        <div class="form-actions"> +                                            <button class="btn btn-primary js-tooltip" name="{{ api_settings.FORM_METHOD_OVERRIDE }}" value="PUT" title="Make a PUT request on the {{ name }} resource">PUT</button> +                                        </div> +                                    </fieldset> +                                </form> +                            {% endwith %} +                        </div> +                        {% endif %} +                        <div class="tab-pane" id="generic-content-form"> +                            {% with form=generic_content_form %} +                                <form action="{{ request.get_full_path }}" method="POST" {% if form.is_multipart %}enctype="multipart/form-data"{% endif %} class="form-horizontal"> +                                    <fieldset> +                                        {% include "rest_framework/form.html" %} +                                        <div class="form-actions"> +                                            {% if 'PUT' in allowed_methods %} +                                            <button class="btn btn-primary js-tooltip" name="{{ api_settings.FORM_METHOD_OVERRIDE }}" value="PUT" title="Make a PUT request on the {{ name }} resource">PUT</button> +                                            {% endif %} +                                            {% if 'PATCH' in allowed_methods %} +                                            <button class="btn btn-primary js-tooltip" name="{{ api_settings.FORM_METHOD_OVERRIDE }}" value="PATCH" title="Make a PUT request on the {{ name }} resource">PATCH</button> +                                            {% endif %} +                                        </div> +                                    </fieldset> +                                </form> +                            {% endwith %} +                        </div> +                    </div>                  </div>                  {% endif %} -              {% endif %}          </div> diff --git a/rest_framework/templates/rest_framework/form.html b/rest_framework/templates/rest_framework/form.html new file mode 100644 index 00000000..dc7acc70 --- /dev/null +++ b/rest_framework/templates/rest_framework/form.html @@ -0,0 +1,13 @@ +{% load rest_framework %} +{% csrf_token %} +{{ form.non_field_errors }} +{% for field in form %} +    <div class="control-group"> <!--{% if field.errors %}error{% endif %}--> +        {{ field.label_tag|add_class:"control-label" }} +        <div class="controls"> +            {{ field }} +            <span class="help-inline">{{ field.help_text }}</span> +            <!--{{ field.errors|add_class:"help-block" }}--> +        </div> +    </div> +{% endfor %}  | 
