diff options
| author | Tom Christie | 2014-08-14 14:29:28 +0100 |
|---|---|---|
| committer | Tom Christie | 2014-08-14 14:29:28 +0100 |
| commit | f23b500fba771f7ad12201b2830b4314e1d47c41 (patch) | |
| tree | cc43de826817132f5c9e6875ed1ed84825cd1615 | |
| parent | c52075f392420356c471860dc07f9371002efe39 (diff) | |
| parent | 34c1da3515dbf4e9a0d645ebf81cde6f61254e31 (diff) | |
| download | django-rest-framework-f23b500fba771f7ad12201b2830b4314e1d47c41.tar.bz2 | |
Merge pull request #1757 from jwhitlock/error_as_list
ModelSerializer.restore_object - wrap ValueError error in a list
| -rw-r--r-- | rest_framework/serializers.py | 2 | ||||
| -rw-r--r-- | rest_framework/tests/test_serializer.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index c2b414d7..43d339da 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -977,7 +977,7 @@ class ModelSerializer(Serializer): try: setattr(instance, key, val) except ValueError: - self._errors[key] = self.error_messages['required'] + self._errors[key] = [self.error_messages['required']] # Any relations that cannot be set until we've # saved the model get hidden away on these diff --git a/rest_framework/tests/test_serializer.py b/rest_framework/tests/test_serializer.py index 91248ce7..fb2eac0b 100644 --- a/rest_framework/tests/test_serializer.py +++ b/rest_framework/tests/test_serializer.py @@ -685,7 +685,7 @@ class ModelValidationTests(TestCase): photo_serializer = PhotoSerializer(instance=photo, data={'album': ''}, partial=True) self.assertFalse(photo_serializer.is_valid()) self.assertTrue('album' in photo_serializer.errors) - self.assertEqual(photo_serializer.errors['album'], photo_serializer.error_messages['required']) + self.assertEqual(photo_serializer.errors['album'], [photo_serializer.error_messages['required']]) def test_foreign_key_with_partial(self): """ |
