diff options
| author | Tom Christie | 2013-12-22 04:53:00 -0800 |
|---|---|---|
| committer | Tom Christie | 2013-12-22 04:53:00 -0800 |
| commit | 9b7341e4840635d9c3bd419678164cdc3cbb7d20 (patch) | |
| tree | 2a728f85b59d30e38e7b4f416738e9b30e2ea2af | |
| parent | b7482629c304452ca127f46b982c1c62f63c55b1 (diff) | |
| parent | 2d6d725c2f7f2226f9287211e64037816f8f2cac (diff) | |
| download | django-rest-framework-9b7341e4840635d9c3bd419678164cdc3cbb7d20.tar.bz2 | |
Merge pull request #1312 from amatellanes/master
Simplified some functions in permissions.py
| -rw-r--r-- | rest_framework/permissions.py | 22 |
1 files changed, 7 insertions, 15 deletions
diff --git a/rest_framework/permissions.py b/rest_framework/permissions.py index ab6655e7..f24a5123 100644 --- a/rest_framework/permissions.py +++ b/rest_framework/permissions.py @@ -54,9 +54,7 @@ class IsAuthenticated(BasePermission): """ def has_permission(self, request, view): - if request.user and request.user.is_authenticated(): - return True - return False + return request.user and request.user.is_authenticated() class IsAdminUser(BasePermission): @@ -65,9 +63,7 @@ class IsAdminUser(BasePermission): """ def has_permission(self, request, view): - if request.user and request.user.is_staff: - return True - return False + return request.user and request.user.is_staff class IsAuthenticatedOrReadOnly(BasePermission): @@ -76,11 +72,9 @@ class IsAuthenticatedOrReadOnly(BasePermission): """ def has_permission(self, request, view): - if (request.method in SAFE_METHODS or - request.user and - request.user.is_authenticated()): - return True - return False + return (request.method in SAFE_METHODS or + request.user and + request.user.is_authenticated()) class DjangoModelPermissions(BasePermission): @@ -138,11 +132,9 @@ class DjangoModelPermissions(BasePermission): perms = self.get_required_permissions(request.method, model_cls) - if (request.user and + return (request.user and (request.user.is_authenticated() or not self.authenticated_users_only) and - request.user.has_perms(perms)): - return True - return False + request.user.has_perms(perms)) class DjangoModelPermissionsOrAnonReadOnly(DjangoModelPermissions): |
