From edd9d828bbeebc867710d5e078c1b0f8e80dc5b6 Mon Sep 17 00:00:00 2001 From: Aymeric Augustin Date: Sun, 24 Nov 2013 12:57:51 +0100 Subject: Removed unneeded Panel.slug attribute. --- debug_toolbar/panels/__init__.py | 11 +++-------- tests/test_integration.py | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/debug_toolbar/panels/__init__.py b/debug_toolbar/panels/__init__.py index 1ab500b..5175278 100644 --- a/debug_toolbar/panels/__init__.py +++ b/debug_toolbar/panels/__init__.py @@ -25,7 +25,6 @@ class Panel(object): def __init__(self, toolbar, context={}): self.toolbar = toolbar self.context.update(context) - self.slug = slugify(self.name) def content(self): if self.has_content: @@ -69,17 +68,13 @@ class Panel(object): def disable_instrumentation(self): pass - # Store and retrieve stats (shared between panels) + # Store and retrieve stats (shared between panels for no good reason) def record_stats(self, stats): - panel_stats = self.toolbar.stats.get(self.slug) - if panel_stats: - panel_stats.update(stats) - else: - self.toolbar.stats[self.slug] = stats + self.toolbar.stats.setdefault(self.panel_id, {}).update(stats) def get_stats(self): - return self.toolbar.stats.get(self.slug, {}) + return self.toolbar.stats.get(self.panel_id, {}) # Standard middleware methods diff --git a/tests/test_integration.py b/tests/test_integration.py index f3631e4..56a2d9c 100644 --- a/tests/test_integration.py +++ b/tests/test_integration.py @@ -45,7 +45,7 @@ class DebugToolbarTestCase(BaseTestCase): panel = self.toolbar.get_panel_by_id('RequestPanel') panel.process_request(self.request) panel.process_response(self.request, self.response) - return self.toolbar.stats['request'] + return panel.get_stats() def test_url_resolving_positional(self): stats = self._resolve_stats('/resolving1/a/b/') -- cgit v1.2.3