From d1b0e56604dab0feaa2b1cc7e86633d59f77d9e4 Mon Sep 17 00:00:00 2001 From: Rob Hudson Date: Wed, 18 Nov 2009 07:29:48 -0800 Subject: Fixed leaking middleware for non-200 requests. Thanks to Michael Elsdörfer for the report and patch. --- debug_toolbar/middleware.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/debug_toolbar/middleware.py b/debug_toolbar/middleware.py index eed25c4..5c10f9f 100644 --- a/debug_toolbar/middleware.py +++ b/debug_toolbar/middleware.py @@ -83,11 +83,10 @@ class DebugToolbarMiddleware(object): 'debug_toolbar/redirect.html', {'redirect_to': redirect_to} ) - if response.status_code != 200: - return response - for panel in self.debug_toolbars[request].panels: - panel.process_response(request, response) - if response['Content-Type'].split(';')[0] in _HTML_TYPES: - response.content = replace_insensitive(smart_unicode(response.content), u'', smart_unicode(self.debug_toolbars[request].render_toolbar() + u'')) + if response.status_code == 200: + for panel in self.debug_toolbars[request].panels: + panel.process_response(request, response) + if response['Content-Type'].split(';')[0] in _HTML_TYPES: + response.content = replace_insensitive(smart_unicode(response.content), u'', smart_unicode(self.debug_toolbars[request].render_toolbar() + u'')) del self.debug_toolbars[request] return response -- cgit v1.2.3