aboutsummaryrefslogtreecommitdiffstats
path: root/debug_toolbar
diff options
context:
space:
mode:
authorRob Hudson2009-11-18 07:29:48 -0800
committerRob Hudson2009-11-18 07:29:48 -0800
commitd1b0e56604dab0feaa2b1cc7e86633d59f77d9e4 (patch)
treeabb31ba3b0f38b073251b6c1da9b317f80fd3531 /debug_toolbar
parentf36b72655349cf3b8e9105bed3be5cd065162476 (diff)
downloaddjango-debug-toolbar-d1b0e56604dab0feaa2b1cc7e86633d59f77d9e4.tar.bz2
Fixed leaking middleware for non-200 requests.
Thanks to Michael Elsdörfer for the report and patch.
Diffstat (limited to 'debug_toolbar')
-rw-r--r--debug_toolbar/middleware.py11
1 files changed, 5 insertions, 6 deletions
diff --git a/debug_toolbar/middleware.py b/debug_toolbar/middleware.py
index eed25c4..5c10f9f 100644
--- a/debug_toolbar/middleware.py
+++ b/debug_toolbar/middleware.py
@@ -83,11 +83,10 @@ class DebugToolbarMiddleware(object):
'debug_toolbar/redirect.html',
{'redirect_to': redirect_to}
)
- if response.status_code != 200:
- return response
- for panel in self.debug_toolbars[request].panels:
- panel.process_response(request, response)
- if response['Content-Type'].split(';')[0] in _HTML_TYPES:
- response.content = replace_insensitive(smart_unicode(response.content), u'</body>', smart_unicode(self.debug_toolbars[request].render_toolbar() + u'</body>'))
+ if response.status_code == 200:
+ for panel in self.debug_toolbars[request].panels:
+ panel.process_response(request, response)
+ if response['Content-Type'].split(';')[0] in _HTML_TYPES:
+ response.content = replace_insensitive(smart_unicode(response.content), u'</body>', smart_unicode(self.debug_toolbars[request].render_toolbar() + u'</body>'))
del self.debug_toolbars[request]
return response