diff options
| author | David Cramer | 2011-08-21 17:56:19 -0700 |
|---|---|---|
| committer | David Cramer | 2011-08-21 17:56:19 -0700 |
| commit | 695e8c06bfc756204e823d1b1792ca6c06e62439 (patch) | |
| tree | dfd2e28a9c35b72352317dd93df6c48f7218ec50 | |
| parent | 6e3d9da54cffb41461c6778c55b0461410a9655c (diff) | |
| parent | 490df5e463bb9b7892809b8ec5629995062fa1c6 (diff) | |
| download | django-debug-toolbar-695e8c06bfc756204e823d1b1792ca6c06e62439.tar.bz2 | |
Merge pull request #198 from jasonkeene/internal_ips_issue
Toolbar Displays to External IPs (Fixed Issue #186)
| -rw-r--r-- | debug_toolbar/middleware.py | 5 | ||||
| -rw-r--r-- | tests/tests.py | 20 |
2 files changed, 12 insertions, 13 deletions
diff --git a/debug_toolbar/middleware.py b/debug_toolbar/middleware.py index 05d8e80..0c6821f 100644 --- a/debug_toolbar/middleware.py +++ b/debug_toolbar/middleware.py @@ -69,10 +69,7 @@ class DebugToolbarMiddleware(object): remote_addr = request.META.get('REMOTE_ADDR', None) # if not internal ip, and not DEBUG - if not (remote_addr in settings.INTERNAL_IPS or settings.DEBUG): - return False - - return True + return remote_addr in settings.INTERNAL_IPS and bool(settings.DEBUG) def process_request(self, request): __traceback_hide__ = True diff --git a/tests/tests.py b/tests/tests.py index 80fda7d..6f7de0d 100644 --- a/tests/tests.py +++ b/tests/tests.py @@ -55,23 +55,25 @@ class DebugToolbarTestCase(BaseTestCase): def test_show_toolbar_DEBUG(self): request = self.request + request.META = {'REMOTE_ADDR': '127.0.0.1'} middleware = DebugToolbarMiddleware() - with Settings(DEBUG=True): + with Settings(INTERNAL_IPS=['127.0.0.1'], DEBUG=True): self.assertTrue(middleware._show_toolbar(request)) - with Settings(DEBUG=False): + with Settings(INTERNAL_IPS=['127.0.0.1'], DEBUG=False): self.assertFalse(middleware._show_toolbar(request)) def test_show_toolbar_TEST(self): request = self.request + request.META = {'REMOTE_ADDR': '127.0.0.1'} middleware = DebugToolbarMiddleware() - with Settings(TEST=True, DEBUG=True): + with Settings(INTERNAL_IPS=['127.0.0.1'], TEST=True, DEBUG=True): self.assertFalse(middleware._show_toolbar(request)) - with Settings(TEST=False, DEBUG=True): + with Settings(INTERNAL_IPS=['127.0.0.1'], TEST=False, DEBUG=True): self.assertTrue(middleware._show_toolbar(request)) def test_show_toolbar_INTERNAL_IPS(self): @@ -80,10 +82,10 @@ class DebugToolbarTestCase(BaseTestCase): request.META = {'REMOTE_ADDR': '127.0.0.1'} middleware = DebugToolbarMiddleware() - with Settings(INTERNAL_IPS=['127.0.0.1']): + with Settings(INTERNAL_IPS=['127.0.0.1'], DEBUG=True): self.assertTrue(middleware._show_toolbar(request)) - with Settings(INTERNAL_IPS=[]): + with Settings(INTERNAL_IPS=[], DEBUG=True): self.assertFalse(middleware._show_toolbar(request)) def test_request_urlconf_string(self): @@ -93,7 +95,7 @@ class DebugToolbarTestCase(BaseTestCase): request.META = {'REMOTE_ADDR': '127.0.0.1'} middleware = DebugToolbarMiddleware() - with Settings(DEBUG=True): + with Settings(INTERNAL_IPS=['127.0.0.1'], DEBUG=True): middleware.process_request(request) self.assertFalse(isinstance(request.urlconf, basestring)) @@ -109,7 +111,7 @@ class DebugToolbarTestCase(BaseTestCase): request.META = {'REMOTE_ADDR': '127.0.0.1'} middleware = DebugToolbarMiddleware() - with Settings(DEBUG=True): + with Settings(INTERNAL_IPS=['127.0.0.1'], DEBUG=True): middleware.process_request(request) request.urlconf = 'debug_toolbar.urls' middleware.process_request(request) @@ -127,7 +129,7 @@ class DebugToolbarTestCase(BaseTestCase): request.META = {'REMOTE_ADDR': '127.0.0.1'} middleware = DebugToolbarMiddleware() - with Settings(DEBUG=True): + with Settings(INTERNAL_IPS=['127.0.0.1'], DEBUG=True): middleware.process_request(request) self.assertFalse(isinstance(request.urlconf, basestring)) |