From 544971cb286e29583ffc7e30f10ec46fe0293ba3 Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Wed, 29 Nov 2017 18:38:14 +0100 Subject: referential_spec(duplicate referential): Remove unnecessary association When creating `ReferentialMetadata`s, I had written in associations with the `Referential`s built at the top of the tests. However, since those referentials weren't saved and had no IDs, these "associations" had no meaning. They can just be removed, and the association will be taken care of by the `referential_#.metadatas <<` lines. Thanks to Robert for pointing this out in pre-review. Refs #5024 --- spec/models/referential_spec.rb | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) (limited to 'spec/models') diff --git a/spec/models/referential_spec.rb b/spec/models/referential_spec.rb index c064987c3..022ece7ef 100644 --- a/spec/models/referential_spec.rb +++ b/spec/models/referential_spec.rb @@ -139,12 +139,8 @@ describe Referential, :type => :model do referential_2 = referential_1.dup referential_2.slug = "#{referential_1.slug}_different" - metadata_1 = build( - :referential_metadata, - referential: referential_1 - ) + metadata_1 = build(:referential_metadata) metadata_2 = metadata_1.dup - metadata_2.referential = referential_2 referential_1.metadatas << metadata_1 referential_2.metadatas << metadata_2 @@ -172,12 +168,8 @@ describe Referential, :type => :model do referential_2.slug = "#{referential_1.slug}_different" referential_3 = nil - metadata_1 = build( - :referential_metadata, - referential: referential_1 - ) + metadata_1 = build(:referential_metadata) metadata_2 = metadata_1.dup - metadata_2.referential = referential_2 referential_1.metadatas << metadata_1 referential_2.metadatas << metadata_2 -- cgit v1.2.3