From 940ebd078f484a3b3f511baed1574945e705ca83 Mon Sep 17 00:00:00 2001 From: Robert Date: Thu, 14 Dec 2017 11:02:42 +0100 Subject: Refs: #5006@0.1h; Hotfix removed forgotten file.close --- app/workers/workbench_import_worker.rb | 1 - 1 file changed, 1 deletion(-) (limited to 'app/workers') diff --git a/app/workers/workbench_import_worker.rb b/app/workers/workbench_import_worker.rb index 35a9eff0b..6420be835 100644 --- a/app/workers/workbench_import_worker.rb +++ b/app/workers/workbench_import_worker.rb @@ -58,7 +58,6 @@ class WorkbenchImportWorker File.open(Rails.root.join('tmp', 'imports', "WorkbenchImport_#{eg_name}_#{$$}.zip"), 'wb') do |file| eg_stream.rewind file.write eg_stream.read - file.close end upload_entry_group_tmpfile eg_name, File.new(Rails.root.join('tmp', 'imports', "WorkbenchImport_#{eg_name}_#{$$}.zip")) -- cgit v1.2.3 From 443de38df52143f72d97308c28ac68f99e009757 Mon Sep 17 00:00:00 2001 From: Robert Date: Fri, 15 Dec 2017 08:24:24 +0100 Subject: Fixes: #5281@1.2h; View specs and minor CR change from #5006 - CR change from #5006, severity of zip file messages :warning -> :error - View specs for showing import_messages --- app/workers/workbench_import_worker/object_state_updater.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'app/workers') diff --git a/app/workers/workbench_import_worker/object_state_updater.rb b/app/workers/workbench_import_worker/object_state_updater.rb index e9cc081b7..67bdc0654 100644 --- a/app/workers/workbench_import_worker/object_state_updater.rb +++ b/app/workers/workbench_import_worker/object_state_updater.rb @@ -14,7 +14,7 @@ class WorkbenchImportWorker def update_foreign_lines entry return if entry.foreign_lines.empty? workbench_import.messages.create( - criticity: :warning, + criticity: :error, message_key: 'foreign_lines_in_referential', message_attributes: { 'source_filename' => workbench_import.file.file.file, @@ -25,7 +25,7 @@ class WorkbenchImportWorker def update_spurious entry return if entry.spurious.empty? workbench_import.messages.create( - criticity: :warning, + criticity: :error, message_key: 'inconsistent_zip_file', message_attributes: { 'source_filename' => workbench_import.file.file.file, -- cgit v1.2.3