From 2dd301fa9326a3b3bbaeec76f9845697f8236248 Mon Sep 17 00:00:00 2001 From: jpl Date: Wed, 1 Mar 2017 15:16:41 +0100 Subject: Refs #2648: jp_collection post-refacto fixes + cities display feature --- .../journey_patterns/components/JourneyPattern.js | 172 ++++++++++++--------- .../journey_patterns/components/JourneyPatterns.js | 30 +++- .../components/SaveJourneyPattern.js | 2 +- 3 files changed, 126 insertions(+), 78 deletions(-) (limited to 'app/assets/javascripts') diff --git a/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPattern.js b/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPattern.js index 9e554b38e..e6b560317 100644 --- a/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPattern.js +++ b/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPattern.js @@ -1,84 +1,108 @@ var React = require('react') +var Component = require('react').Component var PropTypes = require('react').PropTypes var actions = require('../actions') -const JourneyPattern = (props) => { - return ( -
- {/* Errors */} - {(props.value.errors) && ( - - )} +class JourneyPattern extends Component{ + constructor(props){ + super(props) + this.previousCity = undefined + } -
-
{props.value.object_id ? props.value.object_id : '-'}
-
{props.value.registration_number}
-
{actions.getChecked(props.value.stop_points).length} arrêt(s)
- -
-
- -
- -
+ cityNameChecker(sp) { + let bool = false + if(sp.city_name != this.previousCity){ + bool = true + this.previousCity = sp.city_name + } + return ( +
+ + this.props.onCheckboxChange(e)} + type='checkbox' + id={sp.id} + checked={sp.checked} + disabled={this.props.value.deletable ? 'disabled' : ''} + > + + +
+ ) + } + + render() { + this.previousCity = undefined + + return ( +
+ {/* Errors */} + {(this.props.value.errors) && ( +
    + {Object.keys(this.props.value.errors).map(function(key, i) { + return ( +
  • + '{key}' {this.props.value.errors[key]} +
  • + ) + })} +
+ )} - {props.value.stop_points.map((stopPoint, i) => -
- - props.onCheckboxChange(e)} - type='checkbox' - id={stopPoint.id} - checked={stopPoint.checked} - disabled={props.value.deletable ? 'disabled' : ''} - > - - - -
- )} -
- ) +
+
{this.props.value.object_id ? this.props.value.object_id : '-'}
+
{this.props.value.registration_number}
+
{actions.getChecked(this.props.value.stop_points).length} arrêt(s)
+ +
+
+ +
+ +
+
+ + {this.props.value.stop_points.map((stopPoint, i) =>{ + return ( +
+ {this.cityNameChecker(stopPoint)} +
+ ) + })} +
+ ) + } } JourneyPattern.propTypes = { diff --git a/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPatterns.js b/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPatterns.js index dc55038c3..69d36abe6 100644 --- a/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPatterns.js +++ b/app/assets/javascripts/es6_browserified/journey_patterns/components/JourneyPatterns.js @@ -6,6 +6,7 @@ var JourneyPattern = require('./JourneyPattern') class JourneyPatterns extends Component{ constructor(props){ super(props) + this.previousCity = undefined } componentDidMount() { this.props.onLoadFirstPage() @@ -53,7 +54,26 @@ class JourneyPatterns extends Component{ } } + cityNameChecker(sp) { + let bool = false + if(sp.city_name != this.previousCity){ + bool = true + this.previousCity = sp.city_name + } + return ( +
+ {sp.name} +
+ ) + } + render() { + this.previousCity = undefined + if(this.props.status.isFetching == true) { return (
@@ -78,9 +98,13 @@ class JourneyPatterns extends Component{
Code mission
Nb arrêts
- {this.props.stopPointsList.map((sp, i) => -
{sp.name}
- )} + {this.props.stopPointsList.map((sp, i) =>{ + return ( +
+ {this.cityNameChecker(sp)} +
+ ) + })}
diff --git a/app/assets/javascripts/es6_browserified/journey_patterns/components/SaveJourneyPattern.js b/app/assets/javascripts/es6_browserified/journey_patterns/components/SaveJourneyPattern.js index d030ba9eb..b4b278ae4 100644 --- a/app/assets/javascripts/es6_browserified/journey_patterns/components/SaveJourneyPattern.js +++ b/app/assets/javascripts/es6_browserified/journey_patterns/components/SaveJourneyPattern.js @@ -25,7 +25,7 @@ class SaveJourneyPattern extends Component{
{e.preventDefault()}}>