From e20ce60629e91c63d75701651c117177ce02aced Mon Sep 17 00:00:00 2001
From: Alban Peignier
Date: Thu, 28 Dec 2017 12:16:19 +0100
Subject: Add log messages when Referential can't be created. Remove useless
 build_referenial invocation in ReferentialsController#create. Refs #5297

---
 app/controllers/referentials_controller.rb | 7 ++++---
 app/models/referential.rb                  | 1 +
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/controllers/referentials_controller.rb b/app/controllers/referentials_controller.rb
index 9dbd659da..f63abf685 100644
--- a/app/controllers/referentials_controller.rb
+++ b/app/controllers/referentials_controller.rb
@@ -14,15 +14,16 @@ class ReferentialsController < ChouetteController
 
   def create
     create! do |success, failure|
-      build_referenial
-
       success.html do
         if @referential.created_from_id.present?
           flash[:notice] = t('notice.referentials.duplicate')
           redirect_to workbench_path(@referential.workbench)
         end
       end
-      failure.html { render :new }
+      failure.html do
+        Rails.logger.info "Can't create Referential : #{@referential.errors.inspect}"
+        render :new
+      end
     end
   end
 
diff --git a/app/models/referential.rb b/app/models/referential.rb
index 122af65a1..8db009ebd 100644
--- a/app/models/referential.rb
+++ b/app/models/referential.rb
@@ -282,6 +282,7 @@ class Referential < ActiveRecord::Base
 
   def detect_overlapped_referentials
     self.class.where(id: overlapped_referential_ids).each do |referential|
+      Rails.logger.info "Referential #{referential.id} #{referential.metadatas.inspect} overlaps #{metadatas.inspect}"
       errors.add :metadatas, I18n.t("referentials.errors.overlapped_referential", :referential => referential.name)
     end
   end
-- 
cgit v1.2.3