From a6ca6664092af35505b269052d685c08b4dde8b2 Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Thu, 15 Jun 2017 11:22:41 +0200 Subject: TableBuilderHelper: Add a couple TODOs Refs #3479 --- app/helpers/table_builder_helper.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/helpers/table_builder_helper.rb b/app/helpers/table_builder_helper.rb index 9384f8791..7e8a235b5 100644 --- a/app/helpers/table_builder_helper.rb +++ b/app/helpers/table_builder_helper.rb @@ -10,10 +10,12 @@ module TableBuilderHelper collection, columns, current_referential: nil, + # TODO: use this when building column headers sortable: true, selectable: false, # selection_actions: [] ## this has been gotten rid of. The element based on this should be created elsewhere links: [], # links: or actions: ? I think 'links' is better since 'actions' evokes Rails controller actions and we want to put `link_to`s here + # TODO: get rid of this argument. Going with params instead sort_by: {}, # { column: 'name', direction: 'desc' } cls: '' # can we rename this to "class"? # ^^ rename to html_options = {} at the end of the non-keyword arguments? Hrm, not a fan of combining hash args and keyword args -- cgit v1.2.3