| Age | Commit message (Collapse) | Author |
|---|
|
|
|
#4257 #4258
|
|
|
|
regarding the functional scope of the current organozation
|
|
The `TableBuilderHelper` now requires you to specify a `link_to`
attribute in a column you want to make a link out of instead of doing it
automagically as before.
Update the tests to do this and continue to output the right `<a>`s for
links.
|
|
This reverts commit 28db706443a912e8355e4c48488dc40c403e7f76.
Turns out we didn't need to be able to pass an arbitrary number of
arguments to the lambda after all. The URL helper objects necessary in
addition to the first argument to the lambda can be retrieved from the
view context directly instead of passing them into the block as
parameters (which would actually make things more difficult, because the
block is called in the `TableBuilderHelper`, thus outside the scope of
the view).
|
|
This enables us to pass multiple objects into the lambda, so that we can
for example build a URL using a Rails helper using multiple objects.
Example:
column.link_to(referential, item)
lambda do |referential, item|
some_path(referential, item)
end
|
|
This tells the markup assembler whether or not this column should be
wrapped in a link (`<a>`). It intends to serve the same purpose as
`TableBuilderHelper#column_is_linkable`, but at the column level. The
idea is to remove that method when these links only operate by column
and not by pre-defined values like before/now.
|
|
This parameter will be used as the `href` to link the column value
somewhere.
We give it a lambda because this makes it easier to call any method on
the row object.
This means the accessor needs to take the object as an argument, like in
the `#value` method, because we don't have a better way to handle that
(it can't be done at initialisation time because at that point we don't
have row objects, we have a collection).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The code in `#perform` now updates the `started_at` time field which
breaks the existing mocks. Update them to match the code. Yes, T-not-DD.
|
|
Don't skip these any more. Working to figure out how to make new specs
that work with the new code.
|
|
|
|
|
|
|
|
When any one of a parent import's children have failed, the parent
import should get status 'failed'.
|
|
Getting rid of the other commented test that checks failure because that
combination is no longer relevant and the basic failure cases are
handled by the specs just above.
|
|
Since we're not verifying `ended_at`, we have no need for the `Timecop`
block.
|
|
The name doesn't really match what's happening, since no `child` is
passed in as an argument any more. This just always happens any time
there are one or more failing children.
Remove the mock expectation because the extra fields don't really relate
to what we're supposed to be testing here, namely `status`.
|
|
These tests fail and are now wrong. While we previously prevented
updating the import object in the old code, now the `#update` method
gets called no matter what.
|
|
The new `#child_change` doesn't do a whole lot, so the specs that used
to test it don't belong any more. Update them so they test
`#update_status` instead, where this logic now lives.
|
|
This method name was changed in 46aafcc4dbc65ef3216fbcae3b11b263e1c025c0
because it handles multiple referentials now. Update the tests to
reflect that.
|
|
Update the mock to include the `ended_at` field update that happens in
the code to get these tests green again. Not sure if we're going to
continue to use them in their current state, but we'll worry about that
later.
|
|
|
|
af83/import--fix-parent-status-update-on-child-change
Import fix parent status update on child change
OH GOODNESS WHAT HAVE I DONE I SKIPPED ALL THE SPECS
|
|
Need to get this ready for QA and I have to leave for a client meeting
RIGHT NOW. As concluded in discussions, SKIP ALL THE THINGS so we can
get the code into the hands of testers.
|
|
Previously we were only updating the `ended_at` field when the import
had a 'successful' status. But there are other statuses that indicate
the import finished, and the `ended_at` field should be updated in these
cases also.
Committing what I have now which seems to work but I didn't write specs
for it because it was a pain to test (what with creating a child, etc.).
The `#update_status` method should be refactored to make testing the
`ended_at` update easier.
This needs to be committed without specs now because I'm off to go to a
client meeting and this work/branch is blocking QA of imports both
internally and externally. So I guess doing things right comes later.
That is to say, probably a lot later. Who knows.
|
|
A bunch of things that need to be written to get this in proper working
order.
|
|
This method is no longer used, now that we have Alban's `#update_status`
method.
Originally this was supposed to be used to determine if the import was
finished or not. Now, the parent import status field update doesn't
depend on it, and we can use the `Referential#ready` field to determine
whether or not to display the import in the interface.
|
|
|
|
* The `allow` on the first line didn't appear to be necessary
* Need to use `create` instead of `build_stubbed` in order to provide
access to the `children` relation
* The `#update` method gets called with a hash of arguments now,
containing `current_step` and `status`. Update the mock to match the
new code.
|
|
`Import#child_change` no longer takes an argument, so we need to remove
if from the tests.
|
|
Some quick tests for the recent changes to `#child_change`, to ensure
that `#update_status` and `#update_referential` are called by the
method.
|
|
|
|
|
|
from real data. Refs #4273
|
|
|
|
|
|
regression_4273_spec fixture files. Ignore target files. Refs #4273
|
|
|
|
|
|
|
|
|
|
These relied on the previous behaviour of `#post_resource` handling
uploads. This is no longer the case. Instead, you have to call
`HTTPService.upload` manually and pass the result to `#post_resource`
via the `params` argument (like in `WorkbenchImportWorker#params`).
|
|
The `ReferentialMetadataKludge` expects a couple of `Chouette::Line`s to
already exist in the database in order to successfully create a
`ReferentialMetadata` record.
In tests, this is not the case. As a kludge to the kludge, create the
expected line records in the tests that fail because of it, with the
proviso that these additions should be removed or changed once we have
real `ReferentialMetadata` handling for imports.
|
