aboutsummaryrefslogtreecommitdiffstats
path: root/spec
AgeCommit message (Collapse)Author
2018-02-02Refs #3542 @4h; First UIZog
Still missing: - Pagination - Filters
2018-02-02Refs #5835; Timetables inherit application days from calendars5835-fix-timetable-creationZog
2018-02-02Refs 5832; Fix bug on ReferentialVehicleJourneys#index filtersZog
By default a value was always set on the "Line" filter, yielding misleading results.
2018-02-01Fixes vehicle_journeys#index specAlban Peignier
2018-01-31Fix calendar mailer urlcedricnjanga
2018-01-31Refs #5598 @1h; Add specsZog
2018-01-31Refs #5647; Scope CustomField validations on workgroupZog
2018-01-31Refs #5682 @3h; Use same UI as for timetablesZog
2018-01-31Refs #5682; Set default value for application daysZog
2018-01-31Refs #5682; Add application_days field to calendarsZog
2018-01-31Fix specsZog
2018-01-31Merge pull request #264 from af83/5754-filter-journeys-on-calendarLuc Donnet
5754 Add a filter on purchase_windows on ReferentialVJs#index
2018-01-31Merge pull request #269 from ↵Luc Donnet
af83/5574-vehicle-journeys--fix-transporter-deletion-in-modal--rb 5574 vehicle journeys fix transporter deletion in modal rb
2018-01-31Refs #5754; Add a filter on calendars for ReferentialVJs#index5754-filter-journeys-on-calendarZog
2018-01-31Refs #5754; Add a filter on purchase_windows on ReferentialVJs#indexZog
2018-01-31Fix StopArea validation breaking the specsZog
2018-01-31Merge pull request #263 from af83/5750-non-commercial-stop-areasLuc Donnet
5750 non commercial stop areas
2018-01-31Refs #5683 @2H; Fix specs and refactor action_linksZog
Note: Did not fix the missing workgroup in the calendar mailer
2018-01-30Make some changes to avoid unnacessaty lines of codecedricnjanga
2018-01-30Merge pull request #251 from af83/5647-scope-custom-fields-validationsLuc Donnet
Scope CustomField validations on workgroup
2018-01-30Merge pull request #257 from af83/5598-fix-journey-patterns-collectionLuc Donnet
5598 Enable button to view a JourneyPattern
2018-01-30VehicleJourney: Allow deletion of associated companyTeddy Wing
If the state doesn't contain a company, that means it was deleted on the frontend. In that case, the backend code should correctly delete the associated company from the vehicle journey. Refs #5574
2018-01-30Fix infinity loop in spec/views/referentials/show.html.erb_spec.rb detected ↵5764-add-checksum-to-purchase-windowsLuc Donnet
only in ruby 2.3.1
2018-01-29Refs #5750; Add a validation on VehicleJourneysZog
Ensure a time is set for all non-commercial stops
2018-01-29Refs #5750 @1h; Manage non-commercial StopAreasZog
- Add a `kind` attribute - Hide irrelevant fields in the form
2018-01-26Refs #5750 @1h; Add a "kind" attribute to StopAreasZog
This determines if the StopArea is commercial or not The useless fields are hidden in the form for the non-commercials ones
2018-01-25Refs #5586; Fix specsZog
2018-01-25Refs #5586; CR #2Zog
2018-01-25Refs #5586 @2h; Fix specsZog
2018-01-25Refs #5586; Remove spec for a decorator which no longer existsZog
2018-01-25Refs 5586; CR #1Zog
2018-01-25Refs #5586; Add more specs on AF83::Decorator::LinkZog
2018-01-25Refs #5586; Add more specs on AF83::Decorator::LinkZog
2018-01-25Refs #5586; Add a `feature` option on the `action_links`Zog
2018-01-25Refs #5586 @1h; Ensure retrocompatibilityZog
And remove snapshots (we don't need it anymore)
2018-01-25Refs #5586 @2h; Refactor the whole thingZog
We now have a ModelDecorator and an "instance" decorator, all in the same file, with the same API.
2018-01-25Refs #5586 @2h; Better implementation of groupsZog
Used it in Lines#index and Lines#show, probably broke everything else
2018-01-25Refs #5586 @1h; Primary and secondary lonks implementationZog
As well as the `to_html` method
2018-01-25Refs #5586 @4h; First `action_links` refactorZog
- Implement new API - Migrate the LineDecorator - ensure no change on the "lines/index" view
2018-01-25Refs #5598 @1h; Add specs5598-fix-journey-patterns-collectionZog
2018-01-22Refs #5647; Scope CustomField validations on workgroup5647-scope-custom-fields-validationsZog
2018-01-19Add missing spec on VehicleJourneyAtStopZog
2018-01-19Merge pull request #247 from ↵Luc Donnet
af83/5592-workbenches-show--filter-by-workgroup-on-initial-load 5592 workbenches show filter by workgroup on initial load
2018-01-19Merge pull request #248 from af83/5623-fix-schedule-when-jp-is-prefilledLuc Donnet
5623 fix schedule when jp is prefilled
2018-01-19Fix compliance check sets breadcrumb, locales and datas displayLuc Donnet
2018-01-17Refs #5614 @0.5h; Fix schedule computation when departure minutes are not set5614-fix-schedule-computationZog
2018-01-17offer_workbenches/show.html.erb_spec: Give workbenches same workgroup5592-workbenches-show--filter-by-workgroup-on-initial-loadTeddy Wing
I was getting the following test failures after having modified `Workbench#all_referentials` in 93b60066cc49d699171d6a50798c5939a4644eea: Failures: 1) workbenches/show should include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil> Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential expected #<ActiveRecord::AssociationRelation [#<Referential id: 3, name: "Test 2", slug: "test_2", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil> Diff: @@ -1,2 +1,25 @@ -[#<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "2018-01-17 10:18:49", prefix: "organisation_5", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 6, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 14, stop_area_referential_id: 10, workbench_id: 3, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>] +[#<Referential:0x007fd30e897428 + id: 3, + name: "Test 2", + slug: "test_2", + created_at: Wed, 17 Jan 2018 11:18:42 CET +01:00, + updated_at: Wed, 17 Jan 2018 11:18:44 CET +01:00, + prefix: "organisation_3", + projection_type: nil, + time_zone: "Europe/Paris", + bounds: nil, + organisation_id: 4, + geographical_bounds: nil, + user_id: nil, + user_name: nil, + data_format: "netex", + line_referential_id: 4, + stop_area_referential_id: 4, + workbench_id: 2, + archived_at: nil, + created_from_id: nil, + ready: true, + referential_suite_id: nil, + objectid_format: "stif_netex", + merged_at: nil>] # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load' # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call' # -e:1:in `<main>' 2) workbenches/show without permission should disable all the checkboxes Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential expected #<ActiveRecord::AssociationRelation [#<Referential id: 7, name: "Test 6", slug: "test_6", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil> Diff: @@ -1,2 +1,25 @@ -[#<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "2018-01-17 10:18:57", prefix: "organisation_11", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 12, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 26, stop_area_referential_id: 18, workbench_id: 5, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>] +[#<Referential:0x007fd30eadc210 + id: 7, + name: "Test 6", + slug: "test_6", + created_at: Wed, 17 Jan 2018 11:18:52 CET +01:00, + updated_at: Wed, 17 Jan 2018 11:18:53 CET +01:00, + prefix: "organisation_9", + projection_type: nil, + time_zone: "Europe/Paris", + bounds: nil, + organisation_id: 10, + geographical_bounds: nil, + user_id: nil, + user_name: nil, + data_format: "netex", + line_referential_id: 16, + stop_area_referential_id: 12, + workbench_id: 4, + archived_at: nil, + created_from_id: nil, + ready: true, + referential_suite_id: nil, + objectid_format: "stif_netex", + merged_at: nil>] # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load' # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call' # -e:1:in `<main>' 3) workbenches/show with permission referentials.destroy should enable the checkbox for the referential which belongs to the same organisation and disable the other one Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential expected #<ActiveRecord::AssociationRelation [#<Referential id: 11, name: "Test 10", slug: "test_10", created_...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil> Diff: @@ -1,2 +1,25 @@ -[#<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at: "2018-01-17 10:19:05", prefix: "organisation_17", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 18, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 38, stop_area_referential_id: 26, workbench_id: 7, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>] +[#<Referential:0x007fd309268e30 + id: 11, + name: "Test 10", + slug: "test_10", + created_at: Wed, 17 Jan 2018 11:19:00 CET +01:00, + updated_at: Wed, 17 Jan 2018 11:19:02 CET +01:00, + prefix: "organisation_15", + projection_type: nil, + time_zone: "Europe/Paris", + bounds: nil, + organisation_id: 16, + geographical_bounds: nil, + user_id: nil, + user_name: nil, + data_format: "netex", + line_referential_id: 28, + stop_area_referential_id: 20, + workbench_id: 6, + archived_at: nil, + created_from_id: nil, + ready: true, + referential_suite_id: nil, + objectid_format: "stif_netex", + merged_at: nil>] # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency' # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load' # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call' # -e:1:in `<main>' Finished in 29.81 seconds (files took 1.7 seconds to load) 3 examples, 3 failures The new behaviour requires referentials to have the same workgroup in order to be displayed on this page. Modify the test to give both `same_organisation_referential` and `different_organisation_referential` the same workgroup to get the tests to pass. Refs #5592
2018-01-16workbenches/show: Filter referentials by workgroupTeddy Wing
Previously, all `Referential`s would be listed on this page if they had matching line metadata. Now, we exclude those referentials that are in other workgroups to ensure users don't see referentials they're not supposed to see. Refs #5592
2018-01-15workbenches_show_spec: Test organisations in filtration listTeddy Wing
Check that only `Organisation`s associated with the current `Workgroup` appear in the list of filters on `Workbenches#show`. Also rewrite the `other_referential` object to put it in a different workbench from the first referential, enabling us to have multiple organisations in the same `Workgroup`. Refs #5140
2018-01-12Merge pull request #236 from af83/5560-add-validation-on-customfieldsLuc Donnet
5560 Add validation on CustomField
generated by cgit v1.2.3 (git 2.25.1) at 2026-09-13 02:29:13 +0000