| Age | Commit message (Collapse) | Author |
|---|
|
- using webmock instead of mocking Net::HTTP
therefore removing the connascence between the spec and the
HTTP lib used in the implementation, thank you Teddy
|
|
|
|
|
|
Return `true` from this method by default. If the `#update` call fails,
then it will return `false`, but in all other cases, we should return
`true`. That way, when the
`Api::V1::ComplianceCheckSetsController#validated` endpoint is called,
it will respond with the `ComplianceCheckSet` object instead of:
{"status":"error","messages":[]}
with no error messages.
Refs #4757
|
|
If any associated resources have the "IGNORED" status, this shouldn't
affect the outcome of a "successful" status. Allow the
`ComplianceCheckSet` to be "successful" even if some `Resource`s are
"IGNORED".
Refs #4757
|
|
We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.
Refs #4757
|
|
This reverts commit b7477e28f90c961079c7b12c4992071cbc11b2d6.
This logic isn't right. We should return true/false based on the result
of `update`, as in, whether the value was able to be updated, instead of
on the contents of the status.
|
|
Ensure that `#update_status` always returns a boolean value. We'll be
using this to determine whether the updated status was 'successful' or
not. Hmmm. Wait. That's not right. We want to return true from the
update, we don't care about the status. The error case should be when
the `update` fails. Darn.
Refs #4757
|
|
Move the successful `ComplianceCheckResource`s to the end so that these
tests fail if we don't wait until the end of a loop through the resoures
before updating the status to 'successful'.
Refs #4757
|
|
Add test cases for status update when `ComplianceCheckResource` are
"ERROR" and "WARNING". If a single Resource is "ERROR" or "WARNING",
then the `ComplianceCheckSet` becomes "failed" or "warning".
Refs #4757
|
|
Initial spec that checks the correct status field change when all
`ComplianceCheckResource`s are successful.
Refs #4757
|
|
On successful status update, respond with the `ComplianceCheckSet`
object attributes. Otherwise, respond with an error JSON.
Refs #4757
|
|
Get the `ComplianceCheckSet` from the URL and call its `#update_status`
method.
This doesn't currently work all the way. We need to send a real
response.
Refs #4757
|
|
This route will be called by the Java application when ComplianceCheck
validation is completed.
It will perform post-validation work, primarily updating statuses.
Refs #4757
|
|
|
|
|
|
|
|
|
|
|
|
|
|
4755 page for validate referential
|
|
|
|
add specs
|
|
|
|
4802 referential model normalisation
|
|
|
|
CR 3rd (and hopefully last) part
- more typo corrections
- reactivating deactivated specs
- fixed reactivated specs
|
|
af83/4782-create-worker-for-compliance-check-copy--rb201710301748
4782 create worker for compliance check copy rb201710301748
|
|
CR 2nd part
- typos
- unnecessary `class: Referential` removed from referentials_factory
- regrouping of referential_suite related model specs
|
|
CodeReview:
- Exchange fr and en translation files for referential_suites
- Consistent usage of `jeu de donées` and `espace de travail` dans les *fr.yml
Fixes: #4802@0.2h; Replaying former work. To identify spec regression
Step 3: Added validation of reference_suite#new/current
Made all specs pass
|
|
The `ComplianceControlSetCopyWorker` depends on
`ComplianceControlSetCopier#copy` to return the `ComplianceCheckSet`
that it creates.
Refs #4782
|
|
Step 2: Added validation of reference->workbench->organisation consistency
Made all specs pass
Chased bug #4826
|
|
Filter Feature Spex of ComplianceControlSet#show implemented
|
|
ComplianceControl.subclass_patterns [amend me] [skip-ci]
|
|
Speced feature compliance_control_set/show and filtering on Severity
MISSING: Object Filter needs 2B specified
|
|
DB Setup for specs
|
|
4817 better traduction
|
|
|
|
|
|
param name
|
|
|
|
|
|
In the first test, we weren't stubbing the Java API call, so it would
get executed for real. Put the HTTP stub in a `before(:each)` call so
that it gets stubbed for every test here.
Additionally, reorganise the tests a bit to clean them up. Move the HTTP
stub to a `let` to allow it to be called in a couple different places.
Since the HTTP stub depends on the `check_set` double, move that to a
`let` too. And have the `ComplianceControlSetCopier` mock always return
`check_set`, now that the app code depends on that return value.
Refs #4782
|
|
Previously I had been passing the `ComplianceControlSet` ID to the Java
API. The API actually expects the ID of the `ComplianceCheckSet`.
In order to get this ID, have the `ComplianceControlSetCopier` return
the `ComplianceCheckSet` that it creates, and use that to pass the the
ID to the Java API.
Refs #4782
|
|
Call the Java API URL to launch a validation after having copied the
`ComplianceControlSet` into a `ComplianceCheckSet`.
Copied the format with error logging from
`NetexImport#launch_java_import`.
In the test, make the ID variables global by putting them in `let`s.
Add `config.iev_url` to the Rails `test` environment so that we can
access this from our tests.
TODO: I just realised I'm sending the wrong ID. I should be sending the
check set ID.
Refs #4782
|
|
A new worker that launches the work to copy a `ComplianceControlSet` to
a `ComplianceCheckSet`.
Currently only handles a single control set and referential pair.
Probably want to extend this to handle multiple lists of these objects.
Also need to add in a call to the Java API to validate the check.
Refs #4782
|
|
Fixes: #4633;@0.5h; CR changes
|
|
|
|
|
|
|
