| Age | Commit message (Collapse) | Author |
|---|
|
|
|
- Get rid of ActiveSupport::Concern in the spec helpers
- Rename misnamed spec files
|
|
- Fix specs on connections_links/show
- Update pundit view specs helper to use the current referential when it
has already been defined
|
|
Add specs for the view.
Refactor to come
|
|
- CR change from #5006, severity of zip file messages :warning -> :error
- View specs for showing import_messages
|
|
Zip Support for Specs, allowing to create zip archives in memory
* create zip archive from hash or directory tree
* Metaspecs -- commented out
- for potential refactoring of Zip Support
- as readable documentation on how to use Zip Support
|
|
Since the tests I was trying to use `truncation` for are now skipped,
remove these exceptions and revert this line back to what it was before
all this mess.
Refs #5024
|
|
The `truncation: true` strategy wasn't sticking. The config `before`
block only ran once for this test file. Instead of attaching the filter
to the `it` blocks, put it on the `context`. This correctly gets each
test to run in a transaction.
Remove the `truncation: false` filter I had added previously as this
didn't do what I wanted it to: it prevented the `before` block from
running instead of filtering out tests with `truncation: true`.
Refs #5024
|
|
After the first `truncation: true` test ran, all tables would be
cleared. This caused errors as our tests rely on a referential like this
existing:
Referential.create(name: 'first')
It also caused problems with `LineReferential` as the `:chouette_line`
factory depends on an existing `LineReferential` associated to the
`first` Referential.
Add the `referentials` and `line_referentials` tables to the exclusion
list when truncating so these tables don't get cleared and the 'first'
records persist across test runs like before.
To prevent errors trying to unnecessarily switch to the 'first'
referential in `truncation: true` tests, disable that functionality by
adding a filter to exclude these tests from the normal transactional
`before(:each)` config block.
Refs #5024
|
|
5024-prevent-duplicate-referentials-from-being-created-during-parallel-db-transactions--rb201711271659
|
|
|
|
5024-prevent-duplicate-referentials-from-being-created-during-parallel-db-transactions--rb201711271659
Conflicts:
app/models/referential.rb
A whitespace conflict in a place I don't even remember editing? Okaay.
|
|
associated Workbench
- changed ObjectIdFormatterSupport as requested
- respeced all defined cases
- implemented respec
Missing:
What to do in `define_default_attributes` if ref has no workbench and no `objectid_format`?
|
|
This `before` hook allows tests to use the "truncation" database cleanup
strategy. It doesn't do anything explicitly JavaScript-related. Rather,
it was named JS because it was intended to be used for feature tests
with JavaScript. However, now that I need to use it for a couple tests
in `spec/models/referential_spec.rb`, the `:js` name doesn't make sense.
Rename the filter to something that says what it does, not how it should
be used.
Refs #5024
|
|
|
|
|
|
We now always use modules for namespaces
=> same structure for models, decorators, policies...
|
|
4823 compliance check show
|
|
- Implements the view
Missing:
- Spex failing (xpath navigation inside the display blocks is still faulty)
- Links to compliance_checks#show do not work (actually not this page's problem)
|
|
after_commit on: :create
|
|
- using webmock instead of mocking Net::HTTP
therefore removing the connascence between the spec and the
HTTP lib used in the implementation, thank you Teddy
|
|
|
|
|
|
spurious directories
- Speced and implemented
Missing:
- Exact message parameters (change key from xxx, how to add names of spurious directories)
|
|
- Discussing Spec
- Speced and implemented the corrupt zipfile part
Next:
- Spec incorrect directory structure part
- Implement incorrect directory structure part
|
|
Validation implemented for min_max_values with correct I18n'd error messages
Applied to: VehicleJourneyControl::Speed & GenericAttributeControl::MinMax
|
|
- setting up a CCCLD subdir struct for CCCLD related tests
- removed all occcurances of `@@default_criticity`
|
|
- Rebase on udated master
- Removal of `default_criticity` from ComplianceControl Class Level Defaults
- Refactoring of specs to allow usage of the same shared examples (given that more models need to undergo the same refact)
|
|
Comprehensive Tests for ComplianceControl Class Level Default Attributes
|
|
Got some data_modifier support for attribute generation w/w-o defaults for model tests generic_attribute_control
|
|
(Compliance Control)
|
|
af83/3520-workbench--add-output-association-to-ReferentialSuite
3520 workbench add output association to referential suite
|
|
Instead of creating the objects directly in ActiveRecord, use our
existing factories for these records as suggested by Robert.
Refs #3520
|
|
Added Controller Spec
Fixed Older Specs
|
|
|
|
Since the `output` attribute is now initialised automatically in the
`Workbench#initialize_output` `before_validation` callback, the one I
added here before I created the callback can be removed. Instead we'll
rely on the callback to create a new `ReferentialSuite` for us.
Refs #3520
|
|
Ensure all workbenches always have an associated `ReferentialSuite` by
validating presence of the `output` attribute.
In order to pass the 'should have a valid factory' test, we need to
define a `ReferentialSuite` factory and set up a default association on
`output` in the `Workbench` factory.
We also need to add set `output` when creating a `Workbench` in
`spec/support/referential.rb`, otherwise we get a validation error that
breaks the tests. Clean up the formatting of that call. In order to pass
a `ReferentialSuite`, I just create one above, but I'm not sure if I
should be using a `find_or_create` mechanism like the other associated
objects do above.
Refs #3520
|
|
|
|
|
|
|
|
4189 duplicate route
|
|
like in application controller
|
|
|
|
Added params to certains paths to have the workbench_id in it.
The goal is to have the current workbench_id to assign it when do a Referential#new_from
Then I finished the use of the functional scope to avoid potential errors
I skipped some tests that hve a #TODO so we can easily find them
|
|
Refs #4280
|
|
|
|
organisation code
|
|
|
|
`Chouette::Route#duplicate`
|
|
|
