| Age | Commit message (Collapse) | Author |
|---|
|
CR 3rd (and hopefully last) part
- more typo corrections
- reactivating deactivated specs
- fixed reactivated specs
|
|
Step 2: Added validation of reference->workbench->organisation consistency
Made all specs pass
Chased bug #4826
|
|
Filter Feature Spex of ComplianceControlSet#show implemented
|
|
ComplianceControl.subclass_patterns [amend me] [skip-ci]
|
|
Speced feature compliance_control_set/show and filtering on Severity
MISSING: Object Filter needs 2B specified
|
|
DB Setup for specs
|
|
Add a controller concern to deal with date filters
|
|
|
|
|
|
* Make failing /delete_api_key_feature_spec pending
- Seems Capybara only sees html from the partial api_keys/_form, but not
the parent api_keys/edit, which happens to contain the delete link :(
* ApiKeyPolicy adapted
- update? depends on record's organisation as no referential present
- create? depends on user's permission only as organisation will be correct anyway
|
|
needs of #4446
|
|
|
|
|
|
Ticket in Feedback
|
|
like in application controller
|
|
- Add some context to referential and workbench decorator to access current_referential and assign it to the cloned referential
- Add a build_referential method to avoir duplicates of code (in the controller and in the model), need to clean a bit more
- Need to add some Spec features to take into account the functional scope of the current_user
|
|
|
|
|
|
Added params to certains paths to have the workbench_id in it.
The goal is to have the current workbench_id to assign it when do a Referential#new_from
Then I finished the use of the functional scope to avoid potential errors
I skipped some tests that hve a #TODO so we can easily find them
|
|
|
|
regarding the functional scope of the current organozation
|
|
|
|
|
|
|
|
That route has been removed. Fix the test to ensure it doesn't get
accessed, but still performs what was previously tested.
Refs #3479
|
|
Now that I removed the `ReferentialLinesController#index` method and
template (c7ceb38801b853154cdae31672ff2c105c8b191f), it no longer makes
sense to keep these tests around.
Refs #3479
|
|
calenders#index view and made them pass
|
|
Policy Refactoring and Policy Test Completion
- All policies (and all permissions) under test.
- Common patterns and potential problems identified...
- ... and documented in DEVNOTES.md
- some simply refactorings
|
|
|
|
newapplication helper default authorization, (no if) ->
* DefaultPolicy (all true)
* Add some policies (LinePolicy)
* Use `boiv:read` pour show, index
* Adapted `table_builder`
|
|
|
|
Refs #3871
|
|
|
|
|
|
refs #3936
|
|
|
|
|
|
|
|
|
|
Now, destroy ("Supprimer") buttons in the header get rendered without a
`<span>` tag surrounding the text inside the button. This is because I
consolidated the HTML structure of the delete buttons inside table gear
menus and the header.
The ones in the gear menus had no span, and these in the header do.
In both places, we're now using `LinksHelper#destroy_link_content` to
generate the contents of the button, making the contents uniform in both
contexts.
This means, however, that the markup is not the same for header buttons,
which now have their inner `<span>` tag removed. Update the test to
reflect this.
Also, the styling breaks when I updated the markup, but Jean-Paul
offered to fix that.
Refs #3479
|
|
Refs #3657
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
