| Age | Commit message (Collapse) | Author |
|---|
|
af83/4758-cron-job-to-finalise-compliance_check_set-validations--
4758 cron job to finalise compliance check set validations
|
|
|
|
|
|
#4126 @1
|
|
|
|
|
|
5807 update webpacker
|
|
|
|
|
|
A new recurring job that does exactly the same thing as the import job.
This finalises `ComplianceCheckSet`s.
First we need to abort all unfinished `ComplianceCheckSet`s older than
four hours. Then we finalise the imports by doing the same work in
`Api::V1::Internals::ComplianceCheckSetsController#notify_parent`,
namely calling `#notify_parent` on `ComplianceCheckSet`s (here, only on
the ones that are finished).
Add a couple new Rake tasks for compliance check sets that mirror those
for imports, and do the work required by the cron job.
Refs #4758
|
|
Replace `ParentImportNotifier` with the new generalised
`ParentNotifier`. This will allow us to use the same service for parent
notification of both imports and compliance check sets.
Delete the `ParentImportNotifier` class and spec as these are now
superseded by `ParentNotifier`.
Refs #4758
|
|
|
|
|
|
before jest launch du to webpacker bug
|
|
|
|
|
|
After re-reading the ticket, I see now that the aborting of old imports
should only apply to `NetexImport`s. Update the code to make this
happen.
Refs #4963
|
|
As a result of a new requirement, before doing the existing work we were
doing in the imports cron job (notifying parent imports), we first need
to clear out old imports and mark them as 'aborted'.
Refs #4963
|
|
before jest launch du to webpacker bug
|
|
|
|
|
|
Note: Did not fix the missing workgroup in the calendar mailer
|
|
|
|
* Decorate the `ComplianceControl` so we can show the action links from
the decorator in the header.
* Add a `decorates` to get `object_class` to work inside the decorator.
* Define `AF83::Decorator.define_instance_class_method` in order to
enable the `@compliance_control.class.METHOD` calls in the view to
work. Thanks very much to Johan for figuring out a way to do that.
Refs #5586
|
|
Previously, we weren't correctly adding the HTTP method to the links in
the header. This is because it's called `link_method` in the class. Put
this value in `method`/`data-method` when converting the link to HTML so
that the links work properly.
Discovered this when deactivating and activating stop areas on
http://stif-boiv.dev:3000/stop_area_referentials/1/stop_areas/139429 .
Refs #5586
|
|
This method was overriding classes that were added by `#add_class` in
addition to those added by `#class`. Obviously, the argument to
`#add_class` should be appended to the default.
That seemed like a pain to do, so instead I'm getting rid of the concept
of a default class. Instead, we're going to force all links to use the
template-defined styles for now. That goes in line with Luc's desire to
be more consistent in the links, as he stated yesterday.
Refs #5586
|
|
Also add a new method `AF83::Decorator.define_instance_method`. Thanks
to Johan for suggesting that and walking me through writing it. This new
method allows us to define methods on the instance decorator. We need
this to preserve the `#bounding_dates` method that was defined in
`PurchaseWindowDecorator`.
Refs #5586
|
|
Instead of checking for an existing class and then setting the class,
provide a method to set a default class when one hasn't been defined.
This does effectively the same thing but moves the condition inside the
method.
Thanks Johan for the suggestion!
Refs #5586
|
|
Begin the process of converting the `ImportDecorator` to the new action
links interface.
For now, only the "New import" button on the top right of the index page
is converted. The rest of the links are commented out for now and will
be treated in a subsequent commit.
Add a new `#class?` method to `AF83::Decorator::Link` that tells callers
whether a CSS class has been defined on the link. This allows us to
determine whether we should force a class or use the one provided in
`_page_header.html.slim`.
We need a way to specify the class of the link in the header because the
"New import" button is supposed to be blue (`.btn-primary`), but the
default for primary action links is white.
Refs #5586
|
|
|
|
|
|
|
|
|
|
|
|
Plus:
- Fix a bug on `html_options` in AF83::Decorator::Link
- Add a `t` helper in AF83::Decorator to handle i18n
|
|
|
|
- Remove ApiKeyDecorator (never used)
- Migrate CalendarDecorator
- Migrate CompanyDecorator
- Migrate TimeTableDecorator
|
|
|
|
|
|
And remove snapshots (we don't need it anymore)
|
|
We now have a ModelDecorator and an "instance" decorator, all in the
same file, with the same API.
|
|
Used it in Lines#index and Lines#show, probably broke everything else
|
|
As well as the `to_html` method
|
|
- Implement new API
- Migrate the LineDecorator
- ensure no change on the "lines/index" view
|
|
|
|
scoping
|
|
|
|
|
|
- Register all models that implement checksums
- Add a simple rake task that updates all checksums within a given
referential
|
|
|
