| Age | Commit message (Collapse) | Author |
|---|
|
Calendar#index date filter (ransackable scope)
I realized that we could submit the form with incomplete date which caused an 500 error.
So I added a small JS script to prevent user from subnitting filter form with incomplete dates
Since it was really similar with previous work I added two folders : /helpers & /filters to be more DRY
The JS files are loaded in 4 views for the moment, hence the update in the assets.rb file
|
|
|
|
|
|
Workbenchimportworker reinstate tests
|
|
Refs #4387
|
|
|
|
|
|
Refs #4386
|
|
Refs #4385
|
|
|
|
Added params to certains paths to have the workbench_id in it.
The goal is to have the current workbench_id to assign it when do a Referential#new_from
Then I finished the use of the functional scope to avoid potential errors
I skipped some tests that hve a #TODO so we can easily find them
|
|
Refs #4384
|
|
Refs #4383
|
|
|
|
|
|
|
|
|
|
|
|
|
|
#4257 #4258
|
|
regarding the functional scope of the current organozation
|
|
|
|
Add the new `link_to` argument to the example to show how it's used.
|
|
This reverts commit 28db706443a912e8355e4c48488dc40c403e7f76.
Turns out we didn't need to be able to pass an arbitrary number of
arguments to the lambda after all. The URL helper objects necessary in
addition to the first argument to the lambda can be retrieved from the
view context directly instead of passing them into the block as
parameters (which would actually make things more difficult, because the
block is called in the `TableBuilderHelper`, thus outside the scope of
the view).
|
|
Rewrite table builder calls to work with the new
`TableBuilderHelper::Column#link_to` mechanism for defining the linked
column and what it points to. This takes the link out of the
`TableBuilderHelper`, and puts it into the hands of the view.
It gives us more flexibility with regards to what can be defined as a
link in our tables and what those links point to.
This will be used in a more meaningful way in the `imports#show` page to
list `NetexImport`s and provide links to both the referential associated
with a Netex import and the imported file status page from a table row.
|
|
This enables us to pass multiple objects into the lambda, so that we can
for example build a URL using a Rails helper using multiple objects.
Example:
column.link_to(referential, item)
lambda do |referential, item|
some_path(referential, item)
end
|
|
Instead of always linking to the `name` and `comment` attributes, allow
any column to link to any thing by calling the new
`TableBuilderHelper::Column#link_to` method.
Because `linkable?`-ness is now determined at the column level, we can
get rid of the `#column_is_linkable?` method here.
The code is still pretty much "en désordre" as a result of the
`overhead` code tornado, but we'll have to deal with that later. (Oh
goodness I hope we get to deal with it.)
|
|
Testing out the new `TableBuilderHelper::Column#link_to` method to
provide the link needed to go to the row object's #show page.
Seems to work in this context, which is promising!
|
|
This tells the markup assembler whether or not this column should be
wrapped in a link (`<a>`). It intends to serve the same purpose as
`TableBuilderHelper#column_is_linkable`, but at the column level. The
idea is to remove that method when these links only operate by column
and not by pre-defined values like before/now.
|
|
This parameter will be used as the `href` to link the column value
somewhere.
We give it a lambda because this makes it easier to call any method on
the row object.
This means the accessor needs to take the object as an argument, like in
the `#value` method, because we don't have a better way to handle that
(it can't be done at initialisation time because at that point we don't
have row objects, we have a collection).
|
|
Refs #4237
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The new form is `#update` and the specs (broken as they are) mock
`#update`, so this call should do the same.
|
|
|
|
|
|
|
|
|
|
Import model clean up code and add specs
|
|
|
|
|
|
|
|
|
|
It isn't used any more so get rid of it. I had forgotten to remove the
argument from the place it was actually called in the code when I did
this previously in 61817b2e7828455021bcec66e2d6da70f879e1c4. Actually,
Alban hadn't modified the method signature in the code he gave me, I
shouldn't have committed that change as him, my bad.
The argument was added back in because it caused `#notify_parent` to
fail. Update that method so it makes the correct method call.
|
|
|
