aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2017-07-27Fix input build with react #4161 @1Luc Donnet
2017-07-27Fix warning in calendar mailer specXinhui
2017-07-27Merge branch 'master' of github.com:AF83/stif-boivLuc Donnet
2017-07-27Fix js call for routing_constraint_zone refs #4029 @1Luc Donnet
2017-07-27Refs: #3507@0.25h; Added information to retry callbacks in RetryService (for ↵Robert
logging)
2017-07-26Refs: #3507@1.5h; RetryService speced and implmentedRobert
2017-07-26RoutingConstraintZones#index: Fix sort in tableTeddy Wing
Sorting by stop point count and route name wasn't working. Only sorting by name worked. This was because these HTML table columns get their data from methods on the `RoutingConstraintZone` model (`#stop_points_count` and `#route_name`). Those methods can't be sorted on in the database. Furthermore, when setting up the order ActiveRecord call, only database column names on `routing_constraint_zones` were taken into account. When a `sort` parameter specified an identifier that wasn't a column name, the `name` column would be used to sort the list. In this change, we enable sorting by stop point count and by route name. The SQL work for ordering comes from a couple of new scope methods defined on the model. Xin explained that he had previously used scope methods to enable exotic sorting of Referentials on the Workbenches#show page. I couldn't think of a better way to deal with these, and it seems like a reasonable thing to do here, so I went with the same setup. In `#sort_column`, tack on our custom sorting keys to the list of accepted keys. This borrows the pattern used in other `#sort_column` methods in other controllers. Ended up using "route" as the route name sorting key because that's what gets passed from the frontend. Eliminated the `if` condition in `#collection` that defaults to `name` sorting because it was redundant. The `#sort_column` method already defaults to sorting by name if no `params[:sort]` is passed in. This makes the method a lot cleaner, nice. Add a new private method `#sort_collection` that determines what method to call to sort the query. When using real table column names, it calls `#order` like before. But now, if the user asked to sort by stop point count or route name, we delegate instead to our scope methods, `#order_by_stop_points_count` and `#order_by_route_name`. Refs #4130
2017-07-26Refs #4115: updating calendar_mailer layoutsjpl
2017-07-26Fix objectid in vehicle journey import & export specXinhui
2017-07-26Fix provider_id & default_values on empty string objectidXinhui
2017-07-26Edit access point to use new StifReflexAttributesSupportXinhui
2017-07-26Comment RCZ and JP validations on stop pointscedricnjanga
2017-07-26Fix workbench I18n specsjpl
2017-07-26Refs #4161: Temp. comment test for delete sp on itinerariesjpl
2017-07-26Refs: #3507@4h; Finished Basic WorkbenchImportWorkerRobert
- speced but missing error treatment
2017-07-26Add some translationscedricnjanga
2017-07-26Merge pull request #39 from af83/4161_StopPoints_RouteEditLuc Donnet
4161 stop points route edit
2017-07-26Merge branch 'master' into 4161_StopPoints_RouteEditLuc Donnet
2017-07-26Fix deleted stop_points use Refs #4161 @1Luc Donnet
2017-07-25Merge branch 'master' into stagingLuc Donnet
2017-07-25Fix breadcrumb for HomepageLuc Donnet
2017-07-25Refs: #3507;20h Specing and Implementing the ZipServiceRobert
2017-07-25Edit factories objectid in accordance with new stif netex formatXinhui
2017-07-25Hot fix Timetable#create - from Calendarcedricnjanga
2017-07-25Hide import button depending on Referential#create? policycedricnjanga
2017-07-25Replace DefaultNetexAttributesSupport by StifNetexAttributesSupportXinhui
2017-07-25Add Concern StifNetexAttributesSupportXinhui
2017-07-25Add tests for Timetable#mergecedricnjanga
2017-07-25Timetable#merge! remove excluded dates if other tt doesn't have themcedricnjanga
2017-07-25Refactoring stop_area model_name into concernsXinhui
2017-07-25Merge branch 'reflex_objectid'Xinhui
2017-07-25Merge pull request #42 from af83/codifligne_objectidXinhui Xu
StifCodifligneAttributesSupport for Line objectid
2017-07-25StifCodifligneAttributesSupport for Line objectidXinhui
2017-07-25Merge pull request #41 from af83/revert-40-codifligne_objectidXinhui Xu
Revert "StifCodifligneAttributesSupport for Line objectid"
2017-07-25Revert "StifCodifligneAttributesSupport for Line objectid"Xinhui Xu
2017-07-25StifReflexAttributesSupport for StopArea objectidXinhui
2017-07-25Merge pull request #40 from af83/codifligne_objectidXinhui Xu
StifCodifligneAttributesSupport for Line objectid
2017-07-25StifCodifligneAttributesSupport for Line objectidXinhui
2017-07-25Refs #4126: Clean up hardcore strings from clean_upjpl
2017-07-24Update Tietable#merge! to manage more edge casescedricnjanga
2017-07-24Add methods to manage continuous dates and periodscedricnjanga
2017-07-24Check tt_params[:calendar_id] in Timetable#createcedricnjanga
2017-07-24Fixes: #4019@1h; Plugged new permission translation into user modelRobert
2017-07-24Refs: #4019@1h; Adds spec for Permission Translation and implements it in ↵Robert
lib/stif/permission_translator
2017-07-24Refs: #4019@0.5h; Fixes devise/cas_controller specRobert
2017-07-24Updating onUpdate behav. according to new specsjpl
2017-07-24Keep sp_id attached to array indexjpl
2017-07-21Sketching out the unzip/zip process, need to change Tempfile to ↵Robert
File.open(..., r) in a configurable directory [amend me]
2017-07-21Refs #4134: fix autocomplete on TT edit tagsjpl
2017-07-21Refs: #3507@4.5h spec setup and refactoring, using Faraday in workerRobert
- Setting up correct headers for the Webmock request (Oh Boy) - Refactoring all Faraday requests into `lib/af83/http_fetcher.rb` - Implementing the Download
generated by cgit v1.2.3 (git 2.25.1) at 2026-09-09 20:06:13 +0000