aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2017-08-30Updating project-specific iconfont for page headersjpl
2017-08-30Don't launch_java_import if NetexImport#status is finished. Refs #4338Alban Peignier
2017-08-30Import spec: Use new `#update_referentials` method nameTeddy Wing
This method name was changed in 46aafcc4dbc65ef3216fbcae3b11b263e1c025c0 because it handles multiple referentials now. Update the tests to reflect that.
2017-08-30Import spec: Get a few old specs to passTeddy Wing
Update the mock to include the `ended_at` field update that happens in the code to get these tests green again. Not sure if we're going to continue to use them in their current state, but we'll worry about that later.
2017-08-30Import#child_change: Remove `child` argumentTeddy Wing
It isn't used any more so get rid of it. I had forgotten to remove the argument from the place it was actually called in the code when I did this previously in 61817b2e7828455021bcec66e2d6da70f879e1c4. Actually, Alban hadn't modified the method signature in the code he gave me, I shouldn't have committed that change as him, my bad. The argument was added back in because it caused `#notify_parent` to fail. Update that method so it makes the correct method call.
2017-08-30Import spec: Use new hash syntaxTeddy Wing
2017-08-29Make ready children referentials when Import is finalizedAlban Peignier
2017-08-29Set started_at & ended_at for WorkbenchImportWorker#performXinhui
Refs #4293
2017-08-29Refs #3367 Change Time table overlap querycedricnjanga
2017-08-29Fixes Import#child_change argumentAlban Peignier
2017-08-29Refs #3367 Change Time table overlap querycedricnjanga
2017-08-29Merge pull request #57 from ↵teddywing
af83/import--fix-parent-status-update-on-child-change Import fix parent status update on child change OH GOODNESS WHAT HAVE I DONE I SKIPPED ALL THE SPECS
2017-08-29Import spec: SKIP ALL THE SPECSTeddy Wing
Need to get this ready for QA and I have to leave for a client meeting RIGHT NOW. As concluded in discussions, SKIP ALL THE THINGS so we can get the code into the hands of testers.
2017-08-29Import#update_status: Clean up status assignmentTeddy Wing
Clean up this section a tiny bit. Should function the same way as before.
2017-08-29Import#update_status: Update `ended_at` when import has finished statusTeddy Wing
Previously we were only updating the `ended_at` field when the import had a 'successful' status. But there are other statuses that indicate the import finished, and the `ended_at` field should be updated in these cases also. Committing what I have now which seems to work but I didn't write specs for it because it was a pain to test (what with creating a child, etc.). The `#update_status` method should be refactored to make testing the `ended_at` update easier. This needs to be committed without specs now because I'm off to go to a client meeting and this work/branch is blocking QA of imports both internally and externally. So I guess doing things right comes later. That is to say, probably a lot later. Who knows.
2017-08-29Import: Add TODOsTeddy Wing
A bunch of things that need to be written to get this in proper working order.
2017-08-29Add condition on reset of LineReferentialSyncs/StopAreaReferentialSyncs by ↵Xinhui
sidekiq initializer Refs #4314
2017-08-29Import: Remove `#ready?`Teddy Wing
This method is no longer used, now that we have Alban's `#update_status` method. Originally this was supposed to be used to determine if the import was finished or not. Now, the parent import status field update doesn't depend on it, and we can use the `Referential#ready` field to determine whether or not to display the import in the interface.
2017-08-29Fix sidekiq initializer should not require LineReferential/StopAreaReferentialXinhui
Refs #4313
2017-08-28Merge branch 'master' into stagingcedricnjanga
2017-08-28Import spec: Fix mock argumentsTeddy Wing
* The `allow` on the first line didn't appear to be necessary * Need to use `create` instead of `build_stubbed` in order to provide access to the `children` relation * The `#update` method gets called with a hash of arguments now, containing `current_step` and `status`. Update the mock to match the new code.
2017-08-28Import spec: Remove argument to `#child_change`Teddy Wing
`Import#child_change` no longer takes an argument, so we need to remove if from the tests.
2017-08-28Import spec: Ensure `#update_` methods are called on `#child_change`Teddy Wing
Some quick tests for the recent changes to `#child_change`, to ensure that `#update_status` and `#update_referential` are called by the method.
2017-08-28Import#child_change: Update ready status of referentialAlban Peignier
After handling a status update of the parent import, if the parent import finished, we should update its referential to `ready: true` so that the referential actually gets displayed on the page.
2017-08-28Import#child_change: Move status update logic into a new methodAlban Peignier
Instead of just looking at the given child, the parent import status is now determined by checking all children and assigning a value based on their status. This also updates the `current_step` (which was previously handled by the `WorkbenchImportWorker`, remind me to remove it from where), and the `ended_at` time. I think `ended_at` should probably be updated in both successful and failed cases. Will have to make that update.
2017-08-28Timetable validate form updatecedricnjanga
2017-08-28Refs #4319 fix timetable autocompletecedricnjanga
2017-08-28Refs #4255: updating overheaded component styles, adding children method for ↵jpl
import
2017-08-28Add link for tmp/imports. Refs #4315Alban Peignier
2017-08-28Don't use directly Rails.root/tmp directory (no writable on servers). Refs #4315Alban Peignier
2017-08-28Define Import#creator even if referential isn't created. Refs #4273Alban Peignier
2017-08-28Fixes ImportsController#collection. Refs #4273Alban Peignier
2017-08-28Merge branch '4273_http_service_broken'Alban Peignier
2017-08-27Create STIF::NetexFile to read zip content and create ReferentialMetadata ↵Alban Peignier
from real data. Refs #4273
2017-08-27Fixes API:v1:NetexImportsController specs. Refs #4273Alban Peignier
2017-08-27NetexImport can be created without Referential. Refs #4273Alban Peignier
2017-08-27Update OFFRE_TRANSDEV_2017030112251.zip to use calendriers.xml. Update ↵Alban Peignier
regression_4273_spec fixture files. Ignore target files. Refs #4273
2017-08-27Update OFFRE_TRANSDEV_2017030112251.zip to use calendriers.xml. Refs #4273Alban Peignier
2017-08-27Change ImportsController to manage only WorkbenchImports. Refs #4273Alban Peignier
2017-08-27Create NetexImport even if Referential can be created. Add a ImportMessage ↵Alban Peignier
and failed status in this case. Refs #4273
2017-08-27Add .zip to uploaded filename (mandatory for java import ?). Refs #4273Alban Peignier
2017-08-27Make NetexImport#parent mandatory. Refs #4273Alban Peignier
2017-08-27Call launch_java_import only when NetexImport is created. Refs #4273Alban Peignier
2017-08-27Launch WorkbenchImportWorker when WorkbenchImport is created. Refs #4273Alban Peignier
2017-08-27Add Import#messages to manage ImportMessages. Refs #4273Alban Peignier
2017-08-27Update OFFRE_TRANSDEV_2017030112251.zip to use calendriers.xml. Refs #4273Alban Peignier
2017-08-27Disable authentication test in NetexImport requests spec. Refs #4311Alban Peignier
2017-08-27Import#referential is mandatory only for NetexImport. Refs #4273Alban Peignier
2017-08-27Disable authentication in NetexImportsController for the moment. Refs #4273Alban Peignier
2017-08-25ErrorFormat: Add TODO to move this fileTeddy Wing
Robert recommended that this file should not live in concerns. Move it somewhere else (maybe lib/ ?).
generated by cgit v1.2.3 (git 2.25.1) at 2026-09-10 10:50:09 +0000