| Age | Commit message (Collapse) | Author |
|---|
|
- CR change from #5006, severity of zip file messages :warning -> :error
- View specs for showing import_messages
|
|
|
|
- Partial created
- Partial used
- Common Helper
- String Keys => Symbol Keys
- Dead Code eliminated
|
|
- Renaming as requested STIF::NetexFile::Frame.get_line_object_id -> get_sgort_id
- working on error_messages for imports#show
|
|
|
|
|
|
|
|
- Rebased #5006 upoon master and created #5281 from #5006
- Setup regression test based on client provided input
- Fixed bug with multiple spurious directory occurances
|
|
|
|
Make dashboard bloc title clickable
|
|
|
|
|
|
- simple simplification (as opposed to complicated simplifications ^^)
|
|
- refact of NetexFile#frames finished, got rid of mystery global $1
|
|
- refact of NetexFile#frames
|
|
|
|
|
|
Implementation of Filtering Out Referentials with foreign lines in `app/workers/workbench_import_worker.rb`
- Using ZipService with the set of allowed lines of the organisation
- Fixing Integration Specs of the worker
- Refactoring, Debugging and Rebasing
|
|
Implementing allowed vs foreign line lookup for the zip service
- Adapting `lib/stif/netex_file.rb` to expose the already implemented matching
- `app/services/zip_service.rb` augmented to check for allowed lines and returning forbidden lines
- Specs with fixtures and using the beforementioned new zip support in the specs
- Fixture directories for the new specs
|
|
Zip Support for Specs, allowing to create zip archives in memory
* create zip archive from hash or directory tree
* Metaspecs -- commented out
- for potential refactoring of Zip Support
- as readable documentation on how to use Zip Support
|
|
Working out how to check for allowed lines vs. foreign lines
- Implement allowed_lines as `Organisation#lines_set`
- Pushed line_id related stuff into `lib/stif/codif_line_id.rb`
- Related Specs
|
|
Refs #5305
|
|
Refs #5305
|
|
Refs #5302
|
|
|
|
Refs #5300
|
|
|
|
|
|
|
|
|
|
|
|
|
|
I was getting test failures like this one:
2) Workbenches show filtering filter by status should display archived referentials
Failure/Error:
def save_with_table_lock_timeout
save_without_table_lock_timeout
rescue ActiveRecord::StatementInvalid => e
if e.message.include?('PG::LockNotAvailable')
raise TableLockTimeoutError.new(e)
else
raise
end
ArgumentError:
wrong number of arguments (given 1, expected 0)
# ./app/models/referential.rb:64:in `save_with_table_lock_timeout'
# .../.gem/ruby/2.3.3/gems/activerecord-4.2.8/lib/active_record/persistence.rb:241:in `update_attribute'
# ./spec/features/workbenches_spec.rb:71:in `block (5 levels) in <top (required)>'
# .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
# .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
# .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
# .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
# .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/command_wrapper.rb:38:in `call'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/application.rb:191:in `block in serve'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/application.rb:161:in `fork'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/application.rb:161:in `serve'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/application.rb:131:in `block in run'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/application.rb:125:in `loop'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/application.rb:125:in `run'
# .../.gem/ruby/2.3.3/gems/spring-2.0.1/lib/spring/application/boot.rb:19:in `<top (required)>'
# -e:1:in `<main>'
Sometimes an argument gets passed to the function and sometimes it
doesn't. Inspecting that argument in a debugger revealed what appeared
to be an options hash:
(byebug) options
{:validate=>false}
Add this optional argument to get past the test failures. At this point
I'm not even really considering whether this is a good idea or not, I
just want this to be done.
Refs #5024
|
|
Now that I've skipped the referential lock tests that were set as
'truncation', we can revert back to old behaviour and not run the
'truncation' tests as part of the normal suite runner. This gets the
tests passing again.
Refs #5024
|
|
Since the tests I was trying to use `truncation` for are now skipped,
remove these exceptions and revert this line back to what it was before
all this mess.
Refs #5024
|
|
Refs #5142
|
|
Just discussed this with Alban. The truncation tests are breaking the
test suite, and I've spent way too long on this already. Take the specs
out of the suite for now until we can come up with a different way to
run these or test this behaviour without breaking everything.
The new task to fix this is #5295.
Refs #5024
|
|
The `truncation: true` strategy wasn't sticking. The config `before`
block only ran once for this test file. Instead of attaching the filter
to the `it` blocks, put it on the `context`. This correctly gets each
test to run in a transaction.
Remove the `truncation: false` filter I had added previously as this
didn't do what I wanted it to: it prevented the `before` block from
running instead of filtering out tests with `truncation: true`.
Refs #5024
|
|
Refs #5142
|
|
After the first `truncation: true` test ran, all tables would be
cleared. This caused errors as our tests rely on a referential like this
existing:
Referential.create(name: 'first')
It also caused problems with `LineReferential` as the `:chouette_line`
factory depends on an existing `LineReferential` associated to the
`first` Referential.
Add the `referentials` and `line_referentials` tables to the exclusion
list when truncating so these tables don't get cleared and the 'first'
records persist across test runs like before.
To prevent errors trying to unnecessarily switch to the 'first'
referential in `truncation: true` tests, disable that functionality by
adding a filter to exclude these tests from the normal transactional
`before(:each)` config block.
Refs #5024
|
|
Refactor these tests to abstract the thread & transaction creation &
handling. Thread creation and joining can now live in one place apart
from the tests, and the tests have an interface to set up concurrent
referential saving.
Thanks to Johan for this refactor.
Refs #5024
|
|
|
|
|
|
(required field)
|
|
|
|
=> Only display the short_id of lines objetids for better UI
|
|
|
|
ReferentialCloningWorker#perform. Refs #5283
|
|
|
|
defined (organisation, name, etc)
|
