| Age | Commit message (Collapse) | Author |
|---|
|
- Add a `kind` attribute
- Hide irrelevant fields in the form
|
|
This determines if the StopArea is commercial or not
The useless fields are hidden in the form for the non-commercials ones
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Johan pointed out
(https://github.com/af83/stif-boiv/commit/cd2892277df0af1e1eaf2373adf0068a77f07a6e)
that these `href`s aren't needed as the action links decorator will
infer them automatically.
Refs #5586
|
|
Seems like the object decorator for `ImportResource` isn't needed here.
It doesn't contain anything except for an empty `action_links` method,
which I'm guessing was to appease the table builder which used to expect
one.
Get rid of that decorator because it doesn't seem to be needed.
Also get rid of the `links` argument to the table builder because we
don't need it any more with the new action links interface.
Refs #5586
|
|
No action links are used on these objects and the decorator isn't being
used for anything else. Seems to me like this collection doesn't need to
be decorated at all. Get rid of the decorator.
Add a `decorates` to `ComplianceCheckSetDecorator` because
http://stif-boiv.dev:3000/workbenches/1/compliance_check_sets/14/executed
causes an uninferrable thing error.
Refs #5586
|
|
Refs #5586
|
|
* Decorate the `ComplianceControl` so we can show the action links from
the decorator in the header.
* Add a `decorates` to get `object_class` to work inside the decorator.
* Define `AF83::Decorator.define_instance_class_method` in order to
enable the `@compliance_control.class.METHOD` calls in the view to
work. Thanks very much to Johan for figuring out a way to do that.
Refs #5586
|
|
I was getting this error:
ActionView::Template::Error (undefined method `split' for nil:NilClass
Did you mean? split_all):
16:
17: / compliance controls without block
18: = render_compliance_control_block
19: = render_compliance_controls(@direct_compliance_controls)
20:
21: / compliance controls with block
22: - if params[:q] && params[:q][:compliance_control_block_id_eq_any].try(:present?)
app/helpers/table_builder_helper.rb:110:in `item_row_class_name'
app/helpers/table_builder_helper.rb:290:in `tbody'
app/helpers/table_builder_helper.rb:97:in `table_builder_2'
app/helpers/compliance_control_sets_helper.rb:79:in `block in render_table_builder'
app/helpers/compliance_control_sets_helper.rb:78:in `render_table_builder'
app/helpers/compliance_control_sets_helper.rb:71:in `block (2 levels) in render_compliance_controls'
app/helpers/compliance_control_sets_helper.rb:70:in `block in render_compliance_controls'
app/helpers/compliance_control_sets_helper.rb:69:in `render_compliance_controls'
app/views/compliance_control_sets/show.html.slim:19:in `_app_views_compliance_control_sets_show_html_slim___3528509151208629266_70279137561480'
The model name wasn't accessible from the view because this collection
is set up in an unorthodox way without a decorated collection.
Got help from Johan, and we ended up using the `model` param passed into
the table builder for this. It looks terrible with `model` all over the
place, but at least it gets us past the problem.
Refs #5586
|
|
Refs #5586
|
|
When I converted this decorator to use the new action links interface, I
inadvertently broke this decorated method. This caused the
http://stif-boiv.dev:3000/workbenches/1/imports/1 page to break. Fix it
by using the `define_instance_method` in `AF83::Decorator`.
Refs #5586
|
|
This is no longer needed thanks to the new action links interface.
Refs #5586
|
|
Subtleties were that the links need to reference `StopArea`s. In
particular, the `edit` link goes to the `StopAreaReferential` path
instead of the referential-StopArea path.
Refs #5586
|
|
Remove the extra `}` from the end of this line as it was a syntax error
and caused the page to break.
Refs #5586
|
|
Refs #5586
|
|
Previously, we weren't correctly adding the HTTP method to the links in
the header. This is because it's called `link_method` in the class. Put
this value in `method`/`data-method` when converting the link to HTML so
that the links work properly.
Discovered this when deactivating and activating stop areas on
http://stif-boiv.dev:3000/stop_area_referentials/1/stop_areas/139429 .
Refs #5586
|
|
This method was overriding classes that were added by `#add_class` in
addition to those added by `#class`. Obviously, the argument to
`#add_class` should be appended to the default.
That seemed like a pain to do, so instead I'm getting rid of the concept
of a default class. Instead, we're going to force all links to use the
template-defined styles for now. That goes in line with Luc's desire to
be more consistent in the links, as he stated yesterday.
Refs #5586
|
|
Move the "Edit" button on the ReferentialNetworks#show page to the top
right and make it white (a "primary" link) to make it consistent with
other pages.
Refs #5586
|
|
We want to be more specific in the naming here and include the name of
the object in the label.
Refs #5586
|
|
Also add a new method `AF83::Decorator.define_instance_method`. Thanks
to Johan for suggesting that and walking me through writing it. This new
method allows us to define methods on the instance decorator. We need
this to preserve the `#bounding_dates` method that was defined in
`PurchaseWindowDecorator`.
Refs #5586
|
|
Refs #5586
|
|
Refs #5586
|
|
Important to add the `action: :index` argument on the table builder in
the `ReferentialLines#show` page so that the gear menu links render
correctly.
Refs #5586
|
|
Need to add a `collection_name` method to
`ReferentialNetworksController` because
`ApplicationController#decorated_collection` can't infer the `Network`
model from the controller name.
Refs #5586
|
|
And remove the "create" link from the gear menu and header links of the
:show page because it didn't make sense there. Leave a "create" link on
the index page though.
Refs #5586
|
|
Instead of checking for an existing class and then setting the class,
provide a method to set a default class when one hasn't been defined.
This does effectively the same thing but moves the condition inside the
method.
Thanks Johan for the suggestion!
Refs #5586
|
|
Also remove the `delete` link because the policy disables it for
everyone (3f5ac4764b859f97f776df565599e312b4584a03,
17e946771afcff10b6165dd3a97b38aa9c06b1f2).
Refs #5586
|
|
Begin the process of converting the `ImportDecorator` to the new action
links interface.
For now, only the "New import" button on the top right of the index page
is converted. The rest of the links are commented out for now and will
be treated in a subsequent commit.
Add a new `#class?` method to `AF83::Decorator::Link` that tells callers
whether a CSS class has been defined on the link. This allows us to
determine whether we should force a class or use the one provided in
`_page_header.html.slim`.
We need a way to specify the class of the link in the header because the
"New import" button is supposed to be blue (`.btn-primary`), but the
default for primary action links is white.
Refs #5586
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Plus:
- Fix a bug on `html_options` in AF83::Decorator::Link
- Add a `t` helper in AF83::Decorator to handle i18n
|
|
|
|
- Remove ApiKeyDecorator (never used)
- Migrate CalendarDecorator
- Migrate CompanyDecorator
- Migrate TimeTableDecorator
|
|
|
|
|
|
And remove snapshots (we don't need it anymore)
|
|
We now have a ModelDecorator and an "instance" decorator, all in the
same file, with the same API.
|
|
Used it in Lines#index and Lines#show, probably broke everything else
|
|
As well as the `to_html` method
|
|
- Implement new API
- Migrate the LineDecorator
- ensure no change on the "lines/index" view
|
