Refs: #4189@2h; Iimplementation of Chouette::Route#duplicate & Chouette::StopPoint#duplicate

   With the following unspecified behaviour concerning `objectid` and `object_version`

   - The duplicated Route objectid is passed into Route#duplicate
   - The duplicated StopPoint objectids are constructed from the source's objectids (parts 2 & 3) and the route's objectid (part 1)
   - the duplicated Route object_version equals the source's one

3 files changed, 55 insertions, 15 deletions

diff --git a/spec/models/chouette/route/route_duplication_spec.rb b/spec/models/chouette/route/route_duplication_spec.rb
index fe8d5e444..6168d1e38 100644
--- a/spec/models/chouette/route/route_duplication_spec.rb
+++ b/spec/models/chouette/route/route_duplication_spec.rb
@@ -5,27 +5,29 @@ StopPoint = Chouette::StopPoint
 
 RSpec.describe Route do
 
-  let( :route ){ create :route }
+  let!( :route ){ create :route }
+  let( :new_objectid ){ [SecureRandom.hex, 'Route', SecureRandom.hex].join(':') }
 
   context 'duplicates' do 
     describe 'a route' do
       it 'by creating a new one' do
-        expect{ route.duplicate }.to change{Route.count}.by(1)
+        expect{ route.duplicate new_objectid }.to change{Route.count}.by(1)
       end
       it 'with the same values' do
-        expect( values_for_create(Route.last) ).to eq( values_for_create( route ) )
+        route.duplicate new_objectid
+        expect( values_for_create(Route.last, except: %w{objectid}) ).to eq( values_for_create( route, except: %w{objectid} ) )
       end
 
-    it 'and also duplicating its stop points' do
-      expect{ route.dublicate }.to change{StopPoint.count}.by(route.stop_points.count)
-    end
-    it 'but leaving the stop areas alone' do
-      expect{ route.duplicate }.not_to change{StopArea.count}
-    end
-    it "which are still accessible by the new route though" do
-      expect( route.duplicate.stop_areas ).to eq(route.stop_areas)
-    end
+      it 'and also duplicating its stop points' do
+        expect{ route.duplicate new_objectid }.to change{StopPoint.count}.by(route.stop_points.count)
+      end
+      it 'but leaving the stop areas alone' do
+        expect{ route.duplicate new_objectid }.not_to change{StopArea.count}
+      end
+      it "which are still accessible by the new route though" do
+        expect( route.duplicate( new_objectid ).stop_areas.pluck(:id) ).to eq(route.stop_areas.pluck(:id))
+      end
     end
   end
-  
+
 end
diff --git a/spec/models/chouette/stop_point_spec.rb b/spec/models/chouette/stop_point_spec.rb
index 212c32e1a..c43774085 100644
--- a/spec/models/chouette/stop_point_spec.rb
+++ b/spec/models/chouette/stop_point_spec.rb
@@ -1,6 +1,7 @@
-require 'spec_helper'
+# From Chouette import what we need ™
+StopPoint = Chouette::StopPoint
 
-describe Chouette::StopPoint, :type => :model do
+describe StopPoint, :type => :model do
   let!(:vehicle_journey) { create(:vehicle_journey)}
   subject { Chouette::Route.find( vehicle_journey.route_id).stop_points.first }
 
@@ -38,4 +39,29 @@ describe Chouette::StopPoint, :type => :model do
       expect(jpsp_stop_point_ids(@vehicle.journey_pattern_id)).not_to include(@stop_point.id)
     end
   end
+
+  describe '#duplicate' do
+    let!( :new_route ){ create :route, objectid: 'newroute:Route:1' }
+
+    it 'creates a new instance' do
+      expect{ subject.duplicate(for_route: new_route) }.to change{ StopPoint.count }.by(1)
+    end
+    it 'new instance has a new route' do
+      expect(subject.duplicate(for_route: new_route).route).to eq(new_route)
+    end
+    it 'and old stop_area' do
+      expect(subject.duplicate(for_route: new_route).stop_area).to eq(subject.stop_area)
+    end
+    it 'has an objectid, related to the new route' do
+      new_stop_point = subject.duplicate(for_route: new_route)
+
+      old_objectid_parts   = subject.objectid.split(':')
+      new_objectid_parts   = new_stop_point.objectid.split(':')
+      route_object_id_part = new_route.objectid.split(':').first
+
+      expect(new_objectid_parts.first).to  eq(route_object_id_part)
+      expect(new_objectid_parts.second).to eq(old_objectid_parts.second)
+      expect(new_objectid_parts.third).to  eq(old_objectid_parts.third)
+    end
+  end
 end
diff --git a/spec/support/helpers/model_compare_helpers.rb b/spec/support/helpers/model_compare_helpers.rb
new file mode 100644
index 000000000..97e26f300
--- /dev/null
+++ b/spec/support/helpers/model_compare_helpers.rb
@@ -0,0 +1,12 @@
+module Support::ModelCompareHelpers
+  
+  def values_for_create obj, except: []
+    keys = obj.attributes.keys - except - %w{id created_at updated_at}
+    obj.attributes.slice(*keys)
+  end
+
+end
+
+RSpec.configure do | rspec |
+  rspec.include Support::ModelCompareHelpers, type: :model
+end