Merge pull request #291 from af83/4758-cron-job-to-finalise-compliance_check_set-validations--

4758 cron job to finalise compliance check set validations  

2 files changed, 40 insertions, 8 deletions

diff --git a/spec/models/compliance_check_spec.rb b/spec/models/compliance_check_spec.rb
index f83d78c29..ffa59245c 100644
--- a/spec/models/compliance_check_spec.rb
+++ b/spec/models/compliance_check_spec.rb
@@ -15,4 +15,36 @@ RSpec.describe ComplianceCheck, type: :model do
   it { should validate_presence_of :name }
   it { should validate_presence_of :code }
   it { should validate_presence_of :origin_code }
+
+  describe ".abort_old" do
+    it "changes check sets older than 4 hours to aborted" do
+      Timecop.freeze(Time.now) do
+        old_check_set = create(
+          :compliance_check_set,
+          status: 'pending',
+          created_at: 4.hours.ago - 1.minute
+        )
+        current_check_set = create(:compliance_check_set, status: 'pending')
+
+        ComplianceCheckSet.abort_old
+
+        expect(current_check_set.reload.status).to eq('pending')
+        expect(old_check_set.reload.status).to eq('aborted')
+      end
+    end
+
+    it "doesn't work on check sets with a `finished_status`" do
+      Timecop.freeze(Time.now) do
+        check_set = create(
+          :compliance_check_set,
+          status: 'successful',
+          created_at: 4.hours.ago - 1.minute
+        )
+
+        ComplianceCheckSet.abort_old
+
+        expect(check_set.reload.status).to eq('successful')
+      end
+    end
+  end
 end
diff --git a/spec/services/parent_import_notifier_spec.rb b/spec/services/parent_notifier_spec.rb
index 3ab505f88..ecf508fcd 100644
--- a/spec/services/parent_import_notifier_spec.rb
+++ b/spec/services/parent_notifier_spec.rb
@@ -1,4 +1,4 @@
-RSpec.describe ParentImportNotifier do
+RSpec.describe ParentNotifier do
   let(:workbench_import) { create(:workbench_import) }
 
   describe ".notify_when_finished" do
@@ -20,7 +20,7 @@ RSpec.describe ParentImportNotifier do
         expect(netex_import).to receive(:notify_parent)
       end
 
-      ParentImportNotifier.notify_when_finished(netex_imports)
+      ParentNotifier.new(Import).notify_when_finished(netex_imports)
     end
 
     it "doesn't call #notify_parent if its `notified_parent_at` is set" do
@@ -33,11 +33,11 @@ RSpec.describe ParentImportNotifier do
 
       expect(netex_import).not_to receive(:notify_parent)
 
-      ParentImportNotifier.notify_when_finished
+      ParentNotifier.new(Import).notify_when_finished
     end
   end
 
-  describe ".imports_pending_notification" do
+  describe ".objects_pending_notification" do
     it "includes imports with a parent and `notified_parent_at` unset" do
       netex_import = create(
         :netex_import,
@@ -47,7 +47,7 @@ RSpec.describe ParentImportNotifier do
       )
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to eq([netex_import])
     end
 
@@ -55,7 +55,7 @@ RSpec.describe ParentImportNotifier do
       create(:import, parent: nil)
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to be_empty
     end
 
@@ -70,7 +70,7 @@ RSpec.describe ParentImportNotifier do
       end
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to be_empty
     end
 
@@ -83,7 +83,7 @@ RSpec.describe ParentImportNotifier do
       )
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to be_empty
     end
   end