Workbench: Ensure `output` attr is initialised when creating workbench

Since all `Workbench`es must have an associated `ReferentialSuite` via
`output`, if none is provided when creating a new `Workbench`, create
one automatically.

This is done in a `before_validation` callback (eck, AR callbacks).

In order for our prior 'should validate_presence_of' test to continue to
work, we have to work around the new callback, otherwise Shoulda can't
set `output` to `nil` to run its expectation and the test fails.

Refs #3520

1 files changed, 10 insertions, 0 deletions

diff --git a/app/models/workbench.rb b/app/models/workbench.rb
index b4852b9d5..fe4e6cce1 100644
--- a/app/models/workbench.rb
+++ b/app/models/workbench.rb
@@ -19,6 +19,8 @@ class Workbench < ActiveRecord::Base
   has_many :referentials
   has_many :referential_metadatas, through: :referentials, source: :metadatas
 
+  before_validation :initialize_output
+
 
   def all_referentials
     if line_ids.empty?
@@ -28,4 +30,12 @@ class Workbench < ActiveRecord::Base
     end
   end
 
+  private
+
+  def initialize_output
+    # Don't reset `output` if it's already initialised
+    return if !output.nil?
+
+    self.output = ReferentialSuite.create
+  end
 end