Import: Make #child_change work

The `#child_change` method should update the current import (the parent)
with a 'failed' or 'successful' status depending on the status of the
child passed in.

If the child has a failure status, the parent import should be updated
to failed. If the import is `#ready?`, that tells us that all children
have called `#child_change` without any problems, and we can update the
parent's status to be successful. THAT PARAGRAPH IS WRONG. We could have
`#ready?` with failed children. NEED TO UPDATE TO SUPPORT THAT.

Add a method that describes the possible "failing" statuses. These are
the ones that will cause 'failed' to be set on the parent.

Refs #3509, #3511

1 files changed, 9 insertions, 0 deletions

diff --git a/app/models/import.rb b/app/models/import.rb
index 46de0d727..c7f6d99df 100644
--- a/app/models/import.rb
+++ b/app/models/import.rb
@@ -18,6 +18,11 @@ class Import < ActiveRecord::Base
   end
 
   def child_change(child)
+    if failing_statuses.include?(child.status)
+     return update(status: 'failed')
+    end
+
+    return update(status: 'successful') if ready?
   end
 
   def ready?
@@ -30,4 +35,8 @@ class Import < ActiveRecord::Base
     self.token_download = SecureRandom.urlsafe_base64
     self.status = Import.status.new
   end
+
+  def failing_statuses
+    %i(failed aborted canceled).flat_map { |status| [status, status.to_s] }
+  end
 end