diff options
| author | Alban Peignier | 2018-05-10 21:39:38 +0200 | 
|---|---|---|
| committer | GitHub | 2018-05-10 21:39:38 +0200 | 
| commit | 093599f1c2e75ba2a4e3e9e8a6aa2cf665919886 (patch) | |
| tree | d6488fa756d37198f0b50c93e7ddf8e23d3ee46e /app | |
| parent | fdde7e05c29738356abe488a1b80ade098ef269d (diff) | |
| parent | 6f624a7ca68600e93aae71f98182dfeb8c082674 (diff) | |
| download | chouette-core-093599f1c2e75ba2a4e3e9e8a6aa2cf665919886.tar.bz2 | |
Merge pull request #558 from af83/6960-workgroup-edition
Workgroup edition. Fixes #6960
Diffstat (limited to 'app')
34 files changed, 599 insertions, 100 deletions
| diff --git a/app/assets/stylesheets/application.sass b/app/assets/stylesheets/application.sass index 3f8467efe..632ade179 100644 --- a/app/assets/stylesheets/application.sass +++ b/app/assets/stylesheets/application.sass @@ -21,3 +21,6 @@  @import 'modules/import_messages'  @import 'flag-icon' + +span.fa + span +  margin-left: 0.2em diff --git a/app/controllers/import_resources_controller.rb b/app/controllers/import_resources_controller.rb index 1535fd171..46f8f0337 100644 --- a/app/controllers/import_resources_controller.rb +++ b/app/controllers/import_resources_controller.rb @@ -24,6 +24,15 @@ class ImportResourcesController < ChouetteController      @import_resources ||= parent.resources    end +  def resource +    @import ||= Import::Base.find params[:import_id] +    @import_resource ||= begin +      import_resource = Import::Resource.find params[:id] +      raise ActiveRecord::RecordNotFound unless import_resource.import == @import +      import_resource +    end +  end +    private    def decorate_import_resources(import_resources) diff --git a/app/controllers/imports_controller.rb b/app/controllers/imports_controller.rb index 8d7a723a0..b98d7da8d 100644 --- a/app/controllers/imports_controller.rb +++ b/app/controllers/imports_controller.rb @@ -4,6 +4,7 @@ class ImportsController < ChouetteController    include IevInterfaces    skip_before_action :authenticate_user!, only: [:download]    defaults resource_class: Import::Base, collection_name: 'imports', instance_name: 'import' +  before_action :notify_parents    def download      if params[:token] == resource.token_download @@ -18,7 +19,7 @@ class ImportsController < ChouetteController    def index_model      Import::Workbench    end -   +    def build_resource      @import ||= Import::Workbench.new(*resource_params) do |import|        import.workbench = parent @@ -43,4 +44,10 @@ class ImportsController < ChouetteController        }      )    end + +  def notify_parents +    if Rails.env.development? +      ParentNotifier.new(Import::Base).notify_when_finished +    end +  end  end diff --git a/app/controllers/workbenches_controller.rb b/app/controllers/workbenches_controller.rb index 43415ff60..d4dfdebe3 100644 --- a/app/controllers/workbenches_controller.rb +++ b/app/controllers/workbenches_controller.rb @@ -42,7 +42,7 @@ class WorkbenchesController < ChouetteController    private    def workbench_params -    params.require(:workbench).permit(:import_compliance_control_set_id, :merge_compliance_control_set_id) +    params.require(:workbench).permit(compliance_control_set_ids: @workbench.workgroup.compliance_control_sets_by_workbench.keys)    end    def resource diff --git a/app/controllers/workgroups_controller.rb b/app/controllers/workgroups_controller.rb new file mode 100644 index 000000000..3acea248d --- /dev/null +++ b/app/controllers/workgroups_controller.rb @@ -0,0 +1,13 @@ +class WorkgroupsController < ChouetteController +  defaults resource_class: Workgroup + +  include PolicyChecker + +  def show +    redirect_to "/" +  end + +  def workgroup_params +    params[:workgroup].permit(workbenches_attributes: [:id, compliance_control_set_ids: @workgroup.compliance_control_sets_by_workgroup.keys]) +  end +end diff --git a/app/helpers/exports_helper.rb b/app/helpers/exports_helper.rb index 2e784ad35..f30a80ed9 100644 --- a/app/helpers/exports_helper.rb +++ b/app/helpers/exports_helper.rb @@ -17,7 +17,7 @@ module ExportsHelper        message.message_attributes["text"]      else        t([message.class.name.underscore.gsub('/', '_').pluralize, message.message_key].join('.'), message.message_attributes&.symbolize_keys || {}) -    end +    end.html_safe    end    def fields_for_export_task_format(form) diff --git a/app/helpers/imports_helper.rb b/app/helpers/imports_helper.rb index 140660153..f06d77eca 100644 --- a/app/helpers/imports_helper.rb +++ b/app/helpers/imports_helper.rb @@ -2,33 +2,49 @@  module ImportsHelper    # Import statuses helper -  def import_status(status) -    if %w[new running pending].include? status +  def import_status(status, verbose: false, default_status: nil) +    status ||= default_status +    return unless status +    status = status.to_s.downcase +    out = if %w[new running pending].include? status        content_tag :span, '', class: "fa fa-clock-o"      else        cls =''        cls = 'success' if status == 'successful' +      cls = 'success' if status == 'ok'        cls = 'warning' if status == 'warning' -      cls = 'danger' if %w[failed aborted canceled].include? status +      cls = 'danger' if %w[failed aborted canceled error].include? status        content_tag :span, '', class: "fa fa-circle text-#{cls}"      end +    if verbose +      out += content_tag :span do +        txt = "imports.status.#{status}".t(fallback: "") +      end +    end +    out    end    # Compliance check set messages    def bootstrap_class_for_message_criticity message_criticity -    case message_criticity -      when "error" +    case message_criticity.downcase +      when "error", "aborted"          "alert alert-danger"        when "warning"          "alert alert-warning"        when "info"          "alert alert-info" +      when "ok", "success" +        "alert alert-success"        else          message_criticity.to_s      end    end +  def import_message_content message +    export_message_content message +  end +    ##############################    #      TO CLEAN!!!    ############################## diff --git a/app/helpers/table_builder_helper.rb b/app/helpers/table_builder_helper.rb index e2aa2e9ea..0b24a9c05 100644 --- a/app/helpers/table_builder_helper.rb +++ b/app/helpers/table_builder_helper.rb @@ -153,7 +153,17 @@ module TableBuilderHelper              i = columns.index(column)              if overhead[i].blank? -              if (i > 0) && (overhead[i - 1][:width] > 1) +              prev = nil +              if i > 0 +                (i-1..0).each do |j| +                  o = overhead[j] +                  if (j + o[:width].to_i) >= i +                    prev = o +                    break +                  end +                end +              end +              if prev                  clsArrayH = overhead[i - 1][:cls].split                  hcont << content_tag(:th, build_column_header( @@ -225,7 +235,7 @@ module TableBuilderHelper          if column.linkable?            path = column.link_to(item) -          link = value.present? && path.present? ? link_to(value, path) : "" +          link = value.present? && path.present? ? link_to(value, path) : value            if overhead.empty?              bcont << content_tag(:td, link, title: 'Voir', class: extra_class) @@ -234,7 +244,17 @@ module TableBuilderHelper              i = columns.index(column)              if overhead[i].blank? -              if (i > 0) && (overhead[i - 1][:width] > 1) +              prev = nil +              if i > 0 +                (i-1..0).each do |j| +                  o = overhead[j] +                  if (j + o[:width].to_i) >= i +                    prev = o +                    break +                  end +                end +              end +              if prev                  clsArrayAlt = overhead[i - 1][:cls].split                  bcont << content_tag(:td, link, title: 'Voir', class: td_cls(clsArrayAlt, extra_class)) diff --git a/app/models/compliance_check_set.rb b/app/models/compliance_check_set.rb index 8b1dbdd68..f29ff4de5 100644 --- a/app/models/compliance_check_set.rb +++ b/app/models/compliance_check_set.rb @@ -26,6 +26,10 @@ class ComplianceCheckSet < ApplicationModel      %w(successful failed warning aborted canceled)    end +  def successful? +    status.to_s == "successful" +  end +    def self.abort_old      where(        'created_at < ? AND status NOT IN (?)', @@ -68,6 +72,11 @@ class ComplianceCheckSet < ApplicationModel      end      update attributes +    import_resource&.next_step +  end + +  def import_resource +    referential&.import_resources.main_resources.last    end diff --git a/app/models/concerns/iev_interfaces/resource.rb b/app/models/concerns/iev_interfaces/resource.rb index 7f8c3eefd..254f88a33 100644 --- a/app/models/concerns/iev_interfaces/resource.rb +++ b/app/models/concerns/iev_interfaces/resource.rb @@ -4,6 +4,24 @@ module IevInterfaces::Resource    included do      extend Enumerize      enumerize :status, in: %i(OK ERROR WARNING IGNORED), scope: true -    validates_presence_of :name, :resource_type, :reference +    validates_presence_of :name, :resource_type +  end + +  def update_status_from_importer importer_status +    self.update status: status_from_importer(importer_status) +  end + +  def status_from_importer importer_status +    return nil unless importer_status.present? +    { +      new: nil, +      pending: nil, +      successful: :OK, +      warning: :WARNING, +      failed: :ERROR, +      running: nil, +      aborted: :ERROR, +      canceled: :ERROR +    }[importer_status.to_sym]    end  end diff --git a/app/models/concerns/iev_interfaces/task.rb b/app/models/concerns/iev_interfaces/task.rb index 6be33734b..e40808009 100644 --- a/app/models/concerns/iev_interfaces/task.rb +++ b/app/models/concerns/iev_interfaces/task.rb @@ -31,6 +31,16 @@ module IevInterfaces::Task      before_save :initialize_fields, on: :create      after_save :notify_parent + +    status.values.each do |s| +      define_method "#{s}!" do +        update status: s +      end + +      define_method "#{s}?" do +        status&.to_s == s +      end +    end    end    module ClassMethods @@ -56,13 +66,14 @@ module IevInterfaces::Task    end    def notify_parent -    return unless self.class.finished_statuses.include?(status) +    return false unless self.class.finished_statuses.include?(status) -    return unless parent.present? -    return if notified_parent_at +    return false unless parent.present? +    return false if notified_parent_at      parent.child_change      update_column :notified_parent_at, Time.now +    true    end    def children_succeedeed @@ -94,6 +105,10 @@ module IevInterfaces::Task      update attributes    end +  def successful? +    status.to_s == "successful" +  end +    def child_change      return if self.class.finished_statuses.include?(status)      update_status @@ -112,9 +127,14 @@ module IevInterfaces::Task    def call_boiv_iev      Rails.logger.error("Begin IEV call for import") + +    # Java code expects tasks in NEW status +    # Don't change status before calling iev +      Net::HTTP.get iev_callback_url      Rails.logger.error("End IEV call for import")    rescue Exception => e +    aborted!      logger.error "IEV server error : #{e.message}"      logger.error e.backtrace.inspect    end diff --git a/app/models/import/base.rb b/app/models/import/base.rb index f98e359d4..dcd710e58 100644 --- a/app/models/import/base.rb +++ b/app/models/import/base.rb @@ -32,8 +32,13 @@ class Import::Base < ApplicationModel      Rails.logger.info "update_referentials for #{inspect}"      return unless self.class.finished_statuses.include?(status) -    children.each do |import| -      import.referential.update(ready: true) if import.referential +    # We treat all created referentials in a batch +    # If a single fails, we consider they all failed +    # Ohana means family ! +    if self.successful? +      children.map(&:referential).compact.each &:active! +    else +      children.map(&:referential).compact.each &:failed!      end    end diff --git a/app/models/import/gtfs.rb b/app/models/import/gtfs.rb index ceb849bd8..9dab11f0e 100644 --- a/app/models/import/gtfs.rb +++ b/app/models/import/gtfs.rb @@ -1,19 +1,37 @@  class Import::Gtfs < Import::Base    after_commit :launch_worker, :on => :create +  after_commit do +    main_resource.update_status_from_importer self.status +    true +  end +    def launch_worker      GtfsImportWorker.perform_async id    end +  def main_resource +    @resource ||= parent.resources.find_or_create_by(name: self.name, resource_type: "referential", reference: self.name) if parent +  end + +  def next_step +    main_resource&.next_step +  end + +  def create_message args +    (main_resource || self).messages.build args +  end +    def import      update status: 'running', started_at: Time.now      import_without_status      update status: 'successful', ended_at: Time.now -    referential&.ready! +    referential&.active!    rescue Exception => e      update status: 'failed', ended_at: Time.now      Rails.logger.error "Error in GTFS import: #{e} #{e.backtrace.join('\n')}" +    create_message criticity: :error, message_key: :full_text, message_attributes: {text: e.message}      referential&.failed!    ensure      notify_parent @@ -35,6 +53,7 @@ class Import::Gtfs < Import::Base        workbench_id: workbench.id,        metadatas: [referential_metadata]      ) +    main_resource.update referential: referential if main_resource    end    def referential_metadata @@ -131,17 +150,21 @@ class Import::Gtfs < Import::Base    end    def import_agencies +    count = 0      Chouette::Company.transaction do        source.agencies.each do |agency|          company = line_referential.companies.find_or_initialize_by(registration_number: agency.id)          company.attributes = { name: agency.name }          save_model company +        count += 1        end      end +    create_message criticity: "info", message_key: "gtfs.agencies.imported", message_attributes: {count: count}    end    def import_stops +    count = 0      Chouette::StopArea.transaction do        source.stops.each do |stop|          stop_area = stop_area_referential.stop_areas.find_or_initialize_by(registration_number: stop.id) @@ -155,11 +178,14 @@ class Import::Gtfs < Import::Base          # TODO correct default timezone          save_model stop_area +        count += 1        end +      create_message criticity: "info", message_key: "gtfs.stops.imported", message_attributes: {count: count}      end    end    def import_routes +    count = 0      Chouette::Line.transaction do        source.routes.each do |route|          line = line_referential.lines.find_or_initialize_by(registration_number: route.id) @@ -178,7 +204,9 @@ class Import::Gtfs < Import::Base          line.url = route.url          save_model line +        count += 1        end +      create_message criticity: "info", message_key: "gtfs.routes.imported", message_attributes: {count: count}      end    end @@ -187,6 +215,7 @@ class Import::Gtfs < Import::Base    end    def import_trips +    count = 0      source.trips.each_slice(100) do |slice|        slice.each do |trip|          Chouette::Route.transaction do @@ -205,18 +234,20 @@ class Import::Gtfs < Import::Base            vehicle_journey = journey_pattern.vehicle_journeys.build route: route            vehicle_journey.published_journey_name = trip.headsign.presence || trip.id            save_model vehicle_journey +          count += 1            time_table = referential.time_tables.find_by(id: time_tables_by_service_id[trip.service_id]) if time_tables_by_service_id[trip.service_id]            if time_table              vehicle_journey.time_tables << time_table            else -            messages.create! criticity: "warning", message_key: "gtfs.trips.unkown_service_id", message_attributes: {service_id: trip.service_id} +            create_message criticity: "warning", message_key: "gtfs.trips.unkown_service_id", message_attributes: {service_id: trip.service_id}            end            vehicle_journey_by_trip_id[trip.id] = vehicle_journey.id          end        end      end +    create_message criticity: "info", message_key: "gtfs.trips.imported", message_attributes: {count: count}    end    def import_stop_times @@ -262,6 +293,7 @@ class Import::Gtfs < Import::Base    end    def import_calendars +    count = 0      source.calendars.each_slice(500) do |slice|        Chouette::TimeTable.transaction do          slice.each do |calendar| @@ -272,11 +304,13 @@ class Import::Gtfs < Import::Base            time_table.periods.build period_start: calendar.start_date, period_end: calendar.end_date            save_model time_table +          count += 1            time_tables_by_service_id[calendar.service_id] = time_table.id          end        end      end +    create_message criticity: "info", message_key: "gtfs.calendars.imported", message_attributes: {count: count}    end    def import_calendar_dates @@ -301,10 +335,10 @@ class Import::Gtfs < Import::Base    end    def notify_parent -    return unless parent.present? -    return if notified_parent_at -    parent.child_change -    update_column :notified_parent_at, Time.now +    if super +      main_resource.update_status_from_importer self.status +      next_step +    end    end  end diff --git a/app/models/import/netex.rb b/app/models/import/netex.rb index 49554ee90..b4422328c 100644 --- a/app/models/import/netex.rb +++ b/app/models/import/netex.rb @@ -2,16 +2,39 @@ require 'net/http'  class Import::Netex < Import::Base    before_destroy :destroy_non_ready_referential -  after_commit :call_iev_callback, on: :create +  after_commit do +    main_resource.update_status_from_importer self.status +    true +  end    before_save do -    self.status = 'aborted' unless referential      self.referential&.failed! if self.status == 'aborted' || self.status == 'failed'    end    validates_presence_of :parent +  def main_resource +    @resource ||= parent.resources.find_or_create_by(name: self.name, resource_type: "referential", reference: self.name) +  end + +  def notify_parent +    if super +      main_resource.update_status_from_importer self.status +      next_step +    end +  end + +  def next_step +    main_resource.next_step +  end + +  def create_message args +    main_resource.messages.create args +  end +    def create_with_referential! +    save unless persisted? +      self.referential =        Referential.new(          name: self.name, @@ -20,15 +43,37 @@ class Import::Netex < Import::Base          metadatas: [referential_metadata]        )      self.referential.save -    if self.referential.invalid? + +    if self.referential.valid? +      main_resource.update referential: referential +      call_iev_callback +      save! +    else        Rails.logger.info "Can't create referential for import #{self.id}: #{referential.inspect} #{referential.metadatas.inspect} #{referential.errors.messages}" -      if referential.metadatas.all?{|m| m.line_ids.present? && m.line_ids.empty?} -        parent.messages.create criticity: :error, message_key: "referential_creation_missing_lines", message_attributes: {referential_name: referential.name} + +      if referential.metadatas.all?{|m| m.line_ids.empty? && m.line_ids.empty?} +        create_message criticity: :error, message_key: "referential_creation_missing_lines", message_attributes: {referential_name: referential.name} +      elsif (overlapped_referential_ids = referential.overlapped_referential_ids).any? +        overlapped = Referential.find overlapped_referential_ids.last +        create_message( +          criticity: :error, +          message_key: "referential_creation_overlapping_existing_referential", +          message_attributes: { +            referential_name: referential.name, +            overlapped_name: overlapped.name, +            overlapped_url:  Rails.application.routes.url_helpers.referential_path(overlapped) +          } +        )        else -        parent.messages.create criticity: :error, message_key: "referential_creation", message_attributes: {referential_name: referential.name} +        create_message( +          criticity: :error, +          message_key: "referential_creation", +          message_attributes: {referential_name: referential.name}, +          resource_attributes: referential.errors.messages +        )        end -    else -      save! +      self.referential = nil +      aborted!      end    end @@ -55,6 +100,7 @@ class Import::Netex < Import::Base          metadata.periodes = frame.periods          line_objectids = frame.line_refs.map { |ref| "STIF:CODIFLIGNE:Line:#{ref}" } +        create_message criticity: :info, message_key: "referential_creation_lines_found", message_attributes: {line_objectids: line_objectids.to_sentence}          metadata.line_ids = workbench.lines.where(objectid: line_objectids).pluck(:id)        end      end diff --git a/app/models/import/resource.rb b/app/models/import/resource.rb index 1951daacd..43690755d 100644 --- a/app/models/import/resource.rb +++ b/app/models/import/resource.rb @@ -4,5 +4,49 @@ class Import::Resource < ApplicationModel    include IevInterfaces::Resource    belongs_to :import, class_name: Import::Base +  belongs_to :referential    has_many :messages, class_name: "Import::Message", foreign_key: :resource_id + +  scope :main_resources, ->{ where(resource_type: "referential") } + +  def root_import +    import = self.import +    import = import.parent while import.parent +    import +  end + +  def next_step +    if root_import.class == Import::Workbench + +      return unless netex_import&.successful? + +      workbench.workgroup.import_compliance_control_sets.map do |key, label| +        next unless (control_set = workbench.compliance_control_set(key)).present? +        compliance_check_set = workbench_import_check_set key +        if compliance_check_set.nil? +          ComplianceControlSetCopyWorker.perform_async control_set.id, referential_id, root_import.class.name, root_import.id +        end +      end +    end +  end + +  def workbench +    import.workbench +  end + +  def workgroup +    workbench.workgroup +  end + +  def netex_import +    return unless self.resource_type == "referential" +    import.children.where(name: self.reference).last +  end + +  def workbench_import_check_set key +    return unless referential.present? +    control_set = referential.workbench.compliance_control_set(key) +    return unless control_set.present? +    referential.compliance_check_sets.where(compliance_control_set_id: control_set.id, referential_id: referential_id).last +  end  end diff --git a/app/models/import/workbench.rb b/app/models/import/workbench.rb index 124b9b0d8..95d23fe5b 100644 --- a/app/models/import/workbench.rb +++ b/app/models/import/workbench.rb @@ -9,14 +9,18 @@ class Import::Workbench < Import::Base      end    end +  # def main_resource +  #   @resource ||= resources.find_or_create_by(name: self.name, resource_type: "workbench_import") +  # end +    def import_gtfs      update_column :status, 'running'      update_column :started_at, Time.now -    Import::Gtfs.create! parent_id: self.id, workbench: workbench, file: File.new(file.path), name: "Import GTFS", creator: "Web service" +    Import::Gtfs.create! parent_type: self.class.name, parent_id: self.id, workbench: workbench, file: File.new(file.path), name: "Import GTFS", creator: "Web service" -    update_column :status, 'successful' -    update_column :ended_at, Time.now +    # update_column :status, 'successful' +    # update_column :ended_at, Time.now    rescue Exception => e      Rails.logger.error "Error while processing GTFS file: #{e}" diff --git a/app/models/referential.rb b/app/models/referential.rb index 792353a73..0c6e71d47 100644 --- a/app/models/referential.rb +++ b/app/models/referential.rb @@ -26,6 +26,7 @@ class Referential < ApplicationModel    has_one :user    has_many :api_keys, class_name: 'Api::V1::ApiKey', dependent: :destroy +  has_many :import_resources, class_name: 'Import::Resource', dependent: :destroy    belongs_to :organisation    validates_presence_of :organisation @@ -398,7 +399,7 @@ class Referential < ApplicationModel      query = "select distinct(public.referential_metadata.referential_id) FROM public.referential_metadata, unnest(line_ids) line, LATERAL unnest(periodes) period      WHERE public.referential_metadata.referential_id -    IN (SELECT public.referentials.id FROM public.referentials WHERE referentials.workbench_id = #{workbench_id} and referentials.archived_at is null and referentials.referential_suite_id is null #{not_myself}) +    IN (SELECT public.referentials.id FROM public.referentials WHERE referentials.workbench_id = #{workbench_id} and referentials.archived_at is null and referentials.referential_suite_id is null #{not_myself} AND referentials.failed_at IS NULL)      AND line in (#{line_ids.join(',')}) and (#{periods_query});"      self.class.connection.select_values(query).map(&:to_i) diff --git a/app/models/workbench.rb b/app/models/workbench.rb index 1c54e8904..1bca91c56 100644 --- a/app/models/workbench.rb +++ b/app/models/workbench.rb @@ -51,6 +51,20 @@ class Workbench < ApplicationModel      where(name: DEFAULT_WORKBENCH_NAME).last    end +  # XXX +  # def import_compliance_control_set +  #   import_compliance_control_set_id && ComplianceControlSet.find(import_compliance_control_set_id) +  # end + +  def compliance_control_set key +    id = (owner_compliance_control_set_ids || {})[key.to_s] +    id.present? && ComplianceControlSet.find(id) +  end + +  def compliance_control_set_ids=(compliance_control_set_ids) +    self.owner_compliance_control_set_ids = (owner_compliance_control_set_ids || {}).merge compliance_control_set_ids +  end +    private    def initialize_output diff --git a/app/models/workgroup.rb b/app/models/workgroup.rb index 3e8409634..6bb03c7fa 100644 --- a/app/models/workgroup.rb +++ b/app/models/workgroup.rb @@ -1,6 +1,7 @@  class Workgroup < ApplicationModel    belongs_to :line_referential    belongs_to :stop_area_referential +  belongs_to :owner, class_name: "Organisation"    has_many :workbenches    has_many :calendars @@ -16,6 +17,8 @@ class Workgroup < ApplicationModel    has_many :custom_fields +  accepts_nested_attributes_for :workbenches +    def custom_fields_definitions      Hash[*custom_fields.map{|cf| [cf.code, cf]}.flatten]    end @@ -23,4 +26,35 @@ class Workgroup < ApplicationModel    def has_export? export_name      export_types.include? export_name    end + +  def all_compliance_control_sets +    %i(after_import +      after_import_by_workgroup +      before_merge +      before_merge_by_workgroup +      after_merge +      after_merge_by_workgroup +      automatic_by_workgroup +    ) +  end + +  def compliance_control_sets_by_workgroup +    compliance_control_sets_labels all_compliance_control_sets.grep(/by_workgroup$/) +  end + +  def compliance_control_sets_by_workbench +    compliance_control_sets_labels all_compliance_control_sets.grep_v(/by_workgroup$/) +  end + +  def import_compliance_control_sets +    compliance_control_sets_labels all_compliance_control_sets.grep(/^after_import/) +  end + +  private +  def compliance_control_sets_labels(keys) +    keys.inject({}) do |h, k| +      h[k] = "workgroups.compliance_control_sets.#{k}".t.capitalize +      h +    end +  end  end diff --git a/app/policies/workbench_policy.rb b/app/policies/workbench_policy.rb index 7b925e91a..9f2279c38 100644 --- a/app/policies/workbench_policy.rb +++ b/app/policies/workbench_policy.rb @@ -6,6 +6,6 @@ class WorkbenchPolicy < ApplicationPolicy    end    def update? -    true +    user.has_permission?('workbenches.update')    end  end diff --git a/app/policies/workgroup_policy.rb b/app/policies/workgroup_policy.rb new file mode 100644 index 000000000..01914bb51 --- /dev/null +++ b/app/policies/workgroup_policy.rb @@ -0,0 +1,19 @@ +class WorkgroupPolicy < ApplicationPolicy +  class Scope < Scope +    def resolve +      scope +    end +  end + +  def create? +    false +  end + +  def desrtroy? +    false +  end + +  def update? +    record.owner == user.organisation +  end +end diff --git a/app/views/compliance_check_sets/show.html.slim b/app/views/compliance_check_sets/show.html.slim index 4e1a8e2f9..bf4642b21 100644 --- a/app/views/compliance_check_sets/show.html.slim +++ b/app/views/compliance_check_sets/show.html.slim @@ -9,6 +9,7 @@          = definition_list( t('metadatas'),            { I18n.t("compliance_check_sets.show.metadatas.referential") => (@compliance_check_set.referential.nil? ? '' : link_to(@compliance_check_set.referential.name, referential_path(@compliance_check_set.referential)) ),              I18n.t("compliance_check_sets.show.metadatas.referential_type") => 'Jeu de données', +            I18n.t("compliance_check_sets.show.metadatas.status") => import_status(@compliance_check_set.status, verbose: true),              I18n.t("compliance_check_sets.show.metadatas.compliance_check_set_executed") => link_to(@compliance_check_set.name, executed_workbench_compliance_check_set_path(@compliance_check_set.workbench_id, @compliance_check_set)),              I18n.t("compliance_check_sets.show.metadatas.compliance_control_owner") => @compliance_check_set.organisation.name,              I18n.t("compliance_check_sets.show.metadatas.import") => '' }) diff --git a/app/views/import_resources/show.html.slim b/app/views/import_resources/show.html.slim new file mode 100644 index 000000000..7fd8b4456 --- /dev/null +++ b/app/views/import_resources/show.html.slim @@ -0,0 +1,52 @@ +- breadcrumb :import_resource, @import_resource + +.page_content.import_messages +  .container-fluid +    .row +      .col-lg-12 +        - metadata = { 'Bilan d\'import' => link_to(@import_resource.root_import.name, workbench_import_path(@import_resource.root_import.workbench, @import_resource.root_import) ), +            'Jeu de données associé' => ( @import_resource.referential.present? ? link_to(@import_resource.referential.name, referential_path(@import_resource.referential)) : '-' ) } +        - metadata = metadata.update({t('.status') => import_status(@import_resource.status, verbose: true) }) +        = definition_list t('metadatas'), metadata + + +      .col-lg-12 +        .error_messages +          = render 'shared/iev_interfaces/messages', messages: @import_resource.messages + + +      // XXX +      //- if @import_resource.children.present? +      - if @import_resource&.netex_import&.resources.present? +        .col-lg-12 +          h2 = t('.table_title') +        .col-lg-12 +          = t('.table_explanation') +        .col-lg-12 +          = table_builder_2 @import_resource.netex_import.resources.where(resource_type: :file), +            [ \ +              TableBuilderHelper::Column.new( \ +                key: :name, \ +                attribute: 'name', \ +                sortable: false, \ +              ), \ +              TableBuilderHelper::Column.new( \ +                key: :status, \ +                attribute: Proc.new { |n| import_resource_status(n.status) }, \ +                sortable: false, \ +              ), \ +              TableBuilderHelper::Column.new( \ +                name: 'Résultat des tests' , \ +                attribute: Proc.new { |n| I18n.t('import_resources.index.metrics', n.metrics.deep_symbolize_keys) }, \ +                sortable: false, \ +              ), \ +              TableBuilderHelper::Column.new( \ +                name: 'Téléchargement' , \ +                attribute: Proc.new { |n| '<i class="fa fa-download" aria-hidden="true"></i>'.html_safe }, \ +                sortable: false, \ +                link_to: lambda do |import_resource| \ +                  workbench_import_import_resource_import_messages_path(import_resource.import.workbench, import_resource.import, import_resource, format: 'csv' ) \ +                end \ +              ), \ +            ], +            cls: 'table has-search' diff --git a/app/views/imports/import/_gtf.html.slim b/app/views/imports/import/_gtf.html.slim new file mode 100644 index 000000000..8b92f2e92 --- /dev/null +++ b/app/views/imports/import/_gtf.html.slim @@ -0,0 +1,42 @@ +.row +  .col-lg-6.col-md-6.col-sm-12.col-xs-12 +    - metadata = { t('.parent') => link_to(@import.parent.name, [@import.parent.workbench, @import.parent]) } +    - metadata = metadata.update({t('.status') => import_status(@import.status, verbose: true) }) +    - metadata = metadata.update({t('.referential') => @import.referential ? link_to(@import.referential.name, [@import.referential]) : "-" }) +    = definition_list t('metadatas'), metadata + +.col-lg-12 +  .error_messages +    = render 'shared/iev_interfaces/messages', messages: @import.main_resource.messages + +- if @import.resources.any? +  .col-lg-12 +    = table_builder_2 @import.resources, +      [ \ +        TableBuilderHelper::Column.new( \ +          name: t('.referential_name'), \ +          attribute: 'name', \ +          sortable: false, \ +          link_to: lambda do |item| \ +            referential_path(item.referential) if item.referential.present? \ +          end \ +        ), \ +        TableBuilderHelper::Column.new( \ +          key: :status, \ +          attribute: Proc.new { |n| import_status(n.status, verbose: true, default_status: :pending) }, \ +          sortable: false, \ +          link_to: lambda do |item| \ +            item.netex_import.present? ? [@import.workbench, item.netex_import] : [@import.workbench, @import, item] \ +          end \ +        )\ +      ], +      cls: 'table', +      overhead: [ \ +        {}, \ +        {}, \ +        { \ +          title: I18n.t('imports.show.summary').html_safe, \ +          width: controls.size, \ +          cls: 'overheaded-default colspan="2"' \ +        } \ +      ] diff --git a/app/views/imports/import/_netex.html.slim b/app/views/imports/import/_netex.html.slim new file mode 100644 index 000000000..2f341016a --- /dev/null +++ b/app/views/imports/import/_netex.html.slim @@ -0,0 +1,44 @@ +.row +  .col-lg-6.col-md-6.col-sm-12.col-xs-12 +    - metadata = { t('.parent') => link_to(@import.parent.name, [@import.parent.workbench, @import.parent]) } +    - metadata = metadata.update({t('.status') => import_status(@import.status, verbose: true) }) +    - metadata = metadata.update({t('.referential') => @import.referential ? link_to(@import.referential.name, [@import.referential]) : "-" }) +    = definition_list t('metadatas'), metadata + +.col-lg-12 +  .error_messages +    = render 'shared/iev_interfaces/messages', messages: @import.main_resource.messages + +- if @import.resources.present? +  .col-lg-12 +    h2 = t('.table_title') +  .col-lg-12 +    = t('.table_explanation') +  .col-lg-12 +    = table_builder_2 @import.resources.where(resource_type: :file), +      [ \ +        TableBuilderHelper::Column.new( \ +          key: :name, \ +          attribute: 'name', \ +          sortable: false, \ +        ), \ +        TableBuilderHelper::Column.new( \ +          key: :status, \ +          attribute: Proc.new { |n| import_resource_status(n.status) }, \ +          sortable: false, \ +        ), \ +        TableBuilderHelper::Column.new( \ +          name: 'Résultat des tests' , \ +          attribute: Proc.new { |n| I18n.t('import_resources.index.metrics', n.metrics.deep_symbolize_keys) }, \ +          sortable: false, \ +        ), \ +        TableBuilderHelper::Column.new( \ +          name: 'Téléchargement' , \ +          attribute: Proc.new { |n| '<i class="fa fa-download" aria-hidden="true"></i>'.html_safe }, \ +          sortable: false, \ +          link_to: lambda do |import_resource| \ +            workbench_import_import_resource_import_messages_path(import_resource.import.workbench, import_resource.import, import_resource, format: 'csv' ) \ +          end \ +        ), \ +      ], +      cls: 'table has-search' diff --git a/app/views/imports/import/_workbench.html.slim b/app/views/imports/import/_workbench.html.slim new file mode 100644 index 000000000..e41ceb0f0 --- /dev/null +++ b/app/views/imports/import/_workbench.html.slim @@ -0,0 +1,53 @@ +.row +  .col-lg-6.col-md-6.col-sm-12.col-xs-12 +    - metadata = { t('.data_recovery') => '-', t('.filename') => @import.try(:file_identifier)} +    - metadata = metadata.update({t('.status') => import_status(@import.status, verbose: true) }) +    = definition_list t('metadatas'), metadata + +.col-lg-12 +  .error_messages +    = render 'shared/iev_interfaces/messages', messages: @import.messages + +ruby: + controls = @workbench.workgroup.import_compliance_control_sets.map do |key, label| +   TableBuilderHelper::Column.new( +     name: label, +     attribute: Proc.new { |n| n.workbench.compliance_control_set(key).present? ? import_status(n.workbench_import_check_set(key)&.status, verbose: true, default_status: (n.status == "ERROR" ? :aborted : :pending)) : '-' }, +     sortable: false, +     link_to: lambda do |item| +       item.workbench_import_check_set(key).present? && [@import.workbench, item.workbench_import_check_set(key)] +    end +    ) +  end + +- if @import.resources.any? +  .col-lg-12 +    = table_builder_2 @import.resources, +      [ \ +        TableBuilderHelper::Column.new( \ +          name: t('.referential_name'), \ +          attribute: 'name', \ +          sortable: false, \ +          link_to: lambda do |item| \ +            referential_path(item.referential) if item.referential.present? \ +          end \ +        ), \ +        TableBuilderHelper::Column.new( \ +          key: :status, \ +          attribute: Proc.new { |n| import_status(n.netex_import&.status || n.status, verbose: true, default_status: :pending) }, \ +          sortable: false, \ +          link_to: lambda do |item| \ +            item.netex_import.present? ? [@import.workbench, item.netex_import] : [@import.workbench, @import, item] \ +          end \ +        ), *controls \ +      ], +      cls: 'table', +      overhead: [ \ +        {}, \ +        {}, \ +        controls.present? ? { \ +          title: I18n.t('imports.show.summary').html_safe, \ +          width: controls.size, \ +          cls: "overheaded-default colspan='#{controls.size}'" \ +        } : nil \ +      ].compact diff --git a/app/views/imports/show.html.slim b/app/views/imports/show.html.slim index 9d0a6423d..10552129d 100644 --- a/app/views/imports/show.html.slim +++ b/app/views/imports/show.html.slim @@ -4,57 +4,4 @@  .page_content    .container-fluid -    .row -      .col-lg-6.col-md-6.col-sm-12.col-xs-12 -        = definition_list t('metadatas'), { t('.data_recovery') => '-', t('.filename') => @import.try(:file_identifier)} - -    .row -      .col-lg-12 -        .error_messages -          = render 'shared/iev_interfaces/messages', messages: @import.messages - -    - if @import.children.any? -      .row -        .col-lg-12 -          = table_builder_2 @import.children, -            [ \ -              TableBuilderHelper::Column.new( \ -                name: t('.referential_name'), \ -                attribute: 'name', \ -                sortable: false, \ -                link_to: lambda do |import| \ -                  referential_path(import.referential) if import.referential.present? \ -                end \ -              ), \ -              TableBuilderHelper::Column.new( \ -                key: :status, \ -                attribute: Proc.new { |n| import_status(n.status) }, \ -                sortable: false, \ -                link_to: lambda do |import| \ -                  workbench_import_import_resources_path(import.workbench_id, import) \ -                end \ -              ), \ -              TableBuilderHelper::Column.new( \ -                name: t('.stif_control'), \ -                attribute: '', \ -                sortable: false, \ -              ), \ -              TableBuilderHelper::Column.new( \ -                name: t('.organisation_control'), \ -                attribute: '', \ -                sortable: false, \ -              ) \ -            ], -            cls: 'table', -            overhead: [ \ -              {}, \ -              { \ -                title: I18n.t('imports.show.results', count: @import.children_succeedeed, total: @import.children.count), \ -                width: 1, \ -                cls: "#{@import.import_status_css_class} full-border" \ -              }, { \ -                title: I18n.t('imports.show.summary').html_safe, \ -                width: 2, \ -                cls: 'overheaded-default colspan="2"' \ -              } \ -            ] +    = render partial: "imports/#{@import.type.tableize.singularize}" diff --git a/app/views/layouts/navigation/_main_nav_left_content.html.slim b/app/views/layouts/navigation/_main_nav_left_content.html.slim index 0b55578a7..889f8f944 100644 --- a/app/views/layouts/navigation/_main_nav_left_content.html.slim +++ b/app/views/layouts/navigation/_main_nav_left_content.html.slim @@ -15,6 +15,9 @@              span = t('layouts.navbar.workbench_outputs.organisation')            = link_to '#', class: 'list-group-item disabled' do              span = t('layouts.navbar.workbench_outputs.workgroup') +          - if policy(workbench.workgroup).edit? +            = link_to [:edit, workbench.workgroup], class: 'list-group-item' do +              span = t('layouts.navbar.workbench_outputs.edit_workgroup')      .menu-item.panel        .panel-heading @@ -36,7 +39,10 @@              span = t('activerecord.models.compliance_check_set.other').capitalize            = link_to compliance_control_sets_path, class: 'list-group-item' do              span = t('activerecord.models.compliance_control_set.other').capitalize -             +          - if policy(workbench).edit? +            = link_to [:edit, workbench], class: 'list-group-item' do +              span = t('workbenches.edit.link') +      .menu-item.panel        .panel-heading          h4.panel-title diff --git a/app/views/layouts/navigation/_main_nav_left_content_stif.html.slim b/app/views/layouts/navigation/_main_nav_left_content_stif.html.slim index 9404eeae6..a7bb3f511 100644 --- a/app/views/layouts/navigation/_main_nav_left_content_stif.html.slim +++ b/app/views/layouts/navigation/_main_nav_left_content_stif.html.slim @@ -14,6 +14,9 @@              span = t('layouts.navbar.workbench_outputs.organisation')            = link_to '#', class: 'list-group-item disabled' do              span = t('layouts.navbar.workbench_outputs.workgroup') +          - if policy(workbench.workgroup).edit? +            = link_to [:edit, workbench.workgroup], class: 'list-group-item' do +              span = t('layouts.navbar.workbench_outputs.edit_workgroup')      .menu-item.panel        .panel-heading @@ -35,6 +38,9 @@              span = t('activerecord.models.compliance_check_set.other').capitalize            = link_to compliance_control_sets_path, class: 'list-group-item' do              span = t('activerecord.models.compliance_control_set.other').capitalize +          - if policy(workbench).edit? +            = link_to [:edit, workbench], class: 'list-group-item' do +              span = t('workbenches.edit.link')      .menu-item.panel        .panel-heading diff --git a/app/views/workbenches/_form.html.slim b/app/views/workbenches/_form.html.slim index 534a5f378..819346c35 100644 --- a/app/views/workbenches/_form.html.slim +++ b/app/views/workbenches/_form.html.slim @@ -1,9 +1,8 @@  = simple_form_for @workbench, html: { class: 'form-horizontal', id: 'workbench_form' }, wrapper: :horizontal_form do |f|    .row      .col-lg-12 -      = f.input :import_compliance_control_set_id, as: :select, collection: current_organisation.compliance_control_sets, value_method: :id -      = f.input :merge_compliance_control_set_id, as: :select, collection: current_organisation.compliance_control_sets, value_method: :id - -  .separator +      = f.fields_for :compliance_control_set_ids do |ff| +        - @workbench.workgroup.compliance_control_sets_by_workbench.each do |cc, label| +          = ff.input cc, as: :select, collection: current_organisation.compliance_control_sets, value_method: :id, label: label, selected: @workbench.compliance_control_set(cc).try(:id).try(:to_s), include_blank: true    = f.button :submit, t('actions.submit'), class: 'btn btn-default formSubmitr', form: 'workbench_form' diff --git a/app/views/workgroups/_form.html.slim b/app/views/workgroups/_form.html.slim new file mode 100644 index 000000000..7245cfc40 --- /dev/null +++ b/app/views/workgroups/_form.html.slim @@ -0,0 +1,15 @@ += simple_form_for @workgroup, html: { class: 'form-horizontal', id: 'workgroup_form' }, wrapper: :horizontal_form do |f| +  table.table +    thead +      th +        - @workgroup.compliance_control_sets_by_workgroup.values.each do |cc| +          th= cc +    - @workgroup.workbenches.each_with_index do |w,i| +      tr +        th= w.organisation.name +        - @workgroup.compliance_control_sets_by_workgroup.keys.each do |cc| +          td +            = hidden_field_tag "workgroup[workbenches_attributes][#{i}][id]", w.id +            = select_tag "workgroup[workbenches_attributes][#{i}][compliance_control_set_ids][#{cc}]", options_from_collection_for_select(current_organisation.compliance_control_sets, :id, :name, w.compliance_control_set(cc).try(:id)), include_blank: true + +  = f.button :submit, t('actions.submit'), class: 'btn btn-default formSubmitr', form: 'workgroup_form' diff --git a/app/views/workgroups/edit.html.slim b/app/views/workgroups/edit.html.slim new file mode 100644 index 000000000..49847acf2 --- /dev/null +++ b/app/views/workgroups/edit.html.slim @@ -0,0 +1,8 @@ +- breadcrumb @workgroup +- page_header_content_for @workgroup + +.page_content + .container-fluid +   .row +     .col-lg-8.col-lg-offset-2.col-md-8.col-md-offset-2.col-sm-10.col-sm-offset-1 +       == render 'form' diff --git a/app/workers/compliance_control_set_copy_worker.rb b/app/workers/compliance_control_set_copy_worker.rb index d18bb0c88..b87f5ad8e 100644 --- a/app/workers/compliance_control_set_copy_worker.rb +++ b/app/workers/compliance_control_set_copy_worker.rb @@ -1,8 +1,9 @@  class ComplianceControlSetCopyWorker    include Sidekiq::Worker -  def perform(control_set_id, referential_id) +  def perform(control_set_id, referential_id, parent_type = nil, parent_id = nil)      check_set = ComplianceControlSetCopier.new.copy(control_set_id, referential_id) +    check_set.update parent_type: parent_type, parent_id: parent_id if parent_type && parent_id      begin        Net::HTTP.get(URI("#{Rails.configuration.iev_url}/boiv_iev/referentials/validator/new?id=#{check_set.id}")) diff --git a/app/workers/workbench_import_worker/object_state_updater.rb b/app/workers/workbench_import_worker/object_state_updater.rb index 1edc6b9a1..39d5f20b1 100644 --- a/app/workers/workbench_import_worker/object_state_updater.rb +++ b/app/workers/workbench_import_worker/object_state_updater.rb @@ -2,6 +2,11 @@  class WorkbenchImportWorker    module ObjectStateUpdater +    def resource entry +      @_resources ||= {} +      @_resources[entry.name] ||= workbench_import.resources.find_or_create_by(name: entry.name, resource_type: "referential") +    end +      def update_object_state entry, count        workbench_import.update( total_steps: count )        update_spurious entry @@ -14,44 +19,48 @@ class WorkbenchImportWorker      def update_foreign_lines entry        return if entry.foreign_lines.empty? -      workbench_import.messages.create( +      resource(entry).messages.create(          criticity: :error,          message_key: 'foreign_lines_in_referential',          message_attributes: {            'source_filename' => workbench_import.file.file.file,            'foreign_lines'   => entry.foreign_lines.join(', ')          }) +      resource(entry).update status: :ERROR      end      def update_spurious entry        return if entry.spurious.empty? -      workbench_import.messages.create( +      resource(entry).messages.create(          criticity: :error,          message_key: 'inconsistent_zip_file',          message_attributes: {            'source_filename' => workbench_import.file.file.file,            'spurious_dirs'   => entry.spurious.join(', ')          }) +      resource(entry).update status: :ERROR      end      def update_missing_calendar entry        return unless entry.missing_calendar -      workbench_import.messages.create( +      resource(entry).messages.create(          criticity: :error,          message_key: 'missing_calendar_in_zip_file',          message_attributes: {            'source_filename' => entry.name          }) +      resource(entry).update status: :ERROR      end      def update_wrong_calendar entry        return unless entry.wrong_calendar -      workbench_import.messages.create( +      resource(entry).messages.create(          criticity: :error,          message_key: 'wrong_calendar_in_zip_file',          message_attributes: {            'source_filename' => entry.name          }) +      resource(entry).update status: :ERROR      end    end  end | 
