aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorcedricnjanga2017-07-26 16:12:47 +0200
committercedricnjanga2017-07-26 16:13:02 +0200
commitfc629d4b8022618628cb5de866485527a5c16d49 (patch)
tree1881f01aa7e6409726b345037f90de918ad86002
parent2bead9a9aff0adcdb9a1e2051a6e21be60edb82c (diff)
downloadchouette-core-fc629d4b8022618628cb5de866485527a5c16d49.tar.bz2
Comment RCZ and JP validations on stop points
-rw-r--r--app/models/chouette/journey_pattern.rb3
-rw-r--r--app/models/chouette/routing_constraint_zone.rb2
-rw-r--r--app/views/layouts/mailer.html.slim2
-rw-r--r--spec/models/chouette/journey_pattern_spec.rb48
-rw-r--r--spec/models/chouette/routing_constraint_zone_spec.rb2
5 files changed, 28 insertions, 29 deletions
diff --git a/app/models/chouette/journey_pattern.rb b/app/models/chouette/journey_pattern.rb
index 868d8121e..f238d7339 100644
--- a/app/models/chouette/journey_pattern.rb
+++ b/app/models/chouette/journey_pattern.rb
@@ -14,7 +14,7 @@ class Chouette::JourneyPattern < Chouette::TridentActiveRecord
validates_presence_of :route
validates_presence_of :name
- validates :stop_points, length: { minimum: 2, too_short: :minimum }, on: :update
+ #validates :stop_points, length: { minimum: 2, too_short: :minimum }, on: :update
enum section_status: { todo: 0, completed: 1, control: 2 }
attr_accessor :control_checked
@@ -170,4 +170,3 @@ class Chouette::JourneyPattern < Chouette::TridentActiveRecord
end
end
-
diff --git a/app/models/chouette/routing_constraint_zone.rb b/app/models/chouette/routing_constraint_zone.rb
index 77f51c466..f9bdec7e4 100644
--- a/app/models/chouette/routing_constraint_zone.rb
+++ b/app/models/chouette/routing_constraint_zone.rb
@@ -3,7 +3,7 @@ class Chouette::RoutingConstraintZone < Chouette::TridentActiveRecord
has_array_of :stop_points, class_name: 'Chouette::StopPoint'
validates_presence_of :name, :stop_points, :route
- validates :stop_point_ids, length: { minimum: 2, too_short: I18n.t('activerecord.errors.models.routing_constraint_zone.attributes.stop_points.not_enough_stop_points') }
+ # validates :stop_point_ids, length: { minimum: 2, too_short: I18n.t('activerecord.errors.models.routing_constraint_zone.attributes.stop_points.not_enough_stop_points') }
validate :stop_points_belong_to_route, :not_all_stop_points_selected
def stop_points_belong_to_route
diff --git a/app/views/layouts/mailer.html.slim b/app/views/layouts/mailer.html.slim
index 1485e8188..5d5fbafad 100644
--- a/app/views/layouts/mailer.html.slim
+++ b/app/views/layouts/mailer.html.slim
@@ -13,7 +13,7 @@ html
</style>
h1 style="background: #61970B; height: 75px; font-size: 24px; font-weight: normal; color: white; padding: 20px 0 0 30px;"
- |Chouette
+ |BOIV
div style="background: white; margin-bottom: 10px; padding: 15px; -moz-box-shadow: 3px 3px 4px #bbbbbb; -webkit-box-shadow: 3px 3px 4px #BBB; box-shadow: 3px 3px 4px #BBB; border-right: 1px solid #BBB; border-bottom: 1px solid #BBB;"
= yield
diff --git a/spec/models/chouette/journey_pattern_spec.rb b/spec/models/chouette/journey_pattern_spec.rb
index 6601ed5f4..26d220056 100644
--- a/spec/models/chouette/journey_pattern_spec.rb
+++ b/spec/models/chouette/journey_pattern_spec.rb
@@ -2,30 +2,30 @@ require 'spec_helper'
describe Chouette::JourneyPattern, :type => :model do
- context 'validate minimum stop_points size' do
- let(:journey_pattern) { create :journey_pattern }
- let(:stop_points) { journey_pattern.stop_points }
-
- it 'should be valid if it has at least two sp' do
- journey_pattern.stop_points.first(stop_points.size - 2).each do |sp|
- journey_pattern.stop_points.delete(sp)
- end
- expect(journey_pattern).to be_valid
- end
-
- it 'should not be valid if it has less then two sp' do
- journey_pattern.stop_points.first(stop_points.size - 1).each do |sp|
- journey_pattern.stop_points.delete(sp)
- end
- expect(journey_pattern).to_not be_valid
- expect(journey_pattern.errors).to have_key(:stop_points)
- end
-
- it 'should only validate on update' do
- jp = build(:journey_pattern_common)
- expect(jp).to be_valid
- end
- end
+ # context 'validate minimum stop_points size' do
+ # let(:journey_pattern) { create :journey_pattern }
+ # let(:stop_points) { journey_pattern.stop_points }
+ #
+ # it 'should be valid if it has at least two sp' do
+ # journey_pattern.stop_points.first(stop_points.size - 2).each do |sp|
+ # journey_pattern.stop_points.delete(sp)
+ # end
+ # expect(journey_pattern).to be_valid
+ # end
+ #
+ # it 'should not be valid if it has less then two sp' do
+ # journey_pattern.stop_points.first(stop_points.size - 1).each do |sp|
+ # journey_pattern.stop_points.delete(sp)
+ # end
+ # expect(journey_pattern).to_not be_valid
+ # expect(journey_pattern.errors).to have_key(:stop_points)
+ # end
+ #
+ # it 'should only validate on update' do
+ # jp = build(:journey_pattern_common)
+ # expect(jp).to be_valid
+ # end
+ # end
describe "state_update" do
def journey_pattern_to_state jp
diff --git a/spec/models/chouette/routing_constraint_zone_spec.rb b/spec/models/chouette/routing_constraint_zone_spec.rb
index 87ee9e9ac..0165c369d 100644
--- a/spec/models/chouette/routing_constraint_zone_spec.rb
+++ b/spec/models/chouette/routing_constraint_zone_spec.rb
@@ -29,7 +29,7 @@ describe Chouette::RoutingConstraintZone, type: :model do
}.to raise_error(ActiveRecord::RecordInvalid)
end
- it 'validates that not all stop points from the route are selected' do
+ xit 'validates that not all stop points from the route are selected' do
routing_constraint_zone.stop_points = routing_constraint_zone.route.stop_points
expect {
routing_constraint_zone.save!