diff options
| author | Teddy Wing | 2017-07-21 15:56:29 +0200 |
|---|---|---|
| committer | Teddy Wing | 2017-07-21 15:59:53 +0200 |
| commit | ad269197f5c2c328d480aa5af52fb085d57b6cbc (patch) | |
| tree | d8799f7bf1cd5f07cc6cd330cfb880679550ede3 | |
| parent | 490c4bba551803f45f5b9a854d10e5f56e4fa480 (diff) | |
| download | chouette-core-ad269197f5c2c328d480aa5af52fb085d57b6cbc.tar.bz2 | |
VehicleJourneyAtStop spec: Remove unnecessary initial values
I had created an at-stop with nil `arrival_day_offset` and
`departure_day_offset` values because that's the kind of object this
test is testing, but when I reviewed the code, it occurred to me that
since the method takes the offset as an argument, it isn't necessary to
provide these attribute values to the factory.
Not sure whether it's clearer this way or the way it was before, but I
figured since they're not necessary it may be better to remove them.
Refs #3597
| -rw-r--r-- | spec/models/chouette/vehicle_journey_at_stop_spec.rb | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/spec/models/chouette/vehicle_journey_at_stop_spec.rb b/spec/models/chouette/vehicle_journey_at_stop_spec.rb index 38196bb88..d999ed1a8 100644 --- a/spec/models/chouette/vehicle_journey_at_stop_spec.rb +++ b/spec/models/chouette/vehicle_journey_at_stop_spec.rb @@ -21,12 +21,6 @@ RSpec.describe Chouette::VehicleJourneyAtStop, type: :model do end it "forces a nil offset to 0" do - at_stop = build_stubbed( - :vehicle_journey_at_stop, - arrival_day_offset: nil, - departure_day_offset: nil - ) - expect(at_stop.day_offset_outside_range?(nil)).to be false end end |
